From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3E473AC12E6 for ; Thu, 8 Feb 2024 17:58:39 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=YDbsGKUwAuPK44fMJKecxcvgO/5dGPWCbX3uIzwcV/A=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:CC:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1707415117; v=1; b=JrWEIGtQn1HBg5XsQSTON42zXek6ofbtk36KGqh054O4/719zsfZ2Q92utYCM+atfbETTSuL hlOMlw9MT39yS8qkHLekW2aeu9K3NLcoKkqs//bqPT7xu7WBDqlZ/Bys5pbsELPTl+Sa+b6U0k3 rSMk74kNC1uyZp5QkqYk4wn0= X-Received: by 127.0.0.2 with SMTP id TaXDYY7687511xvrrBIn22lX; Thu, 08 Feb 2024 09:58:37 -0800 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.894.1707415117106695366 for ; Thu, 08 Feb 2024 09:58:37 -0800 X-Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 418GhofJ009406; Thu, 8 Feb 2024 17:58:33 GMT X-Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3w4rk81xtp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 08 Feb 2024 17:58:32 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 418HwVek015162 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 8 Feb 2024 17:58:31 GMT X-Received: from [10.111.139.3] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 8 Feb 2024 09:58:30 -0800 Message-ID: Date: Thu, 8 Feb 2024 17:58:07 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2 Patch 1/1] EmbeddedPkg: Fix compiler errors due to implicit conversions To: Laszlo Ersek , Jayaprakash N , CC: Rebecca Cran , Michael D Kinney , Ard Biesheuvel , Abner Chang References: <20240206162311.1321-1-n.jayaprakash@intel.com> <20240206162311.1321-2-n.jayaprakash@intel.com> <017b4577-62cb-6f94-be2f-f54cdc98494d@redhat.com> From: "Leif Lindholm" In-Reply-To: <017b4577-62cb-6f94-be2f-f54cdc98494d@redhat.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: WU3XFwfGUqhWkTi4li5jPcZSQer8trhF X-Proofpoint-ORIG-GUID: WU3XFwfGUqhWkTi4li5jPcZSQer8trhF Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 5CymOzrcWuJDR04p9yCIG4Lix7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=JrWEIGtQ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 2024-02-07 19:59, Laszlo Ersek wrote: > On 2/6/24 17:23, Jayaprakash N wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4669 >> >> This commit fixes compilation issues reported through BZ4669. >> There were several compilation errors due to implicit type >> conversions in EmbeddedPkg. Fixed all the issues with the >> correct usage of explicit type conversions based on the >> context. >> >> Cc: Rebecca Cran >> Cc: Michael D Kinney >> Cc: Laszlo Ersek >> Cc: Leif Lindholm >> Cc: Ard Biesheuvel >> Cc: Abner Chang >> Cc: Jayaprakash N >> Signed-off-by: Jayaprakash N >> --- >> EmbeddedPkg/GdbStub/X64/Processor.c | 36 +++++++++---------- >> EmbeddedPkg/Include/libfdt_env.h | 8 ++--- >> EmbeddedPkg/Library/FdtLib/fdt.c | 9 ++--- >> EmbeddedPkg/Library/FdtLib/fdt_overlay.c | 20 +++++------ >> EmbeddedPkg/Library/FdtLib/fdt_ro.c | 32 ++++++++--------- >> EmbeddedPkg/Library/FdtLib/fdt_rw.c | 24 ++++++------- >> EmbeddedPkg/Library/FdtLib/fdt_strerror.c | 2 +- >> EmbeddedPkg/Library/FdtLib/fdt_strtoul.c | 2 +- >> EmbeddedPkg/Library/FdtLib/fdt_sw.c | 10 +++--- >> EmbeddedPkg/Library/FdtLib/fdt_wip.c | 4 +-- >> .../MemoryAllocationLib.c | 2 +- >> EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c | 8 ++--- >> .../Universal/MmcDxe/MmcIdentification.c | 22 ++++++------ >> 13 files changed, 90 insertions(+), 89 deletions(-) >=20 > This patch does way too many things at once. Please, minimally, split it > into multiple patches, at module boundaries. >=20 > Second, I'm unsure if edk2 considers FdtLib a completely detached fork > of libfdt, at this point. If so, then fixing the warnings in the edk2 > tree is valid (but should still be likely structured with finer > granularity). If not (i.e., if we still intend to update FdtLib to more > recent libfdt versions in the future), then these fixes don't belong in > edk2 (we'd have to redo them after every update); they should be > upstreamed to libfdt. The EmbeddedPkg FdtLib is superseded by the MdePkg BaseFdtLib. My intent is to drop it, but I didn't get around to doing the rework of existing users in time for the soft freeze. / Leif -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115271): https://edk2.groups.io/g/devel/message/115271 Mute This Topic: https://groups.io/mt/104200931/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-