From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D65962194D387 for ; Thu, 6 Sep 2018 09:18:34 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 379A97A7E7; Thu, 6 Sep 2018 16:18:33 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-62.rdu2.redhat.com [10.10.120.62]) by smtp.corp.redhat.com (Postfix) with ESMTP id 306292166B41; Thu, 6 Sep 2018 16:18:31 +0000 (UTC) To: "Gao, Liming" , Ard Biesheuvel Cc: "Carsey, Jaben" , "Ni, Ruiyu" , "edk2-devel@lists.01.org" References: <20180809054155.30244-1-shenglei.zhang@intel.com> <809ce67145704edeb41da02b7e5bdce5@ausx13mps335.AMER.DELL.COM> <17d57db5-c15a-b71b-3d82-39aaad39ece2@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E2EE969@SHSMSX104.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: Date: Thu, 6 Sep 2018 18:18:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2EE969@SHSMSX104.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Thu, 06 Sep 2018 16:18:33 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Thu, 06 Sep 2018 16:18:33 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH] ShellPkg Shell: Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Sep 2018 16:18:35 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/06/18 17:22, Gao, Liming wrote: > The build log shows the error message. I agree to remove this unused global variable InvalidChars in this patch. > > /home/buildslave/workspace/leg-virt-tianocore-edk2-upstream/edk2/ShellPkg/Application/Shell/Shell.c:2754:21: error: unused variable 'InvalidChars' [-Werror,-Wunused-const-variable] > 12:23:26 STATIC CONST UINT16 InvalidChars[] = {L'*', L'?', L'<', L'>', L'\\', L'/', L'\"', 0x0001, 0x0002}; OK... should we file a TianoCore BZ about this and wait until it gets assigned and fixed, should we ask Shenglei just on the list to post a follow-up (like Ard already did), or should one of us that actually encounters the error post the one-liner patch? (I would have already posted the patch if I could actually reproduce the error.) Thanks Laszlo >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel >> Sent: Thursday, September 6, 2018 8:31 PM >> To: Laszlo Ersek >> Cc: Carsey, Jaben ; Ni, Ruiyu ; edk2-devel@lists.01.org >> Subject: Re: [edk2] [PATCH] ShellPkg Shell: Remove redundant functions >> >> On 6 September 2018 at 14:24, Laszlo Ersek wrote: >>> On 09/06/18 12:28, Ard Biesheuvel wrote: >>>> On 9 August 2018 at 17:41, wrote: >>>>> The InvalidChars[] array is only used in function IsValidCommandName(). >>>>> The array should be deleted also, I think. >>>>> >>>> >>>> Indeed, and for this reason this patch has now broken the build for >>>> clang. Please fix. >>> >>> I agree about InvalidChars being unused, post-22cf747fcf75. I just can't >>> reproduce the build error, with CLANG38 (3.8.1). The command >>> >>> build -a X64 -p ShellPkg/ShellPkg.dsc -b RELEASE -t CLANG38 \ >>> -m ShellPkg/Application/Shell/Shell.inf >>> >>> seems to work for me, also with "-b DEBUG". >>> >>> What differs on your end? >>> >> >> Not sure what the exact difference is, but I am using CLANG35 profile: >> >> https://ci.linaro.org/job/leg-virt-tianocore-edk2-upstream/3176/consoleFull >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel