Re: [edk2-devel] [PATCH v1] UefiCpuPkg/CpuTimerLib: Update LIBRARY_CLASS of Base instance.

["Laszlo Ersek" <lersek@redhat.com>]

On 04/12/21 05:09, Ni, Ray wrote:
> Laszlo,
> This is also related to CpuTimerLib. I assume that you won't have any concern if I merge today😊
> 
> We need the INF change very urgently because with the removal of DxeCpuTimerLib, DXE module must use
> BaseCpuTImerLib but the INF doesn't allow it.

Sure, please go ahead.

Thanks
Laszlo

> 
> Thanks,
> Ray
> 
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni, Ray
>> Sent: Monday, April 12, 2021 10:02 AM
>> To: Lou, Yun <yun.lou@intel.com>; devel@edk2.groups.io
>> Cc: Dong, Eric <eric.dong@intel.com>; Laszlo Ersek <lersek@redhat.com>;
>> Kumar, Rahul1 <rahul1.kumar@intel.com>
>> Subject: Re: [edk2-devel] [PATCH v1] UefiCpuPkg/CpuTimerLib: Update
>> LIBRARY_CLASS of Base instance.
>>
>> Reviewed-by: Ray Ni <ray.ni@intel.com>
>>
>>> -----Original Message-----
>>> From: Lou, Yun <yun.lou@intel.com>
>>> Sent: Saturday, April 10, 2021 11:23 PM
>>> To: devel@edk2.groups.io
>>> Cc: Lou, Yun <yun.lou@intel.com>; Ni, Ray <ray.ni@intel.com>; Dong, Eric
>>> <eric.dong@intel.com>; Laszlo Ersek <lersek@redhat.com>; Kumar, Rahul1
>>> <rahul1.kumar@intel.com>
>>> Subject: [PATCH v1] UefiCpuPkg/CpuTimerLib: Update LIBRARY_CLASS of
>>> Base instance.
>>>
>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2832
>>>
>>> Update LIBRARY_CLASS of BaseCpuTimerLib to remove the usage limitation,
>>> otherwise the Base instance cannot be used in some types of modules.
>>>
>>> Signed-off-by: Jason Lou <yun.lou@intel.com>
>>> Cc: Ray Ni <ray.ni@intel.com>
>>> Cc: Eric Dong <eric.dong@intel.com>
>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>> Cc: Rahul Kumar <rahul1.kumar@intel.com>
>>> ---
>>>  UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf
>>> b/UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf
>>> index fd93adc5f1..de0648de91 100644
>>> --- a/UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf
>>> +++ b/UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf
>>> @@ -4,7 +4,7 @@
>>>  #  Provides basic timer support using CPUID Leaf 0x15 XTAL frequency. The
>>> performance
>>>
>>>  #  counter features are provided by the processors time stamp counter.
>>>
>>>  #
>>>
>>> -#  Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
>>>
>>> +#  Copyright (c) 2021, Intel Corporation. All rights reserved.<BR>
>>>
>>>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>>>
>>>  #
>>>
>>>  ##
>>>
>>> @@ -15,7 +15,7 @@
>>>    FILE_GUID                      = F10B5B91-D15A-496C-B044-B5235721AA08
>>>
>>>    MODULE_TYPE                    = BASE
>>>
>>>    VERSION_STRING                 = 1.0
>>>
>>> -  LIBRARY_CLASS                  = TimerLib|SEC PEI_CORE PEIM
>>>
>>> +  LIBRARY_CLASS                  = TimerLib
>>>
>>>    MODULE_UNI_FILE                = BaseCpuTimerLib.uni
>>>
>>>
>>>
>>>  [Sources]
>>>
>>> --
>>> 2.28.0.windows.1
>>
>>
>>
>> 
>>
>