From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web11.30329.1618224085148385775 for ; Mon, 12 Apr 2021 03:41:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=jUbEziCc; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618224084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZElGfhVWq48ZozdlTh9+8QKJK6R9kw/g6kcQuTs2uXw=; b=jUbEziCconKEmi2sXu/j9Lqm7KEb6iVBt9gxBntCprAzoUI1nn7uJFfnRGs8UZTYg3Wjg2 8WRBrhifwZnXJSKevMwsuSkkMzIpOQEzBLM5WZ3V4+xoIZnQm+WczGqdCmDq7uuTrzWUzr DNIv5RJuO2mhSDCdIvUvWL8fYNXkby0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-323-AtOB_q0hO3u-k5vnubTOww-1; Mon, 12 Apr 2021 06:41:20 -0400 X-MC-Unique: AtOB_q0hO3u-k5vnubTOww-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 848B31006C99; Mon, 12 Apr 2021 10:41:19 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-23.ams2.redhat.com [10.36.115.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id 25F501B5BD; Mon, 12 Apr 2021 10:41:17 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v1] UefiCpuPkg/CpuTimerLib: Update LIBRARY_CLASS of Base instance. To: "Ni, Ray" , "devel@edk2.groups.io" , "Lou, Yun" Cc: "Dong, Eric" , "Kumar, Rahul1" References: <20210410152317.15057-1-yun.lou@intel.com> <1674F9E08CBBC9C1.21233@groups.io> From: "Laszlo Ersek" Message-ID: Date: Mon, 12 Apr 2021 12:41:17 +0200 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 04/12/21 05:09, Ni, Ray wrote: > Laszlo, > This is also related to CpuTimerLib. I assume that you won't have any concern if I merge today😊 > > We need the INF change very urgently because with the removal of DxeCpuTimerLib, DXE module must use > BaseCpuTImerLib but the INF doesn't allow it. Sure, please go ahead. Thanks Laszlo > > Thanks, > Ray > >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Ni, Ray >> Sent: Monday, April 12, 2021 10:02 AM >> To: Lou, Yun ; devel@edk2.groups.io >> Cc: Dong, Eric ; Laszlo Ersek ; >> Kumar, Rahul1 >> Subject: Re: [edk2-devel] [PATCH v1] UefiCpuPkg/CpuTimerLib: Update >> LIBRARY_CLASS of Base instance. >> >> Reviewed-by: Ray Ni >> >>> -----Original Message----- >>> From: Lou, Yun >>> Sent: Saturday, April 10, 2021 11:23 PM >>> To: devel@edk2.groups.io >>> Cc: Lou, Yun ; Ni, Ray ; Dong, Eric >>> ; Laszlo Ersek ; Kumar, Rahul1 >>> >>> Subject: [PATCH v1] UefiCpuPkg/CpuTimerLib: Update LIBRARY_CLASS of >>> Base instance. >>> >>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2832 >>> >>> Update LIBRARY_CLASS of BaseCpuTimerLib to remove the usage limitation, >>> otherwise the Base instance cannot be used in some types of modules. >>> >>> Signed-off-by: Jason Lou >>> Cc: Ray Ni >>> Cc: Eric Dong >>> Cc: Laszlo Ersek >>> Cc: Rahul Kumar >>> --- >>> UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf >>> b/UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf >>> index fd93adc5f1..de0648de91 100644 >>> --- a/UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf >>> +++ b/UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf >>> @@ -4,7 +4,7 @@ >>> # Provides basic timer support using CPUID Leaf 0x15 XTAL frequency. The >>> performance >>> >>> # counter features are provided by the processors time stamp counter. >>> >>> # >>> >>> -# Copyright (c) 2019, Intel Corporation. All rights reserved.
>>> >>> +# Copyright (c) 2021, Intel Corporation. All rights reserved.
>>> >>> # SPDX-License-Identifier: BSD-2-Clause-Patent >>> >>> # >>> >>> ## >>> >>> @@ -15,7 +15,7 @@ >>> FILE_GUID = F10B5B91-D15A-496C-B044-B5235721AA08 >>> >>> MODULE_TYPE = BASE >>> >>> VERSION_STRING = 1.0 >>> >>> - LIBRARY_CLASS = TimerLib|SEC PEI_CORE PEIM >>> >>> + LIBRARY_CLASS = TimerLib >>> >>> MODULE_UNI_FILE = BaseCpuTimerLib.uni >>> >>> >>> >>> [Sources] >>> >>> -- >>> 2.28.0.windows.1 >> >> >> >> >> >