From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web11.5055.1588245455697198520 for ; Thu, 30 Apr 2020 04:17:36 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aA/ocvIF; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588245454; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gN+3PqjTSULMnk1+U/bLGgHr05LqLAvjyFarpUSVLUE=; b=aA/ocvIFxBKq9PN6NfOpDL2y4vE50Avgd1Z5sB/tQfJ/jGAPEKurD2nw019raXD+/fw1Xn HBuSaAFX3xzyR+VE6iSq1b1o67eRefgTZeC4A/sZZg6PdX0h8AiSHHPVj4TSzBzdjJCiG4 YdhK3HAYwZl576hJonFMNJSMJJECN6E= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-296-hBGuBVcZPnKKQ8Xgrw_DUg-1; Thu, 30 Apr 2020 07:17:30 -0400 X-MC-Unique: hBGuBVcZPnKKQ8Xgrw_DUg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6B9591054F9A; Thu, 30 Apr 2020 11:17:29 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-57.ams2.redhat.com [10.36.115.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id D612360C84; Thu, 30 Apr 2020 11:17:27 +0000 (UTC) Subject: Re: [PATCH 0/3] BaseTools,EmbeddedPkg,Maintainers.txt: Obsolete some drivers To: Ard Biesheuvel , Leif Lindholm Cc: devel@edk2.groups.io, Andrew Fish , Bob Feng , Liming Gao , Michael D Kinney References: <20200429163616.5951-1-leif@nuviainc.com> <10151f16-f903-6fcf-92c8-f28f269eab53@arm.com> <20200429195343.GI21486@vanye> <464be692-53ef-8cac-ec69-2f87cc6f59cb@arm.com> <20200429214531.GN21486@vanye> <83cf98dc-ec56-2712-2835-e9b4c99049c9@arm.com> From: "Laszlo Ersek" Message-ID: Date: Thu, 30 Apr 2020 13:17:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <83cf98dc-ec56-2712-2835-e9b4c99049c9@arm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/29/20 23:47, Ard Biesheuvel wrote: > On 4/29/20 11:45 PM, Leif Lindholm wrote: >> On Wed, Apr 29, 2020 at 22:04:08 +0200, Ard Biesheuvel wrote: >>>>> I am mostly concerned about the use of MmcDxe in new platforms. The >>>>> other >>>>> bits I'm not too worried about, and I think it would be fine to >>>>> move those >>>>> into Platform/ARM/VExpressPkg in edk2-platforms, instead of hoping >>>>> that >>>>> someone will turn up and turn them into driver model drivers. >>>> >>>> We could, although I would prefer not adding code to edk2-platforms >>>> that would not be accepted was it submitted as a new contribution. >>>> The SATA controller, I would ideally re-review and merge properly. >>>> >>>> If we do include the other drivers in platform-specific directories, I >>>> want them to come with ... strongly worded readmes. >>>> >>> >>> Right. >>> >>> Should we have some format for that? A way to log shortcomings along >>> with >>> the code? >> >> Thinking a bit more on this, maybe what we should do is add a template >> to each file's top comment block. Draft proposal: >> >> =C2=A0=C2=A0 * >> =C2=A0=C2=A0 * WARNING: >> =C2=A0=C2=A0 * This driver fails to follow the UEFI driver model without= a good >> =C2=A0=C2=A0 * reason, and only remains in the tree because it is still = used by >> =C2=A0=C2=A0 * a small number of platforms. It will removed when no long= er used. >> =C2=A0=C2=A0 * New platforms should not use it, and no one should use th= is as >> =C2=A0=C2=A0 * reference code for developing new drivers. >> =C2=A0=C2=A0 * >> >=20 > Works for me >=20 You could also (or alternatively) add a separate file "DEPRECATED.txt" to the directory -- sometimes people don't read file-top comments, before duplicating or editing code. Something that's visible with a simple "ls -l" might stand out more. Just a thought, I'm neutral on this. Thanks Laszlo