From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5DB5678003C for ; Wed, 5 Jun 2024 22:48:02 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=/Y0lLb2UYdYifyc7rABG1BkPYmbAyTHeMyQYyyQb7Og=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:User-Agent:Subject:To:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1717627682; v=1; b=3xI36RBRdCU0D3HUmz5lAL1p2Nl3TgXkpzktCNieS+fKQs1FVEmmhbsTicirLTJQncTBXDm0 k7OVuiPlD91E7kBKeyLwSMOGBfnll4Cz0S/wGnXOqKjlrlgcT299LpoTDA8a0/DNm36coEmaC4u HH9RPxQ3KeMO//4kaWn8Rz5Zj/J5JKyIBLdrPqKe86XDqd9HhVbBy3pfuGPKJ+xNEhiNxhaUfMG w4tBaaiJ10/at6cBDtdzRE2n48S2ss/oTbd9bRX6P4A6ePZ7arfhdrqPqH4HQapagP9fqufnND/ MX9h7vn0hXsIJnwrEm4PLdkoIKAX78PFiA62t+6jz8viQ== X-Received: by 127.0.0.2 with SMTP id KbFeYY7687511x7UND04b9zv; Wed, 05 Jun 2024 15:48:00 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.127]) by mx.groups.io with SMTP id smtpd.web10.198.1717627679980026337 for ; Wed, 05 Jun 2024 15:48:00 -0700 X-Received: from LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) by SA0PR01MB6473.prod.exchangelabs.com (2603:10b6:806:ec::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.31; Wed, 5 Jun 2024 22:47:56 +0000 X-Received: from LV3PR01MB8464.prod.exchangelabs.com ([fe80::74dd:8ddd:b9c2:8d2d]) by LV3PR01MB8464.prod.exchangelabs.com ([fe80::74dd:8ddd:b9c2:8d2d%4]) with mapi id 15.20.7633.033; Wed, 5 Jun 2024 22:47:56 +0000 Message-ID: Date: Wed, 5 Jun 2024 16:47:51 -0600 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] GitHub PR Code Review process now active To: devel@edk2.groups.io, michael.d.kinney@intel.com References: From: "Rebecca Cran via groups.io" In-Reply-To: X-ClientProxiedBy: SJ0PR03CA0060.namprd03.prod.outlook.com (2603:10b6:a03:33e::35) To LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV3PR01MB8464:EE_|SA0PR01MB6473:EE_ X-MS-Office365-Filtering-Correlation-Id: 2bc7188f-6444-44e9-964e-08dc85b18a92 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: =?utf-8?B?RldzYW1rbDlsYUw3NnRzcThnT0tKeFZ1ZS94M2ZKU2dyVFMyZmIwUFl2WmQ4?= =?utf-8?B?VXZndFlsYkFVa1VCZDIrZjZzZE9UVDlYazljN0NHUTNyYm5UQVhvdHdrOExh?= =?utf-8?B?aUszcCt5ZCt4WnpvZVlZSTJWdmNDNWNmcFkwUE1pdWVoL2lrd1hHUFR1cjN2?= =?utf-8?B?L1Nzayt3Nnhqdzg4cEkrMlJSd2hMNXJ1RTVJV2xqNjFXOVpzTVMxREZ6QVVh?= =?utf-8?B?VmpWdkZQR1BFaHV0RGZ2U2ZncGxCeGFSaXR3UXV2ODVYL0NGOFVLNGc5dWIv?= =?utf-8?B?VURhZ3JIV28reHJnbEJqOHZzZjZianEzTWg0dnBjVUdvSzR6TU5BbURoSlJC?= =?utf-8?B?Sk9TMEtvUDIxd3FnRTY1YW1KVnNZVUtCSHUwRHdVcTRkd3NIVVRiQ0hDTFJi?= =?utf-8?B?TTdQN1IxV0ZEVHVuM1RwaWJmN2Rod2RVSnJJbTQ3SjBMUjdUemdWbGs2c1Fk?= =?utf-8?B?ZmpXQUxicmJXVHUxdE9HQVkxQUZRbDFzMWpJRkRwQ01yQ2llL3BBVFBZUm82?= =?utf-8?B?Uyt6NlpIZDRKU2ZjZXIzdFNCTGNUbVFRd0toMHpxbzlKQlFkZVZVMEQ0b0tq?= =?utf-8?B?cmlMeVhjcCs4cnZnM2FsUUNVR1Vib2xmbFhYM2lUa2g5eUh0TkpUN25idS9w?= =?utf-8?B?d1RMM2JBaGNReWoxQU8zMGt3eGRYblRCaU9UL0I0SVJpSkFzbFFERzIyWFJH?= =?utf-8?B?TDZqMjNxRTZVOWNrb1JqaFBGZlhadWVHZUlvdUlXUWtqZU5WUkFISHBtcHRz?= =?utf-8?B?cGh0bXBtNVFMWlh5dGtsMklUMVdjS3JKZ1NEK0l1em5xZENZcnhoTXcwdmNl?= =?utf-8?B?Z25OT1NCL0FHRzBYdS9DZEtwL2FTMXpWajF5cy9NSTBvUDV5TU02S3JEQVhZ?= =?utf-8?B?UTFQbTJsRkpya1A5YjNJWWRzVU1UWVhHSEQvbWtBZGMwTXlXWW9hQnovTm9I?= =?utf-8?B?cWpHTEdQSUZmT1ZDRG1JdWVLNG14L1FHeS8vZGFLZDFEdkZiejhQQU03eGhn?= =?utf-8?B?WDQ4R0RuMWwyTWROL3NMR3lJeGQwdnZmYm1yL3pUL1AzYVdSSFJpWmI1WVdX?= =?utf-8?B?bDlQcXAvWnpUYlFkcEtjeEdUMFFqZGRyM3g4dmFXL25xTHFDaUpEckZGWXJE?= =?utf-8?B?ejl2WGswenZKOUh3R2hvOWhHaVdud1hoQVBuNmp0S00xdXR2VW1KR1JBcFZG?= =?utf-8?B?RDVYR29hQUNRZ3MvZ3VISk00eUlMMXJtcHFxOTErT2J4UVArRDlSNFdGS3Rt?= =?utf-8?B?bVArRnVwdG1TZmVRV0lXSnlqTEJ4QmtWUjVXeEVWS0FkTFpWVXQxd2VldFU0?= =?utf-8?B?TkhJM0tzTzBOTFZjMmVmWWhsZll0bW5tUGpVRTlQbENXR2tTclFIRXlQdWtz?= =?utf-8?B?VFljUllDZ3ZzWWJiRDdndmNXdzE0RzlISzFxc0RqMDJBQWQ4eEpWT2VxWVNu?= =?utf-8?B?MGRQSkR4RXVub1pJSTUvYS9lU3JFanFadWVJV3NNSFdYVHY0TDJvWFVpQUoz?= =?utf-8?B?VHNpeDFWNkpvV2x3bnVQdGpVYVhpamltWitUUVVZekgyY013WW1iRFN6Y1Y1?= =?utf-8?B?NXpUWjByaE1mbVh5YUEwbFJPbVRacldFSnRHSWpKUnUydER0NGsrL1I1TEJW?= =?utf-8?B?NTJWcXljcHkvYzR0ZU90REtZUVBhK2d2K05oV2JGSnhUZ3R1NWJrT3l0T3BJ?= =?utf-8?B?enJVYzVXbHh3dUdBaUkrYUNkUXozKzRkUysvc1J5RmcwMVhMNzkvb3R6Zkxz?= =?utf-8?Q?bQXLMeeXLXzpvAUPGmmrzruEEW2BphmBB3cqaiQ?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Kzc3cnhUaDdHRUFTcHYyOHVqQXcyTHZITGJ4ZTg3VG9ncThudXJHVEhDZ0Vt?= =?utf-8?B?SGFoQ0o0eUtWQ3Q0eGNBVzMvZElNeWZZR3gwclFtc0J4MVdodlY4cEp0Vm5t?= =?utf-8?B?c21uTnU2RmoyWUtaMzdJaHFIY0lTQjIzQjBXaHFpRUxjOWt6ZUdTalBlZnh2?= =?utf-8?B?aDNMZHZZWmtrdisyUTJMT3hOTFg0YnZNWjg1Ukd0ckQzb3p2UEE2OHdMUjZs?= =?utf-8?B?UlFZNC9RZGI1NXJJdU1NVk5zTnlVb0JHTzBxNEhGczFqS3R0bFNqWTNNN0gz?= =?utf-8?B?QnlJODBzRGVMTFh1SGk1RmFTL1JTQkZEYXhvbFJKRVIwa0ZkcmU0bFU5ZTI3?= =?utf-8?B?OHpqd3J4Yk1kM3JRYlNyc0QvZk1OalBwbzhwTFcrcXJCb05JeTlWYjJEY3E1?= =?utf-8?B?bGNjcUw0TTFqb2dKZ1lHdlNRU2NYaDlKWUw5Wlptcjc1VHNWekpvUHBrdUV3?= =?utf-8?B?M3JxM3I0UEh3VThOblJTTWF3dzRXQ28zelVGVWdLNmNTaERiUlRNMlNWWU4x?= =?utf-8?B?UG16cE9zT3FEWjJEam9rK2VMZldMKzF0TlJUS1Q2dEhGUlBIelUwa0R3SmVO?= =?utf-8?B?QUo2TDF1MWFoblhpRXA5S2dLUEJ5d3RwVW9wSElzTnI0TEtmbUdBSjJnY1dx?= =?utf-8?B?bGtDSmdjMkYyMVpFK0JybEdKWk5PMmZJYXdhaTNyVGJYRlBaUElsR3pVdHhP?= =?utf-8?B?Z1hJdjlwdUU0OGtHeXpER0FVelN2OVY2ZDJ4cWVRSDFIWGJLOFVIaG1wY1Vp?= =?utf-8?B?elFJR3dSaVo0Y0Z1OXU5QjdqZ1dRS0RNa2lFdy9nNzN5aEF4ZUgvNFU3SVVK?= =?utf-8?B?ZTNoT3RmUDJyT25lWkdQOVFLdXpud3ZxdTRCUkhac2loQmFycTcvbkxnT2ly?= =?utf-8?B?cnNObUQ2RHBFdFlubmxjK1Z0dnRTai9CSDhHQ05NQWYwVktJZGhwOUhQdFdz?= =?utf-8?B?NGZKckQ0YlgxWlZhZnNZR1ZqcFNjK3VCRE1aUmFXZ2tPdEx4d093SFVlUExI?= =?utf-8?B?ZG90WVpEdlkrakRrclIyZytWRU1mUloxaGRndlU3RGlmRndYaEZ5MGo4dllC?= =?utf-8?B?MkI1d1hWOUNRS0pXbkMybDFGQ2pPdlVZaDhpYmE4ZDdkbUVDL0tNM2lqdkZq?= =?utf-8?B?L0pNNlE4QXdWTGN3RnJkSStnOVdoWFplbTdYU3hVTXBlSWNtMU16RUZibDg2?= =?utf-8?B?VFZ2SjBMRXZXRFZwQTY2UkNFc1JGNE14b2pZMlROVTE3MVR0U25XNmlVS2Vi?= =?utf-8?B?amo1ejFZdkl0K0o5UmNoSVNqcEpqWVM1YTA0NnVGNEVEWVYyYnNNQWlaNDMw?= =?utf-8?B?ck5mZi82d2orVDVXM1ExOEYzRGFpN2U2NVhEa2ZwWTJqRForUjZ1djc0MjNY?= =?utf-8?B?L0tRN0d2QVJWOVhYTk9oUktOVlVERlZGUFJaWFZ4SWN5UHlGR0JxWm0vWEly?= =?utf-8?B?bjRFenMxUW5OODJwYTk4RFc1TkFRUW9UL3JITDc5Z3JoWVJVd1duZ3hUSTA0?= =?utf-8?B?b2Nub0JBcmZwRE5mRFZMSWI2amcwaS9QWXVDZGdJbExpV053Y3dMdTFwcTQw?= =?utf-8?B?dW5ad25DZ3crM3RGaEh3VnBENmF3QTN0NkNXZVRFak5TQ01pZCthL21LQXdE?= =?utf-8?B?SFBIZHZrV0tjNDF3TmZKeTRrMWJ3Tks2TXZrck12RFBvV0JhTDVmMlhVUlRV?= =?utf-8?B?WTZ2UHNIeGxNaml0VzVjVjhBYlUzdlBCU21BMGZsNTdrY2VPY1B5THM5Qm8x?= =?utf-8?B?UWtwbzBRUmNFV05tZUtFWmxsSTZoSFBOMzNHVk5mNFdoWm9mbHZYZVZMY0kw?= =?utf-8?B?eDZpTVdqVjVrNTE1cnZ3eGRNR3hGem02UDdNVXIrVXRIeFMwdHV5RDJBKzh5?= =?utf-8?B?WlBadEhjTCtQcC9ydlM0K2NiMG14dWZqZEQ1bFFEVExwbW5HVXRHN3BIT3Ru?= =?utf-8?B?TEZJdjJYSnY1TnhFMWRrcm5JdVhKeTk2N2YwcjgwWlZuV0wvcy96RlNIQzkx?= =?utf-8?B?cnl6aE85T0Z3K0xlNjJCS29SbTNvajBVTGxhVHA1OXhQV1BxVDJiRitIbUlu?= =?utf-8?B?bDlCMWx1RmdvZDV1T0Y0aEc1bE1jZzF4NjFKNFZOOTNOVFJMV0pCNmdwOFlY?= =?utf-8?B?azZpaGVxMnp6bmlvWWFRYis5THcxbDJya2hwSEtkUWlYWHoxNmMzQ0czN1BP?= =?utf-8?Q?4zkeV2QjhQmhMMyYMmyirgc=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2bc7188f-6444-44e9-964e-08dc85b18a92 X-MS-Exchange-CrossTenant-AuthSource: LV3PR01MB8464.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2024 22:47:56.1744 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZDwdjYsFzzvSIe3UzdKShwgEkVv+zBvKUVL6+gG0LJjrI8eZEH0j0kU0DXjZVLdF3RMFKv/MawpCcQ987MDihfIIT18NcwuVC5P//3QXu0YlQD4yscFVxiWXgcH0vYXw X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR01MB6473 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 05 Jun 2024 15:48:00 -0700 Resent-From: rebecca@os.amperecomputing.com Reply-To: devel@edk2.groups.io,rebecca@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: IqHliRiANSPVdmM8gHshxhUgx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=3xI36RBR; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On 6/5/2024 4:21 PM, Michael D Kinney via groups.io wrote: > * Some PRs have been merged using the "Rebase and Merge" button in the > PR after all required reviews completed and all CI checks pass. Instea= d, > the "push" label should continue to be used. There does not appear to = be > any unexpected side effects from the "Rebase and Merge" button, but th= at > option is not available if the PR needs to be rebased. This is what > Mergify handles through a merge queue, so the easiest way to merge rig= ht > now is the "push" label. > > If the most recent commit was not performed by an EDK II Maintainers, = then > Mergify attempt to rebase may fail. > > Mitigation #1: EDK II Maintainer perform a rebase > Mitigation #2: Update Mergify to use a bot account with write permis= sion > to perform rebase operations. > > There was feedback earlier in the year that the git commit history doe= s > not indicate which maintainer was the committer. Instead it always sh= ows > Mergify. > > The use of GitHub Merge Queues will be evaluated to see if it can be u= sed > instead of Mergify and remove the need for the "push" label and allow = the > "Rebase and Merge" button to be used and avoid the Mergify permission = issues. So it sounds like using the "Merge" button is fine as long as the user=20 understands they may need to rebase, wait for CI to finish and then merge? Also, is there a timeline on enabling PRs for the other repos? I'd=20 really like to switch to them for edk2-platforms, even if it means=20 having to update settings in multiple repos as we find issues with the=20 process. --=20 Rebecca Cran -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119489): https://edk2.groups.io/g/devel/message/119489 Mute This Topic: https://groups.io/mt/106355103/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-