From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 94D4C740045 for ; Tue, 7 May 2024 10:48:36 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=5BHAklna/PqnZbakewGSuGOvTALZMW+1XbrDICrt81A=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition:Content-Transfer-Encoding; s=20240206; t=1715078915; v=1; b=UPmWVIGivYjO+r+4cQx+MdKslNWAAHLtRdBn1IoQiKkAwGUyeTMznAPhkrYSyclBCuFVKDRn 2X8rjje1Fhgusit215mjldcQMD/v5sk5KubT+qV/aCwBWiDkreZBJb7/nyW4wByymfeXuWapQP2 3VMxIUQmc/XK8YErRBmBqdlCFNkG8kjOFb5x1JVF7tv63rlDjMPOuj1RAmqcRBlXgSIfxKnJkn2 hp4rorvsMztByqg1sGwzguc7Kx0bi9O4KUuCv8AQuh3n4k9iZ7Vz1N5T7CcWjG80p/X+Cc9Y0OO 1lz9cQgr2B9TGwN2HJLYeYJT0QZd+UE+GQsXnWTY29hXQ== X-Received: by 127.0.0.2 with SMTP id 89fyYY7687511xaOu1sEwSYj; Tue, 07 May 2024 03:48:35 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.8651.1715078914231892245 for ; Tue, 07 May 2024 03:48:34 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-301-Uvv52xokOPGY5z1Cd8zurw-1; Tue, 07 May 2024 06:48:29 -0400 X-MC-Unique: Uvv52xokOPGY5z1Cd8zurw-1 X-Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6C10B857A81; Tue, 7 May 2024 10:48:29 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.234]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2DD65200AF76; Tue, 7 May 2024 10:48:29 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id E75E01800D4F; Tue, 7 May 2024 12:48:27 +0200 (CEST) Date: Tue, 7 May 2024 12:48:27 +0200 From: "Gerd Hoffmann" To: Doug Flick Cc: "devel@edk2.groups.io" , "ardb+tianocore@kernel.org" , "quic_llindhol@quicinc.com" , "sami.mujawar@arm.com" Subject: Re: [edk2-devel] Assistance Needed: ArmVirtPkg Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 07 May 2024 03:48:34 -0700 Resent-From: kraxel@redhat.com Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: JcUfcJvMIxx2r8crc5AVRr0ax7686176AA= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=UPmWVIGi; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, May 06, 2024 at 10:22:07PM GMT, Doug Flick wrote: > All, > > In order to patch Tianocore Bugzilla issues and CVEs: > 4541 – Bug 08 - edk2/NetworkPkg: Predictable TCP ISNs (tianocore.org) > and > 4542 – Bug 09 - edk2/NetworkPkg: Use of a Weak PseudoRandom Number Generator (tianocore.org) > > I've added as a dependency Hash2CryptoDxe and RngDxe lib to NetworkPkg. I've been able to add the relevant libraries to the DSCs of OvmfPkg and EmulatorPkg however I'm seeing odd behavior with ArmVirtPkg. > > Would someone more knowledgeable with ArmVirtPkg take a look this PR. Both OVMF and ArmVirt use the virtio random number device as source for random numbers. Driver: OvmfPkg/VirtioRngDxe Some Background: https://wiki.qemu.org/Features/VirtIORNG Typically the virtio rng device is present in virtual machine configurations. It might be missing though. I'd recommend: (1) Do *not* add RngDxe to OvmfPkg and ArmVirtPkg dsc files, instead continue to depend on VirtioRngDxe. (2) Keep the time-based not-really-random RNG generator as fallback in case EFI_RNG_PROTOCOL is not present (possibly requiring a PCD being set so the fallback option can be disabled at build time). HTH & take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118642): https://edk2.groups.io/g/devel/message/118642 Mute This Topic: https://groups.io/mt/105949609/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-