public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: <Jim.Dailey@dell.com>
To: <jaben.carsey@intel.com>
Cc: <afish@apple.com>, <ruiyu.ni@intel.com>,
	<edk2-devel@lists.01.org>, <felixp@mail.ru>,
	<michael.a.rothman@intel.com>
Subject: Re: How to Interpret ReadKeyStrokeEX Data
Date: Mon, 4 Jun 2018 16:28:34 +0000	[thread overview]
Message-ID: <bd44fd98e00046d793b537b605b8b59e@ausx13mps339.AMER.DELL.COM> (raw)
In-Reply-To: <F0D442D3-C3AD-4B53-8C43-AEB9534F0935@intel.com>

Yes!  Sorry if I was unclear.

-----Original Message-----
From: Carsey, Jaben [mailto:jaben.carsey@intel.com] 
Sent: Monday, June 4, 2018 11:22 AM
To: Dailey, Jim
Cc: afish@apple.com; Ni, Ruiyu; edk2-devel@lists.01.org; felixp@mail.ru; Rothman, Michael A
Subject: Re: [edk2] How to Interpret ReadKeyStrokeEX Data

Jim,

I think I see what you mean.  If scan code is 0, then don't test the shift state and just use the character raw?

Jaben
> On Jun 4, 2018, at 9:02 AM, "Jim.Dailey@dell.com" <Jim.Dailey@dell.com> wrote:
> 
> Please disregard the stupid "Confidential" line that our email tool
> adds but hides from me when I send text. :-(
> 
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Dailey, Jim
> Sent: Monday, June 4, 2018 11:00 AM
> To: afish@apple.com
> Cc: ruiyu.ni@intel.com; jaben.carsey@intel.com; edk2-devel@lists.01.org; felixp@mail.ru
> Subject: Re: [edk2] How to Interpret ReadKeyStrokeEX Data
> 
> Dell - Internal Use - Confidential   <=== THIS IS BOGUS !!
> 
>> From: afish@apple.com [mailto:afish@apple.com] 
>> 
>> The big picture difference is the original SimpleTextIn was the least common
>> denominator with a serial terminal. The Ex version added more info about
>> keyboards, so richer info on modifier keys.
> 
> I get that.  But I fail to see how that affects SimpleTextInEx behavior or
> what the UEFI spec has to say about it.
> 
> As I said earlier, the question I am raising is when SimpleTextInEx returns
> something like:
> 
>   Scan Code         = 0
>   Unicode Char      = 0x0023 ("#")
>   Shift Information = 0x80000001 (right shift pressed)
> 
> is it correct for the editor to reject this as an invalid key?
> 
> I say, no, it would be wrong to reject this data because the scan code
> is 0 and, therefore, the Unicode character is valid and should be used.
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2018-06-04 16:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-01 18:26 How to Interpret ReadKeyStrokeEX Data Jim.Dailey
2018-06-04  3:00 ` Ni, Ruiyu
2018-06-04 14:46   ` Jim.Dailey
2018-06-04 14:49     ` Andrew Fish
2018-06-04 16:00       ` Jim.Dailey
2018-06-04 16:02         ` Jim.Dailey
2018-06-04 16:21           ` Carsey, Jaben
2018-06-04 16:28             ` Jim.Dailey [this message]
2018-06-04 17:31 ` Rothman, Michael A
2018-06-06  3:37   ` Rothman, Michael A
2018-06-06 13:03     ` Jim.Dailey
2018-06-06 13:30       ` Andrew Fish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd44fd98e00046d793b537b605b8b59e@ausx13mps339.AMER.DELL.COM \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox