Re: [edk2-devel] Maybe it is time to update code style?

["Marcin Juszkiewicz" <marcin.juszkiewicz@linaro.org>]

W dniu 25.09.2023 o 20:03, Pedro Falcato pisze:
> On Mon, Sep 25, 2023 at 10:03 AM Marcin Juszkiewicz

>> And can someone take a look at config of code obfuscator used for linting?
>> It spits out amount of information showing that noone looked at updating it
>> to current version:
> 
> You're supposed to use the edk2 uncrustify fork that you get *somehow*
> (no, I don't remember how, I do remember it was a pain though).

If it is not latest upstream then maybe it should be merged into 
BaseTools and kept there?

> But seriously, speaking as someone with a completely different
> personal coding style, the coding style really isn't all that bad (at
> the very least, it's tolerable), it's just a bastardized NT-kernel
> style, and with uncrustify you can auto-format all your code.

When it works and do not complain about own config.

> What really pains me is CRLF vs LF, which breaks *every git tool*.
> Seriously, applying patches tends to be a pain, at least on Linux.

Argh. That's pain in the ass. I handle most of (outside of ML) sharing 
patches via own fork repo as it is easier than git format-patch+am combo.



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109049): https://edk2.groups.io/g/devel/message/109049
Mute This Topic: https://groups.io/mt/101570674/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-