From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id BCD0094160A for ; Mon, 25 Sep 2023 19:22:42 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=pHbHjQIsO+Q2Hb9kIaCyCC1mszciKfzwqKtXsGdpuNc=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:References:From:Organization:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1695669761; v=1; b=TtcycuTVT2adj7TPFX+xnHfyOojRD2cLmUfx7Xg8CQ5E/xXyfyS2UhYqmh8hMwTysIjmQguX dMKr1ZcI1MsSqB9CtEu6n3nVCW2un79fQcQmjUcjY0QJTS26BRoWzlLgbF7SMnMD1uff9se1kTS aarIv2zkAf2/DdXcY+BSxblE= X-Received: by 127.0.0.2 with SMTP id n66lYY7687511xeiNdWS7DZJ; Mon, 25 Sep 2023 12:22:41 -0700 X-Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by mx.groups.io with SMTP id smtpd.web11.967.1695669760251693684 for ; Mon, 25 Sep 2023 12:22:40 -0700 X-Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2bff7d81b5eso121855321fa.0 for ; Mon, 25 Sep 2023 12:22:39 -0700 (PDT) X-Gm-Message-State: ApJBNDjeITaaF1la3ftlZL6tx7686176AA= X-Google-Smtp-Source: AGHT+IEKtvHipCr+YzqbaldSlbuEjQQH2WCFdY9W4dgvFUSjgIoxud4CJnU36YThMHnPU/AlgqDZ9w== X-Received: by 2002:a05:6512:3e29:b0:503:1783:d5a9 with SMTP id i41-20020a0565123e2900b005031783d5a9mr7633398lfv.3.1695669758092; Mon, 25 Sep 2023 12:22:38 -0700 (PDT) X-Received: from [192.168.200.206] (83.11.3.58.ipv4.supernova.orange.pl. [83.11.3.58]) by smtp.gmail.com with ESMTPSA id q27-20020a056402249b00b00533f111b61dsm2358019eda.68.2023.09.25.12.22.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Sep 2023 12:22:37 -0700 (PDT) Message-ID: Date: Mon, 25 Sep 2023 21:22:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] Maybe it is time to update code style? To: Pedro Falcato , devel@edk2.groups.io References: From: "Marcin Juszkiewicz" Organization: Linaro In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: pl-PL, en-GB, en-HK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=TtcycuTV; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linaro.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io W dniu 25.09.2023 o 20:03, Pedro Falcato pisze: > On Mon, Sep 25, 2023 at 10:03 AM Marcin Juszkiewicz >> And can someone take a look at config of code obfuscator used for linting? >> It spits out amount of information showing that noone looked at updating it >> to current version: > > You're supposed to use the edk2 uncrustify fork that you get *somehow* > (no, I don't remember how, I do remember it was a pain though). If it is not latest upstream then maybe it should be merged into BaseTools and kept there? > But seriously, speaking as someone with a completely different > personal coding style, the coding style really isn't all that bad (at > the very least, it's tolerable), it's just a bastardized NT-kernel > style, and with uncrustify you can auto-format all your code. When it works and do not complain about own config. > What really pains me is CRLF vs LF, which breaks *every git tool*. > Seriously, applying patches tends to be a pain, at least on Linux. Argh. That's pain in the ass. I handle most of (outside of ML) sharing patches via own fork repo as it is easier than git format-patch+am combo. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109049): https://edk2.groups.io/g/devel/message/109049 Mute This Topic: https://groups.io/mt/101570674/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-