From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.49]) by mx.groups.io with SMTP id smtpd.web09.6628.1639750549271513770 for ; Fri, 17 Dec 2021 06:15:49 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=ASD8E4xG; spf=pass (domain: arm.com, ip: 40.107.8.49, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v+8JZFd4y25GOZJrnpQDT6moi0E7I4EnGxqjjkSZEEQ=; b=ASD8E4xGIPBa/7B/6aur7DBD4z6a9Kbr14N1Xc5GU1hBYPlK1ym0b0O4dBn6xDF+AZ3rrFa9yQSCrTZ93+amd2sexVOWB9oi3GV2pvH2tYpzwnCAHDsTo1zW7bpSgpM2ctb8dsYrv7+QT2ZI7LAXDCSXCXrmFVjGSUR86J0CGvs= Received: from AM6P194CA0021.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::34) by DB6PR0801MB1944.eurprd08.prod.outlook.com (2603:10a6:4:73::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Fri, 17 Dec 2021 14:15:45 +0000 Received: from VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:90:cafe::d) by AM6P194CA0021.outlook.office365.com (2603:10a6:209:90::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend Transport; Fri, 17 Dec 2021 14:15:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT016.mail.protection.outlook.com (10.152.18.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend Transport; Fri, 17 Dec 2021 14:15:44 +0000 Received: ("Tessian outbound 9a8c656e7c94:v110"); Fri, 17 Dec 2021 14:15:44 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: ce44544c775308fc X-CR-MTA-TID: 64aa7808 Received: from 10313fb90162.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F595492F-D2DF-4DD8-BA88-38564D455A75.1; Fri, 17 Dec 2021 14:15:38 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 10313fb90162.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 17 Dec 2021 14:15:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GVkm8yLRmpogzTFS8sivzBOLM4W3V+SDwc43Zaau0OSLTGYV8nWieVllab3GXRAMzsmkDwsVkn2nkt0JNcqxG/1R7XCg9L26ffordJH0GIhagkzD+4Wr1GUTnQWCxMJnO8x2zby/3z0YqvFbtGNpjW31yvmPjODA0DPy07Nem4+/pJ1RsrnR4Y8/b5DszEF51prVsT83xByNbbJnujvU2ByCcX5Hx+XLInaNwMi8AT4ucwAjgMm7JjnXkI47dBshpBnf7J/E1kOQwVzCNLVy1cmpng7pn7QWWJmzBZFnP9Hgkv1a+fh3oguC7AGMR5u80wL5gs4J34uj8CsQljA+Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v+8JZFd4y25GOZJrnpQDT6moi0E7I4EnGxqjjkSZEEQ=; b=XxBTh2mOH6uFe9SIc0EZq3hzgn/Pzl2awQQvscToa0ytlIj14JD/twK/uwNPP1AjBg6/SAplUQLXsUmNX5MwpNI64nP0GHFDIZz+iswr6z5hRJDi+eOz8CSpJqqvwXj19GpAFcck/y+PY74bWCtN3UiN77iTniWgCbUl5oSyCnfluxIbQm/+Ig0fTabstJn14ljg63vOh9WJo4oBAFE0XCqbKv7TwFs3chz5K0/pVZe1+Od3u/z5vpOU1EdcHm2b7nbvNrbXDyJNd+MleVn4O4auoHF4YBkK597XcUcTD86dlUYFF0+Pv0A2ha9V6QqGViqhCHW7PttgjBHzX2n7dA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v+8JZFd4y25GOZJrnpQDT6moi0E7I4EnGxqjjkSZEEQ=; b=ASD8E4xGIPBa/7B/6aur7DBD4z6a9Kbr14N1Xc5GU1hBYPlK1ym0b0O4dBn6xDF+AZ3rrFa9yQSCrTZ93+amd2sexVOWB9oi3GV2pvH2tYpzwnCAHDsTo1zW7bpSgpM2ctb8dsYrv7+QT2ZI7LAXDCSXCXrmFVjGSUR86J0CGvs= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM5PR0801MB1650.eurprd08.prod.outlook.com (2603:10a6:203:2f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Fri, 17 Dec 2021 14:15:36 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac%6]) with mapi id 15.20.4755.021; Fri, 17 Dec 2021 14:15:36 +0000 Subject: Re: [PATCH edk2-platforms v1 08/10] Platform/ARM: Fix Ecc error 3003 To: Pierre.Gondois@arm.com, devel@edk2.groups.io, nd References: <20211124162330.236813-1-Pierre.Gondois@arm.com> <20211124162330.236813-9-Pierre.Gondois@arm.com> From: "Sami Mujawar" Message-ID: Date: Fri, 17 Dec 2021 14:15:41 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20211124162330.236813-9-Pierre.Gondois@arm.com> X-ClientProxiedBy: LO2P123CA0088.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::21) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.50) by LO2P123CA0088.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::21) with Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport; Fri, 17 Dec 2021 14:15:34 +0000 X-MS-Office365-Filtering-Correlation-Id: 6d1ca1a2-0d53-4c8e-232d-08d9c167b71d X-MS-TrafficTypeDiagnostic: AM5PR0801MB1650:EE_|VE1EUR03FT016:EE_|DB6PR0801MB1944:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8273;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: D5+aKr3MzICa/GaVneYSzd+QgCI1af1ZdQ8tHugozvTQtmEXOZx4/d9+FWANSn/PFY7Xb4eP2UEbkpgy0tHD+ZtmbYUuR8VdRXDa4PG9T0EA37C6ak4MRsB9rRlfb3sHrAZ48HA9CsnIRgdn+ZEa3m/GUquNYbtXG/3HM3LKxmbnc7OgrHp1JsvzI58XCyGYa6pvNbKIU9ThgSQ/6zULuB0j5r5G9MnNJZVHDoFma2x+9jPnJIRlRUkTQLIp0Ams9BxGJZsO4Vd9QFBMp/mv+g9gSizEM2T6zLRoevqCXXYnnmsXKqnlj4KZZq2KrwjRsfj5WeBU67DY9+Iv2PtVvIcEm7lOJdF1zvU1fP8kXOCTWIpUNqL50V1hnZkpoJ8tACR50vULFyAaXo1yMkayh0Aiu3Y0+Xc/dkRP4qreDm8X2CXlzXaJ4VxMsxp07r/uCVSOG/7O0SLfhlAqGIYIAGsqPReJSlqOonpNwfX9EItCoXh62F9HnaAngxaMFU1y8f8S5IctBm1scld2uY+GWkpNyIkmuRYB38Mn8vq7llRK8+pWYlLqAvph7HMND/o5Me0VF6F5EVR1/9jqoBaOM8q5fEbJXsR9a2bELoYKbaGR9NbZPE7KUUuFliZPduODhsNGzfLuE9t9eDc7dylMY5LYnT7Ml8yzroninvAVrwtTShTR5bKG19+vPZNx1/vbIYRjkOiuVxiIVL/ks9GOc75I+9D32TFj/GnTB9jw/IKm33bFwpJt1NCLNrQGaOZa2qF+Kah5twAZaFGAqEys/g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6636002)(83380400001)(36756003)(38100700002)(37006003)(8936002)(16576012)(508600001)(26005)(316002)(31696002)(86362001)(31686004)(19627235002)(8676002)(38350700002)(53546011)(2616005)(186003)(956004)(52116002)(66946007)(44832011)(66556008)(6486002)(6666004)(66476007)(6862004)(5660300002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1650 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a992bae5-d6a8-443e-fb3f-08d9c167b152 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vg6qMAc6O59lqnGcQFFhunE2nTLCSD+Ag3cJmdaA80rSONjeM3zoICJcDDzcbTAhbjTaZoMPqOh7XVqZ1HMHgjpWYmqTeMBK82JDxfba+GFpYwCRWsWfqcFANtima7MKc0/KQx5b2YVAPBDD18nKqUdGWgXgrJMqZdC/wIEYNDBxyNOJL9XOgCEZE+OPB02FUkI6VNzj6w7ijGCNOvJe1INuZ8A8U03qag2qAhViousbosInfhTZBxxIuwGXtLFbL/0Kq5aPpGyxo5x6/QHkPQ+QUZf/F5mNyNLw7bvW1ExLgbdd8Ua//kbb0viroMum+xL98TY62hAzVbkPmjLq2bEQ4aq5ARBdta7bB0TlD/HKweO3FwpHHLZWXKI9bxKIu80Gc7I5lu/21hqHZm3W0nmI+2tolFPW+D+mfHBl/UGsGJNvtgFK4V/fXNqxgakSadkutHdNnbqkZeToYqUdkyQRWvszDsf5FKtyLE20ZUmNvaerjMz/YY+L0DRJWZ/Azb+BhA1AL1GD/fyW4cPkkq4t3W7aZuXLgesDhiDtcuX8+2XC+VRR8kvhjHGInKLGxv6Rg/odZ1i9aln8cypziaakCnEFvdVypiOUgY0rJZYC6xBp65BlhCyIXYj9ufAHx0jQLqvy+xKTDt5UGXomovExHXX+6sD3nW4nT+yvyVxOCa2sqGdOl2Lv66e0sVBJ0sxQcp9QUSfynEMxooa4JzXuzlhySbZRp+OtxeCxaLYh+77s2MBwosX8JNnMd2gHEh50zcdBqjdl15prjT0/4O0dYj7nos7tAYNwkFiCp0Y= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(40470700001)(5660300002)(26005)(36756003)(6486002)(83380400001)(356005)(186003)(81166007)(336012)(6666004)(6862004)(8936002)(16576012)(8676002)(31686004)(316002)(2906002)(70206006)(70586007)(37006003)(36860700001)(2616005)(6636002)(31696002)(956004)(508600001)(82310400004)(47076005)(44832011)(86362001)(19627235002)(40460700001)(53546011)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2021 14:15:44.6470 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6d1ca1a2-0d53-4c8e-232d-08d9c167b71d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1944 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-GB Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 24/11/2021 04:23 PM, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > This patch fixes the following Ecc reported error: > A comparison of any pointer to zero must be done > via the NULL type > > Signed-off-by: Pierre Gondois > --- > Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c | 4 ++-- > .../ARM/JunoPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c b/= Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c > index ad7cc1cd75a1..6f2ce401b3cc 100644 > --- a/Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c > +++ b/Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c > @@ -91,7 +91,7 @@ SataSiI3132Constructor ( > SATA_SI3132_INSTANCE *Instance; > EFI_ATA_PASS_THRU_MODE *AtaPassThruMode; > > - if (!SataSiI3132Instance) { > + if (SataSiI3132Instance =3D=3D NULL) { > return EFI_INVALID_PARAMETER; > } > > @@ -223,7 +223,7 @@ SataSiI3132Initialization ( > UINTN Index; > EFI_PCI_IO_PROTOCOL* PciIo; > > - if (!SataSiI3132Instance) { > + if (SataSiI3132Instance =3D=3D NULL) { > return EFI_INVALID_PARAMETER; > } > > diff --git a/Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassTh= ru.c b/Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c > index f15b59788310..0ec53782835b 100644 > --- a/Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c > +++ b/Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c > @@ -260,7 +260,7 @@ SiI3132AtaPassThruCommand ( > // Clear Command Complete > SATA_PORT_WRITE32 (SataPort->RegBase + SII3132_PORT_INTSTATUS_REG, = SII3132_PORT_INT_CMDCOMPL << 16); > > - if (PciAllocMapping) { > + if (PciAllocMapping !=3D NULL) { > Status =3D PciIo->Unmap (PciIo, PciAllocMapping); > ASSERT (!EFI_ERROR (Status)); > } > -- > 2.25.1 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.