* [PATCH 0/1] Platform/Comcast: EDK2 dependencies resolved for RDK Qemu
@ 2018-06-01 11:03 Moorthy Baskaravenkatraman
2018-06-01 11:03 ` [PATCH 1/1] Platform/Comcast: EDK2 dependencies resolved for RDK Qemu platform * DevicePathLib library class added in DxeMain * NvVarStoreFormattedLib added in VariableRuntimeDxe * DevicePathLib and PcdLib library classes added in DevicePathExe Moorthy Baskaravenkatraman
0 siblings, 1 reply; 7+ messages in thread
From: Moorthy Baskaravenkatraman @ 2018-06-01 11:03 UTC (permalink / raw)
To: moorthy.baskaravenkatraman-sambamoorthy, edk2-devel
Cc: kalyankumar.nagabhirava
EDK2 latest dependencies resolved for RDK Qemu platform
Moorthy Baskaravenkatraman (1):
Platform/Comcast: EDK2 dependencies resolved for RDK Qemu platform
* DevicePathLib library class added in DxeMain *
NvVarStoreFormattedLib added in VariableRuntimeDxe *
DevicePathLib and PcdLib library classes added in
DevicePathExe
Platform/Comcast/RDKQemu/RDKQemu.dsc | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
--
2.17.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/1] Platform/Comcast: EDK2 dependencies resolved for RDK Qemu platform * DevicePathLib library class added in DxeMain * NvVarStoreFormattedLib added in VariableRuntimeDxe * DevicePathLib and PcdLib library classes added in DevicePathExe
2018-06-01 11:03 [PATCH 0/1] Platform/Comcast: EDK2 dependencies resolved for RDK Qemu Moorthy Baskaravenkatraman
@ 2018-06-01 11:03 ` Moorthy Baskaravenkatraman
2018-06-01 12:04 ` Ard Biesheuvel
0 siblings, 1 reply; 7+ messages in thread
From: Moorthy Baskaravenkatraman @ 2018-06-01 11:03 UTC (permalink / raw)
To: moorthy.baskaravenkatraman-sambamoorthy, edk2-devel
Cc: kalyankumar.nagabhirava
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Moorthy Baskaravenkatraman <moorthy.baskaravenkatraman-sambamoorthy@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
Platform/Comcast/RDKQemu/RDKQemu.dsc | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/Platform/Comcast/RDKQemu/RDKQemu.dsc b/Platform/Comcast/RDKQemu/RDKQemu.dsc
index 45feeec8764b..1301c5555efe 100644
--- a/Platform/Comcast/RDKQemu/RDKQemu.dsc
+++ b/Platform/Comcast/RDKQemu/RDKQemu.dsc
@@ -251,6 +251,7 @@ [Components.common]
MdeModulePkg/Core/Dxe/DxeMain.inf {
<LibraryClasses>
NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf
+ DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
}
MdeModulePkg/Universal/PCD/Dxe/Pcd.inf {
<LibraryClasses>
@@ -265,6 +266,7 @@ [Components.common]
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf {
<LibraryClasses>
NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
+ NULL|EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf
# don't use unaligned CopyMem () on the UEFI varstore NOR flash region
BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
}
@@ -326,7 +328,11 @@ [Components.common]
#
# Bds
#
- MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
+ MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf {
+ <LibraryClasses>
+ DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
+ PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
+ }
MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.inf
--
2.17.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] Platform/Comcast: EDK2 dependencies resolved for RDK Qemu platform * DevicePathLib library class added in DxeMain * NvVarStoreFormattedLib added in VariableRuntimeDxe * DevicePathLib and PcdLib library classes added in DevicePathExe
2018-06-01 11:03 ` [PATCH 1/1] Platform/Comcast: EDK2 dependencies resolved for RDK Qemu platform * DevicePathLib library class added in DxeMain * NvVarStoreFormattedLib added in VariableRuntimeDxe * DevicePathLib and PcdLib library classes added in DevicePathExe Moorthy Baskaravenkatraman
@ 2018-06-01 12:04 ` Ard Biesheuvel
2018-06-01 12:14 ` Moorthy Baskaravenkatraman Sambamoorthy
0 siblings, 1 reply; 7+ messages in thread
From: Ard Biesheuvel @ 2018-06-01 12:04 UTC (permalink / raw)
To: Moorthy Baskaravenkatraman
Cc: edk2-devel@lists.01.org, Kalyan Kumar Nagabhirava
On 1 June 2018 at 13:03, Moorthy Baskaravenkatraman
<moorthy.baskaravenkatraman-sambamoorthy@linaro.org> wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Moorthy Baskaravenkatraman <moorthy.baskaravenkatraman-sambamoorthy@linaro.org>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Excuse me? I don't remember reviewing these changes.
> ---
> Platform/Comcast/RDKQemu/RDKQemu.dsc | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/Platform/Comcast/RDKQemu/RDKQemu.dsc b/Platform/Comcast/RDKQemu/RDKQemu.dsc
> index 45feeec8764b..1301c5555efe 100644
> --- a/Platform/Comcast/RDKQemu/RDKQemu.dsc
> +++ b/Platform/Comcast/RDKQemu/RDKQemu.dsc
> @@ -251,6 +251,7 @@ [Components.common]
> MdeModulePkg/Core/Dxe/DxeMain.inf {
> <LibraryClasses>
> NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf
> + DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> }
> MdeModulePkg/Universal/PCD/Dxe/Pcd.inf {
> <LibraryClasses>
> @@ -265,6 +266,7 @@ [Components.common]
> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf {
> <LibraryClasses>
> NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
> + NULL|EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf
> # don't use unaligned CopyMem () on the UEFI varstore NOR flash region
> BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> }
> @@ -326,7 +328,11 @@ [Components.common]
> #
> # Bds
> #
> - MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> + MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf {
> + <LibraryClasses>
> + DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> + PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> + }
> MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
> MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
> MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.inf
> --
> 2.17.0
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] Platform/Comcast: EDK2 dependencies resolved for RDK Qemu platform * DevicePathLib library class added in DxeMain * NvVarStoreFormattedLib added in VariableRuntimeDxe * DevicePathLib and PcdLib library classes added in DevicePathExe
2018-06-01 12:04 ` Ard Biesheuvel
@ 2018-06-01 12:14 ` Moorthy Baskaravenkatraman Sambamoorthy
2018-06-01 12:15 ` Ard Biesheuvel
0 siblings, 1 reply; 7+ messages in thread
From: Moorthy Baskaravenkatraman Sambamoorthy @ 2018-06-01 12:14 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel@lists.01.org, Kalyan Kumar Nagabhirava
Hi Ard,
RDK package Secure boot and DRI application for QEMU platform were
up-streamed by Kalyan under edk2-platforms. Now, I'm continuing the same
for further maintenance.
Regards,
Moorthy
On 1 June 2018 at 17:34, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> On 1 June 2018 at 13:03, Moorthy Baskaravenkatraman
> <moorthy.baskaravenkatraman-sambamoorthy@linaro.org> wrote:
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Moorthy Baskaravenkatraman <moorthy.baskaravenkatraman-
> sambamoorthy@linaro.org>
> > Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Excuse me? I don't remember reviewing these changes.
>
> > ---
> > Platform/Comcast/RDKQemu/RDKQemu.dsc | 8 +++++++-
> > 1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/Platform/Comcast/RDKQemu/RDKQemu.dsc
> b/Platform/Comcast/RDKQemu/RDKQemu.dsc
> > index 45feeec8764b..1301c5555efe 100644
> > --- a/Platform/Comcast/RDKQemu/RDKQemu.dsc
> > +++ b/Platform/Comcast/RDKQemu/RDKQemu.dsc
> > @@ -251,6 +251,7 @@ [Components.common]
> > MdeModulePkg/Core/Dxe/DxeMain.inf {
> > <LibraryClasses>
> > NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/
> DxeCrc32GuidedSectionExtractLib.inf
> > + DevicePathLib|MdePkg/Library/UefiDevicePathLib/
> UefiDevicePathLib.inf
> > }
> > MdeModulePkg/Universal/PCD/Dxe/Pcd.inf {
> > <LibraryClasses>
> > @@ -265,6 +266,7 @@ [Components.common]
> > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf {
> > <LibraryClasses>
> > NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
> > + NULL|EmbeddedPkg/Library/NvVarStoreFormattedLib/
> NvVarStoreFormattedLib.inf
> > # don't use unaligned CopyMem () on the UEFI varstore NOR flash
> region
> > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> > }
> > @@ -326,7 +328,11 @@ [Components.common]
> > #
> > # Bds
> > #
> > - MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> > + MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf {
> > + <LibraryClasses>
> > + DevicePathLib|MdePkg/Library/UefiDevicePathLib/
> UefiDevicePathLib.inf
> > + PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> > + }
> > MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
> > MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
> > MdeModulePkg/Universal/DriverHealthManagerDxe/
> DriverHealthManagerDxe.inf
> > --
> > 2.17.0
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
>
--
Regards,
Moorthy
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] Platform/Comcast: EDK2 dependencies resolved for RDK Qemu platform * DevicePathLib library class added in DxeMain * NvVarStoreFormattedLib added in VariableRuntimeDxe * DevicePathLib and PcdLib library classes added in DevicePathExe
2018-06-01 12:14 ` Moorthy Baskaravenkatraman Sambamoorthy
@ 2018-06-01 12:15 ` Ard Biesheuvel
2018-06-01 12:34 ` Moorthy Baskaravenkatraman Sambamoorthy
0 siblings, 1 reply; 7+ messages in thread
From: Ard Biesheuvel @ 2018-06-01 12:15 UTC (permalink / raw)
To: Moorthy Baskaravenkatraman Sambamoorthy
Cc: edk2-devel@lists.01.org, Kalyan Kumar Nagabhirava
On 1 June 2018 at 14:14, Moorthy Baskaravenkatraman Sambamoorthy
<moorthy.baskaravenkatraman-sambamoorthy@linaro.org> wrote:
> Hi Ard,
>
> RDK package Secure boot and DRI application for QEMU platform were
> up-streamed by Kalyan under edk2-platforms. Now, I'm continuing the same for
> further maintenance.
>
That is fine. But that does *not* allow you to add my reviewed-by
under a patch that I have never seen in my life.
> On 1 June 2018 at 17:34, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>>
>> On 1 June 2018 at 13:03, Moorthy Baskaravenkatraman
>> <moorthy.baskaravenkatraman-sambamoorthy@linaro.org> wrote:
>> > Contributed-under: TianoCore Contribution Agreement 1.1
>> > Signed-off-by: Moorthy Baskaravenkatraman
>> > <moorthy.baskaravenkatraman-sambamoorthy@linaro.org>
>> > Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>
>> Excuse me? I don't remember reviewing these changes.
>>
>> > ---
>> > Platform/Comcast/RDKQemu/RDKQemu.dsc | 8 +++++++-
>> > 1 file changed, 7 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/Platform/Comcast/RDKQemu/RDKQemu.dsc
>> > b/Platform/Comcast/RDKQemu/RDKQemu.dsc
>> > index 45feeec8764b..1301c5555efe 100644
>> > --- a/Platform/Comcast/RDKQemu/RDKQemu.dsc
>> > +++ b/Platform/Comcast/RDKQemu/RDKQemu.dsc
>> > @@ -251,6 +251,7 @@ [Components.common]
>> > MdeModulePkg/Core/Dxe/DxeMain.inf {
>> > <LibraryClasses>
>> >
>> > NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf
>> > +
>> > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
>> > }
>> > MdeModulePkg/Universal/PCD/Dxe/Pcd.inf {
>> > <LibraryClasses>
>> > @@ -265,6 +266,7 @@ [Components.common]
>> > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf {
>> > <LibraryClasses>
>> > NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
>> > +
>> > NULL|EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf
>> > # don't use unaligned CopyMem () on the UEFI varstore NOR flash
>> > region
>> > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
>> > }
>> > @@ -326,7 +328,11 @@ [Components.common]
>> > #
>> > # Bds
>> > #
>> > - MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
>> > + MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf {
>> > + <LibraryClasses>
>> > +
>> > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
>> > + PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>> > + }
>> > MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
>> > MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
>> >
>> > MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.inf
>> > --
>> > 2.17.0
>> >
>> > _______________________________________________
>> > edk2-devel mailing list
>> > edk2-devel@lists.01.org
>> > https://lists.01.org/mailman/listinfo/edk2-devel
>
>
>
>
> --
> Regards,
> Moorthy
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] Platform/Comcast: EDK2 dependencies resolved for RDK Qemu platform * DevicePathLib library class added in DxeMain * NvVarStoreFormattedLib added in VariableRuntimeDxe * DevicePathLib and PcdLib library classes added in DevicePathExe
2018-06-01 12:15 ` Ard Biesheuvel
@ 2018-06-01 12:34 ` Moorthy Baskaravenkatraman Sambamoorthy
2018-06-01 12:35 ` Ard Biesheuvel
0 siblings, 1 reply; 7+ messages in thread
From: Moorthy Baskaravenkatraman Sambamoorthy @ 2018-06-01 12:34 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel@lists.01.org, Kalyan Kumar Nagabhirava
Sorry for that. I have mistakenly followed the same template used for the
last reviewed RDKPkg upstream.
Let me remove that field and send for review again.
Regards,
Moorthy
On 1 June 2018 at 17:45, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> On 1 June 2018 at 14:14, Moorthy Baskaravenkatraman Sambamoorthy
> <moorthy.baskaravenkatraman-sambamoorthy@linaro.org> wrote:
> > Hi Ard,
> >
> > RDK package Secure boot and DRI application for QEMU platform were
> > up-streamed by Kalyan under edk2-platforms. Now, I'm continuing the same
> for
> > further maintenance.
> >
>
> That is fine. But that does *not* allow you to add my reviewed-by
> under a patch that I have never seen in my life.
>
> > On 1 June 2018 at 17:34, Ard Biesheuvel <ard.biesheuvel@linaro.org>
> wrote:
> >>
> >> On 1 June 2018 at 13:03, Moorthy Baskaravenkatraman
> >> <moorthy.baskaravenkatraman-sambamoorthy@linaro.org> wrote:
> >> > Contributed-under: TianoCore Contribution Agreement 1.1
> >> > Signed-off-by: Moorthy Baskaravenkatraman
> >> > <moorthy.baskaravenkatraman-sambamoorthy@linaro.org>
> >> > Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >>
> >> Excuse me? I don't remember reviewing these changes.
> >>
> >> > ---
> >> > Platform/Comcast/RDKQemu/RDKQemu.dsc | 8 +++++++-
> >> > 1 file changed, 7 insertions(+), 1 deletion(-)
> >> >
> >> > diff --git a/Platform/Comcast/RDKQemu/RDKQemu.dsc
> >> > b/Platform/Comcast/RDKQemu/RDKQemu.dsc
> >> > index 45feeec8764b..1301c5555efe 100644
> >> > --- a/Platform/Comcast/RDKQemu/RDKQemu.dsc
> >> > +++ b/Platform/Comcast/RDKQemu/RDKQemu.dsc
> >> > @@ -251,6 +251,7 @@ [Components.common]
> >> > MdeModulePkg/Core/Dxe/DxeMain.inf {
> >> > <LibraryClasses>
> >> >
> >> > NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/
> DxeCrc32GuidedSectionExtractLib.inf
> >> > +
> >> > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> >> > }
> >> > MdeModulePkg/Universal/PCD/Dxe/Pcd.inf {
> >> > <LibraryClasses>
> >> > @@ -265,6 +266,7 @@ [Components.common]
> >> > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf
> {
> >> > <LibraryClasses>
> >> > NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
> >> > +
> >> > NULL|EmbeddedPkg/Library/NvVarStoreFormattedLib/
> NvVarStoreFormattedLib.inf
> >> > # don't use unaligned CopyMem () on the UEFI varstore NOR flash
> >> > region
> >> > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> >> > }
> >> > @@ -326,7 +328,11 @@ [Components.common]
> >> > #
> >> > # Bds
> >> > #
> >> > - MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> >> > + MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf {
> >> > + <LibraryClasses>
> >> > +
> >> > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> >> > + PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> >> > + }
> >> > MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
> >> > MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
> >> >
> >> > MdeModulePkg/Universal/DriverHealthManagerDxe/
> DriverHealthManagerDxe.inf
> >> > --
> >> > 2.17.0
> >> >
> >> > _______________________________________________
> >> > edk2-devel mailing list
> >> > edk2-devel@lists.01.org
> >> > https://lists.01.org/mailman/listinfo/edk2-devel
> >
> >
> >
> >
> > --
> > Regards,
> > Moorthy
>
--
Regards,
Moorthy
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] Platform/Comcast: EDK2 dependencies resolved for RDK Qemu platform * DevicePathLib library class added in DxeMain * NvVarStoreFormattedLib added in VariableRuntimeDxe * DevicePathLib and PcdLib library classes added in DevicePathExe
2018-06-01 12:34 ` Moorthy Baskaravenkatraman Sambamoorthy
@ 2018-06-01 12:35 ` Ard Biesheuvel
0 siblings, 0 replies; 7+ messages in thread
From: Ard Biesheuvel @ 2018-06-01 12:35 UTC (permalink / raw)
To: Moorthy Baskaravenkatraman Sambamoorthy
Cc: edk2-devel@lists.01.org, Kalyan Kumar Nagabhirava
On 1 June 2018 at 14:34, Moorthy Baskaravenkatraman Sambamoorthy
<moorthy.baskaravenkatraman-sambamoorthy@linaro.org> wrote:
> Sorry for that. I have mistakenly followed the same template used for the
> last reviewed RDKPkg upstream.
> Let me remove that field and send for review again.
>
Please read the instructions here
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers
before sending out any more patches for review.
Thanks,
Ard.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-06-01 12:36 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-01 11:03 [PATCH 0/1] Platform/Comcast: EDK2 dependencies resolved for RDK Qemu Moorthy Baskaravenkatraman
2018-06-01 11:03 ` [PATCH 1/1] Platform/Comcast: EDK2 dependencies resolved for RDK Qemu platform * DevicePathLib library class added in DxeMain * NvVarStoreFormattedLib added in VariableRuntimeDxe * DevicePathLib and PcdLib library classes added in DevicePathExe Moorthy Baskaravenkatraman
2018-06-01 12:04 ` Ard Biesheuvel
2018-06-01 12:14 ` Moorthy Baskaravenkatraman Sambamoorthy
2018-06-01 12:15 ` Ard Biesheuvel
2018-06-01 12:34 ` Moorthy Baskaravenkatraman Sambamoorthy
2018-06-01 12:35 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox