From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3E8637803D0 for ; Wed, 6 Mar 2024 21:10:30 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=jAfo6RAtGIngMMKjDoGjriRqPkVpHQs9acrh7PNrl4k=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:Reply-To:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1709759428; v=1; b=lqNGGUAnoDOb19Sy0GGgKJjVbwfajEKQLNwaWXglYI5RuVwKh0eCG/6blgGNhPIxn4vnp6AS FTNFSbcJlQx/q8sWNpSAqbxFh1G96sXV5w0hThHMmRUOeKA4lkjivr+EoYs5dpaIdjRroywingQ hdhHFoOXIiXT0UyPkrC1E2wNXIxL7V0uBF0Sx6jqu8VeZNxprGOorUNIrkwbx3OlYT/+yCd/hTX 6VX7Vqcv2c807dBS2Dq8HHpGcrpZKBvGCZcbaNlqQ06X4zYanVeErpTIpu1Z1MRAM2C4fXXSBKU 9cBcWnzG3ytS8h6VQRPSuLJcf7magDi5M8d2loqFyjkFA== X-Received: by 127.0.0.2 with SMTP id wUQ8YY7687511xWzSn9GuMD0; Wed, 06 Mar 2024 13:10:28 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.7295.1709759428311568099 for ; Wed, 06 Mar 2024 13:10:28 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-407-dW-q8xliOJKISK22veno2w-1; Wed, 06 Mar 2024 16:10:24 -0500 X-MC-Unique: dW-q8xliOJKISK22veno2w-1 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0CB95920704; Wed, 6 Mar 2024 21:10:24 +0000 (UTC) X-Received: from [10.39.192.14] (unknown [10.39.192.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7E684C017A2; Wed, 6 Mar 2024 21:10:23 +0000 (UTC) Message-ID: Date: Wed, 06 Mar 2024 13:10:28 -0800 MIME-Version: 1.0 Subject: Re: [edk2-devel] [edk2-platforms PATCH v2 2/4] SimicsOpenBoardPkg: auto-gen & fix SEC ProcessLibraryConstructorList() decl From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Nate DeSimone , Sai Chaganty Reply-To: devel@edk2.groups.io,lersek@redhat.com References: <20240305120126.70259-1-lersek@redhat.com> <20240305120126.70259-3-lersek@redhat.com> In-Reply-To: <20240305120126.70259-3-lersek@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: NluVt1brGpp7PcLKK4VCehdUx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=lqNGGUAn; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Can I please get a quick R-b for this patch -- it's urgent because of . Thank you, Laszlo On 3/5/24 13:01, Laszlo Ersek wrote: > declares a bogus > ProcessLibraryConstructorList() for SimicsOpenBoardPkg's SEC module. Rely > on AutoGen for (properly) declaring ProcessLibraryConstructorList(). > Update the call. >=20 > Build-tested with: >=20 > - appending the following directories to PACKAGES_PATH: >=20 > Drivers > Features/Intel > Features/Intel/Debugging > Features/Intel/Network > Features/Intel/OutOfBandManagement > Features/Intel/PowerManagement > Features/Intel/SystemInformation > Features/Intel/UserInterface > Platform/Intel > Silicon/Intel >=20 > - commenting out "SimicsIch10BinPkg/UndiBinary/UndiDxe.inf" in > "Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc" and > "Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf" >=20 > - running the command >=20 > build -a IA32 -a X64 -b DEBUG \ > -m Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf \ > -p Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc \ > -t GCC5 >=20 > Cc: Nate DeSimone > Cc: Sai Chaganty > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D990 > Signed-off-by: Laszlo Ersek > --- > Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf | 2 +- > Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c | 3 +-- > 2 files changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf b/Plat= form/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf > index af1c0f2b55d1..fcf34c0def4e 100644 > --- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf > +++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf > @@ -8,7 +8,7 @@ > ## > =20 > [Defines] > - INF_VERSION =3D 0x00010005 > + INF_VERSION =3D 1.30 > BASE_NAME =3D SecMain > FILE_GUID =3D e67f156f-54c5-47f3-a35d-07c045881e1= 4 > MODULE_TYPE =3D SEC > diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c b/Platfo= rm/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c > index 39e879e9223e..09d43c6bf63b 100644 > --- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c > +++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c > @@ -9,7 +9,6 @@ > =20 > #include > =20 > -#include > #include > #include > #include > @@ -738,7 +737,7 @@ SecCoreStartupWithStack ( > Table[Index] =3D 0; > } > =20 > - ProcessLibraryConstructorList (NULL, NULL); > + ProcessLibraryConstructorList (); > =20 > DEBUG ((EFI_D_INFO, > "SecCoreStartupWithStack(0x%x, 0x%x)\n", >=20 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116459): https://edk2.groups.io/g/devel/message/116459 Mute This Topic: https://groups.io/mt/104742758/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-