* [edk2-devel] [edk2-platforms PATCH v2 1/4] BeagleBoardPkg: auto-generate SEC ProcessLibraryConstructorList() decl
2024-03-05 12:01 [edk2-devel] [edk2-platforms PATCH v2 0/4] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
@ 2024-03-05 12:01 ` Laszlo Ersek
2024-03-05 13:01 ` Ard Biesheuvel
2024-03-05 12:01 ` [edk2-devel] [edk2-platforms PATCH v2 2/4] SimicsOpenBoardPkg: auto-gen & fix " Laszlo Ersek
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Laszlo Ersek @ 2024-03-05 12:01 UTC (permalink / raw)
To: edk2-devel-groups-io; +Cc: Ard Biesheuvel, Leif Lindholm
Rely on AutoGen for declaring ProcessLibraryConstructorList().
Build-tested with:
build -a ARM -b DEBUG \
-m Platform/BeagleBoard/BeagleBoardPkg/PrePi/PeiUniCore.inf \
-p Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc -t GCC5
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
Platform/BeagleBoard/BeagleBoardPkg/PrePi/PeiUniCore.inf | 2 +-
Platform/BeagleBoard/BeagleBoardPkg/PrePi/PrePi.h | 6 ------
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/Platform/BeagleBoard/BeagleBoardPkg/PrePi/PeiUniCore.inf b/Platform/BeagleBoard/BeagleBoardPkg/PrePi/PeiUniCore.inf
index 414091957cb2..03d8f4daab48 100644
--- a/Platform/BeagleBoard/BeagleBoardPkg/PrePi/PeiUniCore.inf
+++ b/Platform/BeagleBoard/BeagleBoardPkg/PrePi/PeiUniCore.inf
@@ -9,7 +9,7 @@
#**/
[Defines]
- INF_VERSION = 0x0001001A
+ INF_VERSION = 1.30
BASE_NAME = BeagleBoardPrePiUniCore
FILE_GUID = 8a5dc3de-fe31-4ad9-9c93-dd73626932e7
MODULE_TYPE = SEC
diff --git a/Platform/BeagleBoard/BeagleBoardPkg/PrePi/PrePi.h b/Platform/BeagleBoard/BeagleBoardPkg/PrePi/PrePi.h
index b64dd764a435..a2932f0f5116 100644
--- a/Platform/BeagleBoard/BeagleBoardPkg/PrePi/PrePi.h
+++ b/Platform/BeagleBoard/BeagleBoardPkg/PrePi/PrePi.h
@@ -81,10 +81,4 @@ ArchInitialize (
VOID
);
-VOID
-EFIAPI
-ProcessLibraryConstructorList (
- VOID
- );
-
#endif /* _PREPI_H_ */
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116379): https://edk2.groups.io/g/devel/message/116379
Mute This Topic: https://groups.io/mt/104742757/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [edk2-devel] [edk2-platforms PATCH v2 1/4] BeagleBoardPkg: auto-generate SEC ProcessLibraryConstructorList() decl
2024-03-05 12:01 ` [edk2-devel] [edk2-platforms PATCH v2 1/4] BeagleBoardPkg: auto-generate SEC ProcessLibraryConstructorList() decl Laszlo Ersek
@ 2024-03-05 13:01 ` Ard Biesheuvel
0 siblings, 0 replies; 11+ messages in thread
From: Ard Biesheuvel @ 2024-03-05 13:01 UTC (permalink / raw)
To: Laszlo Ersek; +Cc: edk2-devel-groups-io, Leif Lindholm
On Tue, 5 Mar 2024 at 13:01, Laszlo Ersek <lersek@redhat.com> wrote:
>
> Rely on AutoGen for declaring ProcessLibraryConstructorList().
>
> Build-tested with:
>
> build -a ARM -b DEBUG \
> -m Platform/BeagleBoard/BeagleBoardPkg/PrePi/PeiUniCore.inf \
> -p Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc -t GCC5
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> Platform/BeagleBoard/BeagleBoardPkg/PrePi/PeiUniCore.inf | 2 +-
> Platform/BeagleBoard/BeagleBoardPkg/PrePi/PrePi.h | 6 ------
> 2 files changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/Platform/BeagleBoard/BeagleBoardPkg/PrePi/PeiUniCore.inf b/Platform/BeagleBoard/BeagleBoardPkg/PrePi/PeiUniCore.inf
> index 414091957cb2..03d8f4daab48 100644
> --- a/Platform/BeagleBoard/BeagleBoardPkg/PrePi/PeiUniCore.inf
> +++ b/Platform/BeagleBoard/BeagleBoardPkg/PrePi/PeiUniCore.inf
> @@ -9,7 +9,7 @@
> #**/
>
> [Defines]
> - INF_VERSION = 0x0001001A
> + INF_VERSION = 1.30
> BASE_NAME = BeagleBoardPrePiUniCore
> FILE_GUID = 8a5dc3de-fe31-4ad9-9c93-dd73626932e7
> MODULE_TYPE = SEC
> diff --git a/Platform/BeagleBoard/BeagleBoardPkg/PrePi/PrePi.h b/Platform/BeagleBoard/BeagleBoardPkg/PrePi/PrePi.h
> index b64dd764a435..a2932f0f5116 100644
> --- a/Platform/BeagleBoard/BeagleBoardPkg/PrePi/PrePi.h
> +++ b/Platform/BeagleBoard/BeagleBoardPkg/PrePi/PrePi.h
> @@ -81,10 +81,4 @@ ArchInitialize (
> VOID
> );
>
> -VOID
> -EFIAPI
> -ProcessLibraryConstructorList (
> - VOID
> - );
> -
> #endif /* _PREPI_H_ */
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116387): https://edk2.groups.io/g/devel/message/116387
Mute This Topic: https://groups.io/mt/104742757/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 11+ messages in thread
* [edk2-devel] [edk2-platforms PATCH v2 2/4] SimicsOpenBoardPkg: auto-gen & fix SEC ProcessLibraryConstructorList() decl
2024-03-05 12:01 [edk2-devel] [edk2-platforms PATCH v2 0/4] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
2024-03-05 12:01 ` [edk2-devel] [edk2-platforms PATCH v2 1/4] BeagleBoardPkg: auto-generate SEC ProcessLibraryConstructorList() decl Laszlo Ersek
@ 2024-03-05 12:01 ` Laszlo Ersek
2024-03-06 21:10 ` Laszlo Ersek
2024-03-05 12:01 ` [edk2-devel] [edk2-platforms PATCH v2 3/4] LoongArchQemuPkg: " Laszlo Ersek
` (2 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Laszlo Ersek @ 2024-03-05 12:01 UTC (permalink / raw)
To: edk2-devel-groups-io; +Cc: Nate DeSimone, Sai Chaganty
<Library/PeimEntryPoint.h> declares a bogus
ProcessLibraryConstructorList() for SimicsOpenBoardPkg's SEC module. Rely
on AutoGen for (properly) declaring ProcessLibraryConstructorList().
Update the call.
Build-tested with:
- appending the following directories to PACKAGES_PATH:
Drivers
Features/Intel
Features/Intel/Debugging
Features/Intel/Network
Features/Intel/OutOfBandManagement
Features/Intel/PowerManagement
Features/Intel/SystemInformation
Features/Intel/UserInterface
Platform/Intel
Silicon/Intel
- commenting out "SimicsIch10BinPkg/UndiBinary/UndiDxe.inf" in
"Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc" and
"Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf"
- running the command
build -a IA32 -a X64 -b DEBUG \
-m Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf \
-p Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc \
-t GCC5
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf | 2 +-
Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf
index af1c0f2b55d1..fcf34c0def4e 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf
+++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf
@@ -8,7 +8,7 @@
##
[Defines]
- INF_VERSION = 0x00010005
+ INF_VERSION = 1.30
BASE_NAME = SecMain
FILE_GUID = e67f156f-54c5-47f3-a35d-07c045881e14
MODULE_TYPE = SEC
diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c
index 39e879e9223e..09d43c6bf63b 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c
+++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c
@@ -9,7 +9,6 @@
#include <PiPei.h>
-#include <Library/PeimEntryPoint.h>
#include <Library/BaseLib.h>
#include <Library/DebugLib.h>
#include <Library/BaseMemoryLib.h>
@@ -738,7 +737,7 @@ SecCoreStartupWithStack (
Table[Index] = 0;
}
- ProcessLibraryConstructorList (NULL, NULL);
+ ProcessLibraryConstructorList ();
DEBUG ((EFI_D_INFO,
"SecCoreStartupWithStack(0x%x, 0x%x)\n",
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116380): https://edk2.groups.io/g/devel/message/116380
Mute This Topic: https://groups.io/mt/104742758/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [edk2-devel] [edk2-platforms PATCH v2 2/4] SimicsOpenBoardPkg: auto-gen & fix SEC ProcessLibraryConstructorList() decl
2024-03-05 12:01 ` [edk2-devel] [edk2-platforms PATCH v2 2/4] SimicsOpenBoardPkg: auto-gen & fix " Laszlo Ersek
@ 2024-03-06 21:10 ` Laszlo Ersek
2024-03-06 22:24 ` Michael D Kinney
0 siblings, 1 reply; 11+ messages in thread
From: Laszlo Ersek @ 2024-03-06 21:10 UTC (permalink / raw)
To: edk2-devel-groups-io; +Cc: Nate DeSimone, Sai Chaganty
Can I please get a quick R-b for this patch -- it's urgent because of
<https://edk2.groups.io/g/devel/message/116453>.
Thank you,
Laszlo
On 3/5/24 13:01, Laszlo Ersek wrote:
> <Library/PeimEntryPoint.h> declares a bogus
> ProcessLibraryConstructorList() for SimicsOpenBoardPkg's SEC module. Rely
> on AutoGen for (properly) declaring ProcessLibraryConstructorList().
> Update the call.
>
> Build-tested with:
>
> - appending the following directories to PACKAGES_PATH:
>
> Drivers
> Features/Intel
> Features/Intel/Debugging
> Features/Intel/Network
> Features/Intel/OutOfBandManagement
> Features/Intel/PowerManagement
> Features/Intel/SystemInformation
> Features/Intel/UserInterface
> Platform/Intel
> Silicon/Intel
>
> - commenting out "SimicsIch10BinPkg/UndiBinary/UndiDxe.inf" in
> "Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc" and
> "Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf"
>
> - running the command
>
> build -a IA32 -a X64 -b DEBUG \
> -m Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf \
> -p Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc \
> -t GCC5
>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf | 2 +-
> Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c | 3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf
> index af1c0f2b55d1..fcf34c0def4e 100644
> --- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf
> +++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf
> @@ -8,7 +8,7 @@
> ##
>
> [Defines]
> - INF_VERSION = 0x00010005
> + INF_VERSION = 1.30
> BASE_NAME = SecMain
> FILE_GUID = e67f156f-54c5-47f3-a35d-07c045881e14
> MODULE_TYPE = SEC
> diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c
> index 39e879e9223e..09d43c6bf63b 100644
> --- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c
> +++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c
> @@ -9,7 +9,6 @@
>
> #include <PiPei.h>
>
> -#include <Library/PeimEntryPoint.h>
> #include <Library/BaseLib.h>
> #include <Library/DebugLib.h>
> #include <Library/BaseMemoryLib.h>
> @@ -738,7 +737,7 @@ SecCoreStartupWithStack (
> Table[Index] = 0;
> }
>
> - ProcessLibraryConstructorList (NULL, NULL);
> + ProcessLibraryConstructorList ();
>
> DEBUG ((EFI_D_INFO,
> "SecCoreStartupWithStack(0x%x, 0x%x)\n",
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116459): https://edk2.groups.io/g/devel/message/116459
Mute This Topic: https://groups.io/mt/104742758/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [edk2-devel] [edk2-platforms PATCH v2 2/4] SimicsOpenBoardPkg: auto-gen & fix SEC ProcessLibraryConstructorList() decl
2024-03-06 21:10 ` Laszlo Ersek
@ 2024-03-06 22:24 ` Michael D Kinney
0 siblings, 0 replies; 11+ messages in thread
From: Michael D Kinney @ 2024-03-06 22:24 UTC (permalink / raw)
To: devel@edk2.groups.io, lersek@redhat.com
Cc: Desimone, Nathaniel L, Chaganty, Rangasai V, Kinney, Michael D
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo
> Ersek
> Sent: Wednesday, March 6, 2024 1:10 PM
> To: edk2-devel-groups-io <devel@edk2.groups.io>
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Chaganty,
> Rangasai V <rangasai.v.chaganty@intel.com>
> Subject: Re: [edk2-devel] [edk2-platforms PATCH v2 2/4]
> SimicsOpenBoardPkg: auto-gen & fix SEC ProcessLibraryConstructorList()
> decl
>
> Can I please get a quick R-b for this patch -- it's urgent because of
> <https://edk2.groups.io/g/devel/message/116453>.
>
> Thank you,
> Laszlo
>
> On 3/5/24 13:01, Laszlo Ersek wrote:
> > <Library/PeimEntryPoint.h> declares a bogus
> > ProcessLibraryConstructorList() for SimicsOpenBoardPkg's SEC module.
> Rely
> > on AutoGen for (properly) declaring ProcessLibraryConstructorList().
> > Update the call.
> >
> > Build-tested with:
> >
> > - appending the following directories to PACKAGES_PATH:
> >
> > Drivers
> > Features/Intel
> > Features/Intel/Debugging
> > Features/Intel/Network
> > Features/Intel/OutOfBandManagement
> > Features/Intel/PowerManagement
> > Features/Intel/SystemInformation
> > Features/Intel/UserInterface
> > Platform/Intel
> > Silicon/Intel
> >
> > - commenting out "SimicsIch10BinPkg/UndiBinary/UndiDxe.inf" in
> > "Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc"
> and
> > "Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf"
> >
> > - running the command
> >
> > build -a IA32 -a X64 -b DEBUG \
> > -m Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf \
> > -p
> Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc \
> > -t GCC5
> >
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
> > Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> > ---
> > Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf | 2 +-
> > Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c | 3 +--
> > 2 files changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf
> b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf
> > index af1c0f2b55d1..fcf34c0def4e 100644
> > --- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf
> > +++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf
> > @@ -8,7 +8,7 @@
> > ##
> >
> > [Defines]
> > - INF_VERSION = 0x00010005
> > + INF_VERSION = 1.30
> > BASE_NAME = SecMain
> > FILE_GUID = e67f156f-54c5-47f3-a35d-
> 07c045881e14
> > MODULE_TYPE = SEC
> > diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c
> b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c
> > index 39e879e9223e..09d43c6bf63b 100644
> > --- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c
> > +++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c
> > @@ -9,7 +9,6 @@
> >
> > #include <PiPei.h>
> >
> > -#include <Library/PeimEntryPoint.h>
> > #include <Library/BaseLib.h>
> > #include <Library/DebugLib.h>
> > #include <Library/BaseMemoryLib.h>
> > @@ -738,7 +737,7 @@ SecCoreStartupWithStack (
> > Table[Index] = 0;
> > }
> >
> > - ProcessLibraryConstructorList (NULL, NULL);
> > + ProcessLibraryConstructorList ();
> >
> > DEBUG ((EFI_D_INFO,
> > "SecCoreStartupWithStack(0x%x, 0x%x)\n",
> >
> >
> >
> >
> >
> >
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116463): https://edk2.groups.io/g/devel/message/116463
Mute This Topic: https://groups.io/mt/104742758/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 11+ messages in thread
* [edk2-devel] [edk2-platforms PATCH v2 3/4] LoongArchQemuPkg: auto-gen & fix SEC ProcessLibraryConstructorList() decl
2024-03-05 12:01 [edk2-devel] [edk2-platforms PATCH v2 0/4] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
2024-03-05 12:01 ` [edk2-devel] [edk2-platforms PATCH v2 1/4] BeagleBoardPkg: auto-generate SEC ProcessLibraryConstructorList() decl Laszlo Ersek
2024-03-05 12:01 ` [edk2-devel] [edk2-platforms PATCH v2 2/4] SimicsOpenBoardPkg: auto-gen & fix " Laszlo Ersek
@ 2024-03-05 12:01 ` Laszlo Ersek
2024-03-05 13:05 ` Chao Li
2024-03-05 12:01 ` [edk2-devel] [edk2-platforms PATCH v2 4/4] SG2042Pkg/Sec: clean up " Laszlo Ersek
2024-03-08 9:20 ` [edk2-devel] [edk2-platforms PATCH v2 0/4] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
4 siblings, 1 reply; 11+ messages in thread
From: Laszlo Ersek @ 2024-03-05 12:01 UTC (permalink / raw)
To: edk2-devel-groups-io; +Cc: Bibo Mao, Chao Li, Xianglai li
<Library/PeimEntryPoint.h> declares a bogus
ProcessLibraryConstructorList() for LoongArchQemuPkg's SEC module. Rely on
AutoGen for (properly) declaring ProcessLibraryConstructorList(). Update
the call.
Build-tested with:
build -a LOONGARCH64 -b DEBUG \
-m Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf \
-p Platform/Loongson/LoongArchQemuPkg/Loongson.dsc -t GCC5
Cc: Bibo Mao <maobibo@loongson.cn>
Cc: Chao Li <lichao@loongson.cn>
Cc: Xianglai li <lixianglai@loongson.cn>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf | 2 +-
Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf b/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf
index c0d5439d5379..bb86c7c77471 100644
--- a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf
+++ b/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf
@@ -8,7 +8,7 @@
##
[Defines]
- INF_VERSION = 0x00010005
+ INF_VERSION = 1.30
BASE_NAME = SecMain
FILE_GUID = 57d02d4f-5a5d-4bfa-b7d6-ba0a4d2c72ce
MODULE_TYPE = SEC
diff --git a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c b/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c
index 3f1998c48c12..50d898859a99 100644
--- a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c
+++ b/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c
@@ -9,7 +9,6 @@
#include <PiPei.h>
-#include <Library/PeimEntryPoint.h>
#include <Library/BaseLib.h>
#include <Library/DebugLib.h>
#include <Library/BaseMemoryLib.h>
@@ -378,7 +377,7 @@ SecCoreStartupWithStack (
DEBUG ((DEBUG_INFO, "Entering C environment\n"));
- ProcessLibraryConstructorList (NULL, NULL);
+ ProcessLibraryConstructorList ();
DEBUG ((DEBUG_INFO,
"SecCoreStartupWithStack (0x%lx, 0x%lx)\n",
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116381): https://edk2.groups.io/g/devel/message/116381
Mute This Topic: https://groups.io/mt/104742760/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [edk2-devel] [edk2-platforms PATCH v2 3/4] LoongArchQemuPkg: auto-gen & fix SEC ProcessLibraryConstructorList() decl
2024-03-05 12:01 ` [edk2-devel] [edk2-platforms PATCH v2 3/4] LoongArchQemuPkg: " Laszlo Ersek
@ 2024-03-05 13:05 ` Chao Li
0 siblings, 0 replies; 11+ messages in thread
From: Chao Li @ 2024-03-05 13:05 UTC (permalink / raw)
To: devel, lersek; +Cc: Bibo Mao, Xianglai li
[-- Attachment #1: Type: text/plain, Size: 2767 bytes --]
Hi Laszlo,
If the SPEC and BaseTools are ready, then then that's fine with me.
Reviewed-by: Chao Li <lichao@loongson.cn>
Thanks,
Chao
On 2024/3/5 20:01, Laszlo Ersek wrote:
> <Library/PeimEntryPoint.h> declares a bogus
> ProcessLibraryConstructorList() for LoongArchQemuPkg's SEC module. Rely on
> AutoGen for (properly) declaring ProcessLibraryConstructorList(). Update
> the call.
>
> Build-tested with:
>
> build -a LOONGARCH64 -b DEBUG \
> -m Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf \
> -p Platform/Loongson/LoongArchQemuPkg/Loongson.dsc -t GCC5
>
> Cc: Bibo Mao<maobibo@loongson.cn>
> Cc: Chao Li<lichao@loongson.cn>
> Cc: Xianglai li<lixianglai@loongson.cn>
> Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=990
> Signed-off-by: Laszlo Ersek<lersek@redhat.com>
> ---
> Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf | 2 +-
> Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c | 3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf b/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf
> index c0d5439d5379..bb86c7c77471 100644
> --- a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf
> +++ b/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf
> @@ -8,7 +8,7 @@
> ##
>
> [Defines]
> - INF_VERSION = 0x00010005
> + INF_VERSION = 1.30
> BASE_NAME = SecMain
> FILE_GUID = 57d02d4f-5a5d-4bfa-b7d6-ba0a4d2c72ce
> MODULE_TYPE = SEC
> diff --git a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c b/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c
> index 3f1998c48c12..50d898859a99 100644
> --- a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c
> +++ b/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c
> @@ -9,7 +9,6 @@
>
> #include <PiPei.h>
>
> -#include <Library/PeimEntryPoint.h>
> #include <Library/BaseLib.h>
> #include <Library/DebugLib.h>
> #include <Library/BaseMemoryLib.h>
> @@ -378,7 +377,7 @@ SecCoreStartupWithStack (
>
> DEBUG ((DEBUG_INFO, "Entering C environment\n"));
>
> - ProcessLibraryConstructorList (NULL, NULL);
> + ProcessLibraryConstructorList ();
>
> DEBUG ((DEBUG_INFO,
> "SecCoreStartupWithStack (0x%lx, 0x%lx)\n",
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116390): https://edk2.groups.io/g/devel/message/116390
Mute This Topic: https://groups.io/mt/104742760/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 4312 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* [edk2-devel] [edk2-platforms PATCH v2 4/4] SG2042Pkg/Sec: clean up ProcessLibraryConstructorList() decl
2024-03-05 12:01 [edk2-devel] [edk2-platforms PATCH v2 0/4] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
` (2 preceding siblings ...)
2024-03-05 12:01 ` [edk2-devel] [edk2-platforms PATCH v2 3/4] LoongArchQemuPkg: " Laszlo Ersek
@ 2024-03-05 12:01 ` Laszlo Ersek
2024-03-05 14:07 ` Sunil V L
2024-03-08 9:20 ` [edk2-devel] [edk2-platforms PATCH v2 0/4] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
4 siblings, 1 reply; 11+ messages in thread
From: Laszlo Ersek @ 2024-03-05 12:01 UTC (permalink / raw)
To: edk2-devel-groups-io; +Cc: Sunil V L, USER0FISH, caiyuqing379, dahogn, meng-cz
<Library/PeimEntryPoint.h> declares a bogus
ProcessLibraryConstructorList() for the SG2042Pkg SEC module. Rely on
AutoGen for (properly) declaring ProcessLibraryConstructorList(). Remove
the correct, but superfluous, declaration as well.
Build-tested with:
build -a RISCV64 -b DEBUG -m Silicon/Sophgo/SG2042Pkg/Sec/SecMain.inf \
-p Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc -t GCC5
Cc: Sunil V L <sunilvl@ventanamicro.com>
Cc: USER0FISH <libing1202@outlook.com>
Cc: caiyuqing379 <caiyuqing_hz@outlook.com>
Cc: dahogn <dahogn@hotmail.com>
Cc: meng-cz <mengcz1126@gmail.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
Silicon/Sophgo/SG2042Pkg/Sec/SecMain.inf | 2 +-
Silicon/Sophgo/SG2042Pkg/Sec/SecMain.h | 12 ------------
Silicon/Sophgo/SG2042Pkg/Sec/Memory.c | 1 -
3 files changed, 1 insertion(+), 14 deletions(-)
diff --git a/Silicon/Sophgo/SG2042Pkg/Sec/SecMain.inf b/Silicon/Sophgo/SG2042Pkg/Sec/SecMain.inf
index a9f631193b8b..fd52dccfacac 100644
--- a/Silicon/Sophgo/SG2042Pkg/Sec/SecMain.inf
+++ b/Silicon/Sophgo/SG2042Pkg/Sec/SecMain.inf
@@ -9,7 +9,7 @@
##
[Defines]
- INF_VERSION = 0x0001001B
+ INF_VERSION = 1.30
BASE_NAME = SecMainRiscV64
FILE_GUID = 125E1236-9D4F-457B-BF7E-6311C88A1621
MODULE_TYPE = SEC
diff --git a/Silicon/Sophgo/SG2042Pkg/Sec/SecMain.h b/Silicon/Sophgo/SG2042Pkg/Sec/SecMain.h
index 8d2c4a4c25e0..daab7c78b409 100644
--- a/Silicon/Sophgo/SG2042Pkg/Sec/SecMain.h
+++ b/Silicon/Sophgo/SG2042Pkg/Sec/SecMain.h
@@ -49,18 +49,6 @@ SecStartup (
IN VOID *DeviceTreeAddress
);
-/**
- Auto-generated function that calls the library constructors for all of the module's
- dependent libraries. This function must be called by the SEC Core once a stack has
- been established.
-
-**/
-VOID
-EFIAPI
-ProcessLibraryConstructorList (
- VOID
- );
-
/**
Perform Platform PEIM initialization.
diff --git a/Silicon/Sophgo/SG2042Pkg/Sec/Memory.c b/Silicon/Sophgo/SG2042Pkg/Sec/Memory.c
index 51974cf2dc28..df49a17695d1 100644
--- a/Silicon/Sophgo/SG2042Pkg/Sec/Memory.c
+++ b/Silicon/Sophgo/SG2042Pkg/Sec/Memory.c
@@ -19,7 +19,6 @@ Module Name:
#include <Library/HobLib.h>
#include <Library/IoLib.h>
#include <Library/PcdLib.h>
-#include <Library/PeimEntryPoint.h>
#include <Library/ResourcePublicationLib.h>
#include <Register/RiscV64/RiscVEncoding.h>
#include <Library/PrePiLib.h>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116382): https://edk2.groups.io/g/devel/message/116382
Mute This Topic: https://groups.io/mt/104742763/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [edk2-devel] [edk2-platforms PATCH v2 4/4] SG2042Pkg/Sec: clean up ProcessLibraryConstructorList() decl
2024-03-05 12:01 ` [edk2-devel] [edk2-platforms PATCH v2 4/4] SG2042Pkg/Sec: clean up " Laszlo Ersek
@ 2024-03-05 14:07 ` Sunil V L
0 siblings, 0 replies; 11+ messages in thread
From: Sunil V L @ 2024-03-05 14:07 UTC (permalink / raw)
To: Laszlo Ersek
Cc: edk2-devel-groups-io, USER0FISH, caiyuqing379, dahogn, meng-cz
On Tue, Mar 05, 2024 at 01:01:26PM +0100, Laszlo Ersek wrote:
> <Library/PeimEntryPoint.h> declares a bogus
> ProcessLibraryConstructorList() for the SG2042Pkg SEC module. Rely on
> AutoGen for (properly) declaring ProcessLibraryConstructorList(). Remove
> the correct, but superfluous, declaration as well.
>
> Build-tested with:
>
> build -a RISCV64 -b DEBUG -m Silicon/Sophgo/SG2042Pkg/Sec/SecMain.inf \
> -p Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc -t GCC5
>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Cc: USER0FISH <libing1202@outlook.com>
> Cc: caiyuqing379 <caiyuqing_hz@outlook.com>
> Cc: dahogn <dahogn@hotmail.com>
> Cc: meng-cz <mengcz1126@gmail.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> Silicon/Sophgo/SG2042Pkg/Sec/SecMain.inf | 2 +-
> Silicon/Sophgo/SG2042Pkg/Sec/SecMain.h | 12 ------------
> Silicon/Sophgo/SG2042Pkg/Sec/Memory.c | 1 -
> 3 files changed, 1 insertion(+), 14 deletions(-)
>
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116393): https://edk2.groups.io/g/devel/message/116393
Mute This Topic: https://groups.io/mt/104742763/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [edk2-devel] [edk2-platforms PATCH v2 0/4] clean up ProcessLibraryConstructorList() declarations in SEC modules
2024-03-05 12:01 [edk2-devel] [edk2-platforms PATCH v2 0/4] clean up ProcessLibraryConstructorList() declarations in SEC modules Laszlo Ersek
` (3 preceding siblings ...)
2024-03-05 12:01 ` [edk2-devel] [edk2-platforms PATCH v2 4/4] SG2042Pkg/Sec: clean up " Laszlo Ersek
@ 2024-03-08 9:20 ` Laszlo Ersek
4 siblings, 0 replies; 11+ messages in thread
From: Laszlo Ersek @ 2024-03-08 9:20 UTC (permalink / raw)
To: edk2-devel-groups-io
Cc: Ard Biesheuvel, Leif Lindholm, Nate DeSimone, Sai Chaganty,
Bibo Mao, Chao Li, Xianglai li, Sunil V L, USER0FISH,
caiyuqing379, dahogn, meng-cz
On 3/5/24 13:01, Laszlo Ersek wrote:
> Bugzilla:
> - https://bugzilla.tianocore.org/show_bug.cgi?id=990
>
> This patch series puts the recent BaseTools feature to use in which
> AutoGen generates the ProcessLibraryConstructorList() declaration in
> "AutoGen.h" for such non-library SEC modules whose INF_VERSION is at
> least 1.30. The BaseTools feature is present in both edk2 [1] and
> edk2-basetools [2], and has been documented in the Build spec [3] and
> the Inf spec [4]. Kudos to Rebecca for tagging a new edk2-basetools
> release [5] [6] with the new feature.
>
> [1] edk2 commit bac9c74080cf
> [2] edk2-basetools commit 5b7161de22ee
> [3] edk2-BuildSpecification commit range db69f5661cae..7a7165a7d199
> [4] edk2-InfSpecification commit range a31e3c842bee..1ea6546578fe
> [5] https://github.com/tianocore/edk2-basetools/releases/tag/v0.1.51
> [6] https://pypi.org/project/edk2-basetools/0.1.51/
>
> The edk2-basetools part is adopted in the first patch (for
> "pip-requirements.txt") of the edk2 series
>
> [edk2-devel] [PATCH v2 00/10]
> clean up ProcessLibraryConstructorList() declarations in SEC modules
>
> https://edk2.groups.io/g/devel/message/116367
> msgid <20240305113843.68812-1-lersek@redhat.com>
>
> The rest of the patches clean up -- superfluous, or even incorrect --
> ProcessLibraryConstructorList() declarations (and, in some cases,
> incorrect calls), together with raising the INF_VERSIONs in the related
> SEC module INF files to 1.30.
>
> Comparing this version to v1 is not useful, as the compatibility
> approach is different, and so this version is structured differently.
> Please review any patches for your subsystem from scratch (they are not
> difficult or large).
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Bibo Mao <maobibo@loongson.cn>
> Cc: Chao Li <lichao@loongson.cn>
> Cc: Xianglai li <lixianglai@loongson.cn>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Cc: USER0FISH <libing1202@outlook.com>
> Cc: caiyuqing379 <caiyuqing_hz@outlook.com>
> Cc: dahogn <dahogn@hotmail.com>
> Cc: meng-cz <mengcz1126@gmail.com>
>
> Thanks,
> Laszlo
>
> Laszlo Ersek (4):
> BeagleBoardPkg: auto-generate SEC ProcessLibraryConstructorList() decl
> SimicsOpenBoardPkg: auto-gen & fix SEC ProcessLibraryConstructorList()
> decl
> LoongArchQemuPkg: auto-gen & fix SEC ProcessLibraryConstructorList()
> decl
> SG2042Pkg/Sec: clean up ProcessLibraryConstructorList() decl
>
> Platform/BeagleBoard/BeagleBoardPkg/PrePi/PeiUniCore.inf | 2 +-
> Platform/BeagleBoard/BeagleBoardPkg/PrePi/PrePi.h | 6 ------
> Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c | 3 +--
> Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf | 2 +-
> Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c | 3 +--
> Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf | 2 +-
> Silicon/Sophgo/SG2042Pkg/Sec/Memory.c | 1 -
> Silicon/Sophgo/SG2042Pkg/Sec/SecMain.h | 12 ------------
> Silicon/Sophgo/SG2042Pkg/Sec/SecMain.inf | 2 +-
> 9 files changed, 6 insertions(+), 27 deletions(-)
>
>
> base-commit: fe41713668d42b20a2370dab27de3269e877e454
Merged by Ard as commit range 4e478301f40e..bb44e786e7a7, via
<https://github.com/tianocore/edk2-platforms/pull/130>.
Thanks!
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116497): https://edk2.groups.io/g/devel/message/116497
Mute This Topic: https://groups.io/mt/104742756/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 11+ messages in thread