From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2A22921188C3A for ; Mon, 5 Nov 2018 14:52:40 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C34763084293; Mon, 5 Nov 2018 22:52:39 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-125-224.rdu2.redhat.com [10.10.125.224]) by smtp.corp.redhat.com (Postfix) with ESMTP id A595E5ED4C; Mon, 5 Nov 2018 22:52:35 +0000 (UTC) To: yuchenlin@synology.com, edk2-devel@lists.01.org Cc: phil@philjordan.eu, jordan.l.justen@intel.com, anthony.perard@citrix.com, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20181102032402.19686-1-yuchenlin@synology.com> From: Laszlo Ersek Message-ID: Date: Mon, 5 Nov 2018 23:52:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181102032402.19686-1-yuchenlin@synology.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Mon, 05 Nov 2018 22:52:39 +0000 (UTC) Subject: Re: [PATCH v2 0/5] OvmfPkg: simply use the Bochs interface for vmsvga X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Nov 2018 22:52:41 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit (+PhilMD) On 11/02/18 04:23, yuchenlin via edk2-devel wrote: > From: yuchenlin > > In this series, replace the original vmsvga driver to Bochs > interface. > > Simply revert vmsvga driver implementation. After it, use Bochs > interface for initializing vmsvga. > > Because of the PCI BARs difference between std vga and vmsvga. > We can not simply recognize the "QEMU VMWare SVGA" as the > QEMU_VIDEO_BOCHS_MMIO variant. > > BAR | std vga | vmsvga > --------------------------------- > 0 | Framebuffer | I/O space > 1 | Reserved | Framebuffer > 2 | MMIO | FIFO > > To overcome this problem, we remain variant QEMU_VIDEO_VMWARE_SVGA, > and use it for: > > (1) Get framebuffer from correct PCI BAR > (2) Prevent using BAR2 for MMIO > > We have tested on qemu before and after commit 104bd1dc70 and all > worked. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: yuchenlin > > Changelog: > v1 -> v2 > * use 'else' clause (Thanks Philippe). > * add more comment in revert patches (Thanks Philippe). > * reorder the revert patches, we should revert the last commit first. > * use correct framebuffer to ClearScreen. > * revert VMWare svga definitions. I'll have to ask for a bit more patience until I come to this series. I can process only so much email backlog in one day. :) And I don't want to butcher this review due to fatigue. Meanwhile, thank you both Phils for the v1 comments! Please comment on v2 as well, if you can! Laszlo