From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6421F1A1DE9 for ; Thu, 6 Oct 2016 00:22:22 -0700 (PDT) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BDB5E624A2; Thu, 6 Oct 2016 07:22:21 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-80.phx2.redhat.com [10.3.116.80]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u967MJ4Q028698; Thu, 6 Oct 2016 03:22:20 -0400 To: "Carsey, Jaben" , Tim Lewis , "afish@apple.com" References: <93F01BC9-4B02-467E-B900-65C6775BB0F3@apple.com> <618fd786-24d4-653c-d6b8-cb774654c644@redhat.com> <7236196A5DF6C040855A6D96F556A53F3F3F6D@msmail.insydesw.com.tw> <7236196A5DF6C040855A6D96F556A53F3F3FD7@msmail.insydesw.com.tw> <7236196A5DF6C040855A6D96F556A53F3F4043@msmail.insydesw.com.tw> Cc: edk2-devel-01 , Leif Lindholm From: Laszlo Ersek Message-ID: Date: Thu, 6 Oct 2016 09:22:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 06 Oct 2016 07:22:21 +0000 (UTC) Subject: Re: Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Oct 2016 07:22:22 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 10/06/16 00:17, Carsey, Jaben wrote: > Laszlo, > > As Tim clarified, the API already fail when the shell protocol was > not present and the shell already needs the UnicodeCollation > protocol. > > The goal here is not to allow the library to function without the > shell protocol (and thereby the UnicodeCollation protocol). The goal > is to allow the constructor to complete successfully. So that a DXE > driver (or other driver) can be loaded into memory and wait for the > shell to be present to increase shell functionality. > > The reasons is that a non-functional ShellOpenFileByName() in the > time gap between them is ok since it will fail as soon as the lib > calls into the shell anyways. This was already true since the > protocol was not present for the API to work with... I got it now. Makes sense. Thanks! Laszlo