Re: [edk2-devel] [PATCH v2] CloudHv: Add CI for CloudHv on AArch64

["Laszlo Ersek" <lersek@redhat.com>]

On 11/23/23 04:22, Jianyong Wu wrote:
> Add the long lost CI for CloudHv on AArch64.
> As CloudHv CI works nearly the same way with other VMMs like KvmTool,
> thus we can easily create its CI configuration based on KvmTool.
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
> ---
>  .../PlatformCI/.azurepipelines/Ubuntu-GCC5.yml      | 13 +++++++++++++
>  .../PlatformCI/{KvmToolBuild.py => CloudHvBuild.py} |  4 ++--
>  2 files changed, 15 insertions(+), 2 deletions(-)
>  copy ArmVirtPkg/PlatformCI/{KvmToolBuild.py => CloudHvBuild.py} (89%)
> 
> diff --git a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> index d1772a65fc..ab8a2db530 100644
> --- a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> +++ b/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> @@ -140,6 +140,19 @@ jobs:
>              Build.Target: "RELEASE"
>              Run: false
>  
> +          CLOUDHV_AARCH64_DEBUG:
> +            Build.File: "$(package)/PlatformCI/CloudHvBuild.py"
> +            Build.Arch: "AARCH64"
> +            Build.Flags: ""
> +            Build.Target: "DEBUG"
> +            Run: false
> +          CLOUDHV_AARCH64_RELEASE:
> +            Build.File: "$(package)/PlatformCI/CloudHvBuild.py"
> +            Build.Arch: "AARCH64"
> +            Build.Flags: ""
> +            Build.Target: "RELEASE"
> +            Run: false
> +
>      workspace:
>        clean: all
>  
> diff --git a/ArmVirtPkg/PlatformCI/KvmToolBuild.py b/ArmVirtPkg/PlatformCI/CloudHvBuild.py
> similarity index 89%
> copy from ArmVirtPkg/PlatformCI/KvmToolBuild.py
> copy to ArmVirtPkg/PlatformCI/CloudHvBuild.py
> index 4d02dba124..06ada39886 100644
> --- a/ArmVirtPkg/PlatformCI/KvmToolBuild.py
> +++ b/ArmVirtPkg/PlatformCI/CloudHvBuild.py
> @@ -19,13 +19,13 @@ class CommonPlatform():
>          for the different parts of stuart
>      '''
>      PackagesSupported = ("ArmVirtPkg",)
> -    ArchSupported = ("AARCH64", "ARM")
> +    ArchSupported = ("AARCH64")

Right, and this one change is new in version 2 of the patch.

My R-b stands.

I'm picking this up now.

Laszlo

>      TargetsSupported = ("DEBUG", "RELEASE")
>      Scopes = ('armvirt', 'edk2-build')
>      WorkspaceRoot = os.path.realpath(os.path.join(
>          os.path.dirname(os.path.abspath(__file__)), "..", ".."))
>  
> -    DscName = os.path.join("ArmVirtPkg", "ArmVirtKvmTool.dsc")
> +    DscName = os.path.join("ArmVirtPkg", "ArmVirtCloudHv.dsc")
>      FvQemuArg = "" # ignored
>  
>  import PlatformBuildLib



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112317): https://edk2.groups.io/g/devel/message/112317
Mute This Topic: https://groups.io/mt/102761729/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-