From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 364CD7803D2 for ; Wed, 3 Jan 2024 11:34:01 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=JMyt+WLeyrhRY9oxyRPeOraRPgfflcSp3kHlunx9vLQ=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Authentication-Results-Original:Message-ID:Date:User-Agent:Subject:To:CC:References:From:In-Reply-To:MIME-Version:NoDisclaimer:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704281639; v=1; b=A4h0ErrbrZOqbBv8zC1NBjmcA3hFH+bMn3EJZCv0iVlMumJp5Xbf33biY6U4Ajxk9PMl4E0a irDVjWa/9WP5ANy65l/foz2j1ngplGUs9ZZMO3zm/mrlwcjbwCp1vOvbiY8USY/4hWgM5W9GCfS EiXzx36tSux1V2WWNtXKiB9U= X-Received: by 127.0.0.2 with SMTP id cFG6YY7687511x55kr8XwSQf; Wed, 03 Jan 2024 03:33:59 -0800 X-Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.85]) by mx.groups.io with SMTP id smtpd.web11.15598.1704281638219800836 for ; Wed, 03 Jan 2024 03:33:59 -0800 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=HVJ0V8EDPQLOE9qwEibDbTD4LTPrpdWJW6D7w5HcPJthqtsclxHk9TzJXqAepaCN4ikervltlWOGSvdAsUeBF1v4xm9tk5UFoalN2ADDagovgxq08vlWBRZsGGAyUrCza+ts+loHP4J+y2QuHaEIyjQJu7c5ejYaxuwqUoNHGM2t3RzkpZi3Js5cZvhqNc96DNcEm/hQF1EQUuh90NFWwoHjLVgdO4AVfWExJXBYNFHqO4/Q0QsSK50ylKk7zmcoRwO8qnzngjMDOIUBJIEyWuMD9klyD/mR35kHowClT/f9QJj6F03QRy4T92Na9EpGKOtfUBqezKTLWXKPEsl68Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UnhwB501NucJT6+SsmsldF1WQx7VxfvgkfXe46InQKw=; b=VIIrBihGggtadluARWNSYuxUtqp6riV7scR+yZeF1EwRFZKAB/pMgjb13q65xL7vgnWo2UxzJdiPn2WB1tPGPc8poi7FQm4GiPRPritJu1KRObXQ1dOrd9L1RFQhcbOcDBZveOrymnutsOH/pWXQ462ZDtwa8W+JVqi+LIqrzUYQ7VKE3T+blHScwsj2ddULH8jgIrbB0k1qV8Pn9WUoK5+xGkGaY8fXqnaKWYXS8WLV1GQih9+uvF6znupw149XqY5nSCin9wh5V00sxtnBlgmxbj1qTuy5TmNzmNHnQO8bVTJ8MYqwJctUb3aPLLcXX0pzJky6iX9dblfGXO6APA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) X-Received: from AM6PR04CA0036.eurprd04.prod.outlook.com (2603:10a6:20b:92::49) by GV1PR08MB7850.eurprd08.prod.outlook.com (2603:10a6:150:5d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.13; Wed, 3 Jan 2024 11:33:49 +0000 X-Received: from AMS0EPF000001A1.eurprd05.prod.outlook.com (2603:10a6:20b:92:cafe::6c) by AM6PR04CA0036.outlook.office365.com (2603:10a6:20b:92::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7135.25 via Frontend Transport; Wed, 3 Jan 2024 11:33:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AMS0EPF000001A1.mail.protection.outlook.com (10.167.16.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.9 via Frontend Transport; Wed, 3 Jan 2024 11:33:49 +0000 X-Received: ("Tessian outbound 9bee66383d2d:v239"); Wed, 03 Jan 2024 11:33:49 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4bed18f4ec432d2e X-CR-MTA-TID: 64aa7808 X-Received: from 6a4afd412b15.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8BAB701D-32B4-48C8-8800-640B49128DEC.1; Wed, 03 Jan 2024 11:33:38 +0000 X-Received: from EUR02-AM0-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6a4afd412b15.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 03 Jan 2024 11:33:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=POTWmiaUVgnuZVURMY16hKqBX23mX7QeJecNtBa2aplOlj98rfhbKgxkhtHp+pYfRZorE0xbQv2j3c+uBwCp57ta98koKWQbwWXgIfwrwyYC588qy11dIDSKia4lEJoGYIFy+fWfWo0zeYGRyM6KRzNtsnhAl3ix0Ls9nFwLCRorqobblU4gmvzHSHXFzcDB6V7TC4BLKkkrebi8TFCVm/Ry8ls4A33A0iyJ+f1P2OIEP2KCtMsAHZ+DtwzIIZlJEyc0scamkuX39wCSl/RSROuyUSbR6RmOlYtl5hOZPG9ifqAwxKg7y1ZDfrvnwD+CCZuKwcnZ36XyP+33xyAORg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UnhwB501NucJT6+SsmsldF1WQx7VxfvgkfXe46InQKw=; b=niSRfc88nQJ2hTeK0iGSUwJ90thQnUnJCtteWuM3WapzVnXZj4UGBtE+PA6AXHTiZt5Exgmr9AoYhkaw8GETSscOdCjN6N43syQT18ponAfp+AefsSHA3NBXU/MPgvye+H58DtstQUy9Dc/sGEl4gJ9YCuQvrY+vBpgMM0Pk2gl5LVnxWuZiiUsjolgDe2W9OZD23+jjdUtfQo1UyZ605KvcLldCCat6ejjDm/cys779GLPEMAyLkLsrgv5ocYFEPsKcWl/sl9NDLybw2aAdIqi/ghWQ408Oh598h5YKudlbUcsz3K92yg6vpnJXVUUh4gVXvt4trFrlYfCecQKd3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AS2PR08MB8288.eurprd08.prod.outlook.com (2603:10a6:20b:557::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7135.25; Wed, 3 Jan 2024 11:33:35 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775%4]) with mapi id 15.20.7159.013; Wed, 3 Jan 2024 11:33:35 +0000 Message-ID: Date: Wed, 3 Jan 2024 11:33:33 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2 1/2] DynamicTablesPkg: Fix X64 compilation errors To: Abdul Lateef Attar , devel@edk2.groups.io CC: Abdul Lateef Attar , Pierre Gondois , "nd@arm.com" References: <90b7c3f026208ea2055293fb34a829d60ba5e1a8.1704265673.git.AbdulLateef.Attar@amd.com> From: "Sami Mujawar" In-Reply-To: <90b7c3f026208ea2055293fb34a829d60ba5e1a8.1704265673.git.AbdulLateef.Attar@amd.com> X-ClientProxiedBy: LO2P265CA0480.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a2::36) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|AS2PR08MB8288:EE_|AMS0EPF000001A1:EE_|GV1PR08MB7850:EE_ X-MS-Office365-Filtering-Correlation-Id: 217a109f-e781-4a54-c482-08dc0c4fdae7 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: CQtQwCtnKvYaRMphajnxu6OffE7qe/gAWTq5bHbKluKge+1xqhEXOZAFPGSLJLg94SWAoQKBvtequJYpCj8lDopqjHXm8x2L98rZ/iSEEIzNoIYcAx3ZtPZcpCHlda95Suhdg+TBpK/5Q1HPO7kx0ZlArlki1thaEdQbE+0840S/X9seDJ3Jrvz47DEvclbCxOJu44tiHZpXinySPQ6qKsvOMPmRmi8lzobc2snbMo459sUUJR6DXUQDwXc5N2uXkvIwYEWX+DTD2Stk4YdbtLx5Vb2HmuaA3HWeKQw1eAHZlxWE0DF1kQX/gFxQkkXsT5+mvkkjvowOQFxLhxPckokUlXPO3qvzK3RiVQUrGPDmFrRN0JHFmsrmkilhwetdaBNwPCrTFcs4tVD4IqLkrUO7xdwVRQEuSmOP5aOBbGNURZWC+4LAJ8PoXn0F2y68OEUxZXzM4IFtpSx8erpo3NIJ61Oq3xE4dxjwkMmENCYDxQ7ioA9Ugz2AiL2NXtxDP3hf6EBv3M/IstZSa7R59VGMJIPDHXmQY9j4gVAGOBMrcx5H0UZB6for9dFpQWIpYjhrbqh2wt2EqTFyOWIJj4P1cu4ykv8ddUQU+ed69fbkWC9e7L2aJNam6KOsHq5i5u+A441jEejyd1BIl7aYRqOXaYeWOILg7CUPgz88PWn+2pEjCxe435na/G7nysXk X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(396003)(376002)(366004)(39860400002)(346002)(230922051799003)(451199024)(64100799003)(186009)(1800799012)(6512007)(2616005)(86362001)(26005)(83380400001)(66946007)(53546011)(4326008)(2906002)(5660300002)(44832011)(41300700001)(6486002)(478600001)(316002)(54906003)(8936002)(66476007)(66556008)(8676002)(38100700002)(6506007)(31696002)(36756003)(31686004)(45980500001)(43740500002)(14943795004);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8288 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF000001A1.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: bcb1caa6-982d-4039-7a75-08dc0c4fd269 X-Microsoft-Antispam-Message-Info: VhbBpCWa5TjyAyr7OgbzlY3WjuzGexkRB7haXuZruD7ydm9QnHoAwlIswZWWXuoB76Fyo0QlH5M2FsSEfWvKfHqwJw535ahRZ9Yv3K2TpKYvyL3yd4lr7LdcP4Yr4pkBxV8V65onSnFSZS0vM3wr9YXhAkPf6ZymueiCHykz+8gtvlk0KFXCUSM/fZqsLpUfo6C98NkyRMAFCYMqs2+i5IirlTStOAYbUpb/t9ed2DGG0j4CEOGigmkV4+9hGdkXFlARfFzaAAjZdqfi8pw3yj5JNTYQCAGsxH3Q4bAmjYWgXvHRshSd91frEJpcbFba9AXwUIaIJAbIKktJQrtEjJn8L5hQffTPI1W5cV7CHwlrLU52JJybkMUgoA3nnrE+TYl4L3LDhJkelg7C+MnMtn6zBcx1YycUUlfqnZdzBKUtQ/dlyr6K58fPmxDnbG9yic5jZ/z+F9L8SglztK2OyCi5SZUz1LwtS6kQa5DD7/yzQsXYytjN1Kn6lhDQFSuLEsAr/maR3hA/iBLZGXHWKlbu270FDTILkyz0Jg0vW82Vnwnl43oVItqHjHw0i2kWPVoSAQofTJiTKXwrUL54oKEGEzw5BfOxqUhZbMmE+bEsbgi2RnNeH7mEbIDREG+ZysBXdTO9468ydlpp7TBB6WkaW/Elz9uvhJM98XkcqXKwaJLR1UfRoioF4k4WmVINJ9i4aVVQl0n0FN66yaFmAp2pHksJb/xyJjvxM0XdFGFyuGj54dFouzwGFzodLliR0liSY58tyJd7QVDxZZk5nBiKiBheO3VEx1TGskt5VAZzRaT49crvsErEGiRrL+km X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2024 11:33:49.3558 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 217a109f-e781-4a54-c482-08dc0c4fdae7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF000001A1.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7850 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Ke54FDiFpEdeGrxVThtZZDSRx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=A4h0Errb; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Abdul, Thank you for this patch. I have some minor suggestions=C2=A0 that I will fix before merging. Otherwi= se=20 this patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 03/01/2024 09:52 am, Abdul Lateef Attar wrote: > From: Abdul Lateef Attar > > Add the support for X64 compilation to the CI. > Fix the compilation errors. > > Cc: Pierre Gondois > Cc: Sami Mujawar > Signed-off-by: Abdul Lateef Attar > --- > DynamicTablesPkg/DynamicTables.dsc.inc | 17 ++++++++++++----- > DynamicTablesPkg/DynamicTablesPkg.dsc | 7 +++++-- > .../Library/Common/AmlLib/AmlLib.inf | 2 ++ > .../Library/Common/AmlLib/CodeGen/AmlCodeGen.c | 4 ++-- > .../Common/DynamicPlatRepoLib/DynamicPlatRepo.c | 7 ++++--- > .../Library/Common/TableHelperLib/TableHelper.c | 2 ++ > .../Common/TableHelperLib/TableHelperLib.inf | 2 ++ > 7 files changed, 29 insertions(+), 12 deletions(-) > > diff --git a/DynamicTablesPkg/DynamicTables.dsc.inc b/DynamicTablesPkg/Dy= namicTables.dsc.inc > index 9d4312c4e8..804fb00a85 100644 > --- a/DynamicTablesPkg/DynamicTables.dsc.inc > +++ b/DynamicTablesPkg/DynamicTables.dsc.inc > @@ -2,6 +2,7 @@ > # Dsc include file for Dynamic Tables Framework. > # > # Copyright (c) 2017 - 2022, Arm Limited. All rights reserved.
> +# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<= BR> > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -21,6 +22,17 @@ > SmbiosStringTableLib|DynamicTablesPkg/Library/Common/SmbiosStringTabl= eLib/SmbiosStringTableLib.inf > =20 > [Components.common] > + # > + # Dynamic Table Factory Dxe > + # > + DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe= .inf [SAMI] I think this should go in a separate section i.e.=20 [Components.X64]. Similarly the patch 2/2 needs to extend this to add=20 Components.IA32. > + > + # > + # Dynamic Tables Manager Dxe > + # > + DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe= .inf > + > +[Components.ARM, Components.AARCH64] > # > # Generators > # > @@ -70,8 +82,3 @@ > NULL|DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPci= eLibArm.inf > } > =20 > - # > - # Dynamic Tables Manager Dxe > - # > - DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe= .inf > - > diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc b/DynamicTablesPkg/Dyn= amicTablesPkg.dsc > index bd5084a900..a2db14efaf 100644 > --- a/DynamicTablesPkg/DynamicTablesPkg.dsc > +++ b/DynamicTablesPkg/DynamicTablesPkg.dsc > @@ -3,6 +3,7 @@ > # > # Copyright (c) 2019, Linaro Limited. All rights reserved.
> # Copyright (c) 2019 - 2022, Arm Limited. All rights reserved.
> +# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<= BR> > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -14,7 +15,7 @@ > PLATFORM_VERSION =3D 0.1 > DSC_SPECIFICATION =3D 0x0001001a > OUTPUT_DIRECTORY =3D Build/DynamicTables > - SUPPORTED_ARCHITECTURES =3D ARM|AARCH64 > + SUPPORTED_ARCHITECTURES =3D ARM|AARCH64|X64 > BUILD_TARGETS =3D DEBUG|RELEASE|NOOPT > SKUID_IDENTIFIER =3D DEFAULT > =20 > @@ -44,10 +45,12 @@ > DynamicTablesPkg/Library/Common/SsdtPcieSupportLib/SsdtPcieSupportLib= .inf > DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPort= FixupLib.inf > DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf > - DynamicTablesPkg/Library/FdtHwInfoParserLib/FdtHwInfoParserLib.inf > DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib= .inf > DynamicTablesPkg/Library/Common/SmbiosStringTableLib/SmbiosStringTabl= eLib.inf > =20 > +[Components.ARM, Components.AARCH64] > + DynamicTablesPkg/Library/FdtHwInfoParserLib/FdtHwInfoParserLib.inf > + > [BuildOptions] > *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACES > =20 > diff --git a/DynamicTablesPkg/Library/Common/AmlLib/AmlLib.inf b/DynamicT= ablesPkg/Library/Common/AmlLib/AmlLib.inf > index 723de3ad44..6d0aa6ff93 100644 > --- a/DynamicTablesPkg/Library/Common/AmlLib/AmlLib.inf > +++ b/DynamicTablesPkg/Library/Common/AmlLib/AmlLib.inf > @@ -2,6 +2,7 @@ > # AML Generation Library > # > # Copyright (c) 2019 - 2021, Arm Limited. All rights reserved.
> +# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<= BR> > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > ## > @@ -68,6 +69,7 @@ > [LibraryClasses] > AcpiHelperLib > BaseLib > + MemoryAllocationLib > =20 > [BuildOptions] > *_*_*_CC_FLAGS =3D -DAML_HANDLE > diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c = b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c > index 893ace20ae..d4e3e252cb 100644 > --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c > +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c > @@ -2,7 +2,7 @@ > AML Code Generation. > =20 > Copyright (c) 2020 - 2022, Arm Limited. All rights reserved.
> - Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved. > + Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights res= erved.
> =20 > SPDX-License-Identifier: BSD-2-Clause-Patent > **/ > @@ -922,7 +922,7 @@ AmlCodeGenNameUnicodeString ( > Status =3D AmlCreateDataNode ( > EAmlNodeDataTypeRaw, > (CONST UINT8 *)String, > - StrSize (String), > + (UINT32)StrSize (String), > &DataNode > ); > if (EFI_ERROR (Status)) { > diff --git a/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPl= atRepo.c b/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRe= po.c > index bc713f30b2..bdeb5c78ae 100644 > --- a/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.= c > +++ b/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.= c > @@ -2,6 +2,7 @@ > Dynamic Platform Info Repository > =20 > Copyright (c) 2021, Arm Limited. All rights reserved.
> + Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved. > =20 > SPDX-License-Identifier: BSD-2-Clause-Patent > =20 > @@ -287,8 +288,8 @@ GroupCmObjNodes ( > =20 > CmObjDesc =3D &This->ArmCmObjArray[ArmObjIndex]; > CmObjDesc->ObjectId =3D CmObjId; > - CmObjDesc->Size =3D Size; > - CmObjDesc->Count =3D Count; > + CmObjDesc->Size =3D (UINT32)Size; > + CmObjDesc->Count =3D (UINT32)Count; > CmObjDesc->Data =3D GroupedData; > =20 > return Status; > @@ -340,7 +341,7 @@ DynamicPlatRepoFinalise ( > // (the array is wrapped in a CmObjDesc). > // - Add the Token/CmObj binding to the token mapper. > for (ArmObjIndex =3D 0; ArmObjIndex < EArmObjMax; ArmObjIndex++) { > - Status =3D GroupCmObjNodes (This, ArmObjIndex); > + Status =3D GroupCmObjNodes (This, (UINT32)ArmObjIndex); > if (EFI_ERROR (Status)) { > ASSERT (0); > // Free the TokenMapper. > diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c= b/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c > index 0decd3dc0e..e33d6e656b 100644 > --- a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c > +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c > @@ -2,6 +2,7 @@ > Table Helper > =20 > Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.
> + Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved. > =20 > SPDX-License-Identifier: BSD-2-Clause-Patent > **/ > @@ -16,6 +17,7 @@ > #include > #include > #include > +#include [SAMI] I think the AmlLib.h include can be moved just above the=20 TableHelperLib.h include, so that they are ordered alphabetically. > =20 > /** The GetCgfMgrInfo function gets the CM_STD_OBJ_CONFIGURATION_MANAGE= R_INFO > object from the Configuration Manager. > diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLi= b.inf b/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf > index abbf4bc38c..8df5ab848e 100644 > --- a/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf > +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf > @@ -2,6 +2,7 @@ > # Table Helper > # > # Copyright (c) 2017 - 2021, ARM Limited. All rights reserved. > +# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<= BR> > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > ## > @@ -25,3 +26,4 @@ > =20 > [LibraryClasses] > BaseLib > + AmlLib [SAMI] I prefer to order this section in alphabetical order. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113068): https://edk2.groups.io/g/devel/message/113068 Mute This Topic: https://groups.io/mt/103499169/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-