From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id C63A481E68 for ; Tue, 15 Nov 2016 06:54:30 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3A9BFAD7; Tue, 15 Nov 2016 06:54:35 -0800 (PST) Received: from [192.168.229.136] (u201426.usa.arm.com [10.118.28.53]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D8B3A3F318; Tue, 15 Nov 2016 06:54:34 -0800 (PST) To: Ard Biesheuvel References: <1479157789-14674-1-git-send-email-jeremy.linton@arm.com> Cc: edk2-devel-01 , Steve Capper , Leif Lindholm , Ryan Harkin , linaro-uefi From: Jeremy Linton Message-ID: Date: Tue, 15 Nov 2016 08:54:34 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH 0/8] ATAPI support on SiI SATA adapter X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Nov 2016 14:54:30 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 11/15/2016 01:43 AM, Ard Biesheuvel wrote: > Hi Jeremy, > > On 14 November 2016 at 21:09, Jeremy Linton wrote: >> The SiI isn't an AHCI compatible adapter so it implements the EFI ATA >> pass-through protocol directly. This works for fixed hard drives, but >> not ATAPI attached devices (CDROM, DVDROM, TAPE, etc). >> >> This patch adds read only ATAPI support via the EFI SCSI pass-through >> protocol, allowing boot from attached CD/DVD. This patch also cleans >> up, and tweaks recovery paths/etc in the original driver. > > Very nice! Thanks for getting to the bottom of this. > > However, looking at the patches, they are riddled with coding style > violations. I am usually less strict than Leif when it comes to > upholding those, but these patches really need to be cleaned up to be > considered for merging. Is there a tool which can correct or at least point out the formatting errors? > >> When >> combined with the ARM/PCI dma lib changes this allows us to relax the >> IO alignment requirement that caused grub failures. >> > > What changes are you referring to here? I believe on juno the PCI changed from the ArmDmaLib to the null lib or some such, which removed the bounce buffering on unaligned map/unmap. > >> Finally, the OpenPlatformPkg/Juno must be updated, with another patch >> to avoid build breaks now that the SiI has a dependency on the SCSI >> libraries. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Jeremy Linton >> >> Jeremy Linton (7): >> MdePkg IndustryStandard/Scsi.h: Add sense code macro >> EmbeddedPkg: SiI3132: Add ScsiProtocol callbacks >> EmbeddedPkg: SiI3132: Add SCSI protocol support to header >> EmbeddedPkg: SiI3132: Break out FIS command submission >> EmbeddedPkg: SiI3132: Cleanup device node creation >> EmbeddedPkg: SiI3132: Enable SCSI pass-through protocol >> EmbeddedPkg: SiI3132: Correct the IoAlign >> >> EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c | 48 ++- >> EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h | 89 ++++- >> .../Drivers/SataSiI3132Dxe/SataSiI3132Dxe.inf | 2 + >> .../Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c | 270 ++++++++------ >> .../Drivers/SataSiI3132Dxe/SiI3132ScsiPassThru.c | 401 +++++++++++++++++++++ >> MdePkg/Include/IndustryStandard/Scsi.h | 2 + >> OpenPlatformPkg | 2 +- >> 7 files changed, 688 insertions(+), 126 deletions(-) >> create mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132ScsiPassThru.c >> >> -- >> 2.5.5 >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel