From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.100]) by mx.groups.io with SMTP id smtpd.web11.15816.1678374853079312138 for ; Thu, 09 Mar 2023 07:14:13 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@amperemail.onmicrosoft.com header.s=selector1-amperemail-onmicrosoft-com header.b=IU7yn9HM; spf=pass (domain: os.amperecomputing.com, ip: 40.107.236.100, mailfrom: tinhnguyen@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HqNC/GKRxKzBsKDZ6x2YJOJ68s1T2e7fd+RlFlz8n0l6X9jnHfiAVhiUc8obZBZ6xsGBC/NzPgsySs9O89qqnmL5J+A56tvjIGzP7oy0qoWoxtsF5GEA4vhWh4n+dYMt07xhPzz73C1OWjFNlvGYlIW2niOmIulSyVjQnPDEXCJQx3EkH+LCQ8iOCRQRvxP003x3pggcYS8om4T40IVpa9mVnruC4XyCWl03RF0r9x8jzASK8GYrkigLyHM9mO2ygkUALfOa3FNiHC9DYKmY0Yl6HMv5bM3g/SYAH/rpCp9slf72JHuuTY6Zb5c5+LGmVD5yNuJAkmEoyWe4/v5t8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mCJ/knNN6v0WmSo1aHbwhg8PrKs7ndtNxLmMyFleiYE=; b=dm2Kq1FyCjjLkLQAu/7cn0cEdNt1nA/0WhkTCNYnemmi3STvOT8E9ZN6GSfJrG3MtXh6UtKUR3zeXJAZUePddOub8grHeN1U5Tvwy37ifrstlT3j0zNhRnQzWQjOF6KxfLI99B1BNXiudhDoChehzCFzu8W6elyNmEAFdlXaAW+3GyflOOaHVOO4kYry5a4j9LEF7AFQT2BuzdrMc9j+JTtZGtzCGgHoBVJbyooz1wdE9WvLJNemVTWcuNZMkCxtqykKROGOsw+bH1tT0LDUFZDG8A5KfanBERg0/Yy+lJaxOK8VWLmT2cTxRvlOeG9x8KalMdalgwTyY3JfrjKrCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=amperemail.onmicrosoft.com; dkim=pass header.d=amperemail.onmicrosoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperemail.onmicrosoft.com; s=selector1-amperemail-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mCJ/knNN6v0WmSo1aHbwhg8PrKs7ndtNxLmMyFleiYE=; b=IU7yn9HMqkxaA6bjazr2BoFmDqn8g4xmebSXIMhI7cJk0l2gPwYdY9Lm4YUOnnISdjxl4YxogYVkAquPIDA67c0fgN5G8gdmPqQKOIVTg6B6VaAszRJBnC5Kg2X2yvqBjyMkpFGkjP3PnrIUequrBFzbMtRq4ov7/MPmpEtYLGU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amperemail.onmicrosoft.com; Received: from PH0PR01MB7506.prod.exchangelabs.com (2603:10b6:510:f5::22) by BYAPR01MB3735.prod.exchangelabs.com (2603:10b6:a02:86::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.16; Thu, 9 Mar 2023 15:14:09 +0000 Received: from PH0PR01MB7506.prod.exchangelabs.com ([fe80::c431:46ee:f0b7:3818]) by PH0PR01MB7506.prod.exchangelabs.com ([fe80::c431:46ee:f0b7:3818%8]) with mapi id 15.20.6178.019; Thu, 9 Mar 2023 15:14:09 +0000 Message-ID: Date: Thu, 9 Mar 2023 22:14:00 +0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [edk2-devel] [edk2-platforms][PATCH V2 0/8] Introduce ManageabilityPkg To: devel@edk2.groups.io, abner.chang@amd.com References: <20230308141647.1318-1-abner.chang@amd.com> From: "Tinh Nguyen" In-Reply-To: <20230308141647.1318-1-abner.chang@amd.com> X-ClientProxiedBy: SI2PR02CA0043.apcprd02.prod.outlook.com (2603:1096:4:196::12) To PH0PR01MB7506.prod.exchangelabs.com (2603:10b6:510:f5::22) Return-Path: tinhnguyen@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB7506:EE_|BYAPR01MB3735:EE_ X-MS-Office365-Filtering-Correlation-Id: 4792fccb-f32a-49aa-b057-08db20b0ee49 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dfOn63Mi60iuU+03/lnxhh0t0/eJcr6wyRwnH4MqXQxeyqqcax+XrMmJNXiFBnAtnbelA7oxShwNhE58UQGcFI/AZ4oMh1pTc6sesRufPyWms7UCzkS8YXK8+n1kgOh1dF0mWgJsgJbycGEHHQRewyPv9G7q7h+WKC89qMCLpSI9aUhrz6f3HzKY9ur1g7V7rDIZkl673ZS7nB1zbb4NF5oLgkdubWel2CTvEkXBahp7QQ2JWZ9Sj+Sc4bzVvRSf7KOCvuLJWgprPQBTAMSqZGVnbbQhS+gcfZLF0M0N+djrYH/jRMdJIxs3WsrwgRE7+EKu+abNI8z438c66iIOikyxzq/o6ml82DlIaWcYhrAzmk0IbkhDQLGerMYOvCNP12v73syIrqLtzEOWMTbkN3ifrZikgnS+KhQRzAkqBZtpTx19AOL5Hk4gbWJ64FVYLPgiLlThpdx7nOvcF1P9GQLjLQDk5jg+tLKayJZ7ilNzy85IRc5qwQCBD0rynkEOO//n9UKyTEKG949m15J5jBhAQwQCfwwn5XT7fmvvA5YBE5GEXNTHg/IPyE0y7Hkns2R5olKF1gCjU0NmSiYRtH9/aibqbumSSBtbAyo2DGC277OQcXQgg9dx0AZ3jodb42H1Vm6hyvlbmYdlgjV1agtbd0qmr08ULg0H7LJqQkoBJ/Itcq1DchY17QWLQb20 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR01MB7506.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(39850400004)(136003)(346002)(376002)(396003)(451199018)(83170400001)(31696002)(38100700002)(6666004)(66556008)(2906002)(8676002)(66476007)(8936002)(5660300002)(66946007)(41300700001)(6486002)(6512007)(186003)(2616005)(53546011)(83380400001)(42882007)(6506007)(26005)(316002)(478600001)(966005)(31686004)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eUgxMDBVUFpGd29NZGZ2L1krbnVRbWhxdVp6Zzc4RGxXaEk4Rkk5ZkZPNSti?= =?utf-8?B?YVhuRnorZVZsV3Bnbm9aOWZ0Vm8vVElhRjhjVWh1TmFIWUtmczlkMklqVUNY?= =?utf-8?B?RHJCeWVwU1BtVjU2QVc4ajRVMEk5TEZNZjBWNzVSYWlrdFFYRzNVc21wc3FK?= =?utf-8?B?bmVVZmZLMmhTbnNSZUJia0V6bnplRmp1WU10YmlYTlhoZS9VN1dlSFg3Vlp3?= =?utf-8?B?M2RZTWFyaE1yQytQV2dLKzQ3blFJNy9mMUhqaWRlUVJ2aGdORFZMTWxzVXE0?= =?utf-8?B?ZWx4Z3VDVEdjSkwzVTM2aFg0aUF3YVpaR0VUbTVXbUErVWE1QXhqWUxEcGRI?= =?utf-8?B?c2RJVnVCdWZ1TkVtYi83bGJOaHBFdmFzUGhBT29VQzBXVGU2MjJUeDN1cUZx?= =?utf-8?B?cDNIRWNGQzlNWnloRjFSOW5GRTZ5TDB0RmdRNTVnaWVLem83ZU8rclBYZzNh?= =?utf-8?B?S2crRE10YnpNSENMZ1hVb05FNTZRN2Y3NHZmWW1jSi9GUEdVeUY2SVgrcGZu?= =?utf-8?B?QjNESUZQT3NQcklsQnBzck5YTWZ5MXpFUjh0S0pnVlBYUU9JLzc1TmtZclJ1?= =?utf-8?B?dHFUcEtuRHZaRFlabDBGc2VOaFJOMDVKcVovblJMTzQ5Q3l3blpyNHNQUGRw?= =?utf-8?B?WkIvVHJTcTNuS1g1ODBtN3NsQ3owU1B0TXh2QTdncW9qYThzcVpKOTQ4a0ZG?= =?utf-8?B?S2pKakpIbGxpRmZVdmY2eTA4aWFWalUvNTFUMkx5ZXFKQWFudGlZUnAwWXQv?= =?utf-8?B?ejZBWHNqQm9RdENzMjBURnpJdE9aL0hQQVhRblZSRHFqMHFOQVBsYmNHbTZn?= =?utf-8?B?U1V3anJjdm1BNzJFVnB4TzRLblU5aWxlbGgwSTh5YVRRUkJuR1BEaWlHWDVJ?= =?utf-8?B?MXN0RkhleTBjU2haVExxQXVNTkVQS01xQ3Mzdm9Vc0Z1cE9lQ1R1UE44OWZM?= =?utf-8?B?TDR2N1B2Zit1WjVLcHVIYktHaEV0OVVUMWNMWHd6QlpHNHMzMm0rY2pLRTl2?= =?utf-8?B?NVhGNWtUNnBvS2ZpSEJTTDVRRzVqalZmTVQ2ODFBMHpjaE5MTUJsZjBTOFFq?= =?utf-8?B?WFlIZGh0QUZTOFFSa2E1SW4wVElpb0lEVTNCQnVDVEQycWpHd05YaTN6U3NB?= =?utf-8?B?MTZ1dkpoNXAzUlRhZHVRMFNsQlZYZ0c5L0lzNmxxNXFsRGRvdnBaOEJGR051?= =?utf-8?B?K2o3RU4rRHNmcEZVNzJhSUE2Mko2bTFSaDMxVEdyNUdidjc1eTU5bXBTSktM?= =?utf-8?B?NWQxTmdUS0k5K3JxVjQ0ZGUxaUxXekh5MEUyZnh6akpaUmNyZUhwR29XdVNP?= =?utf-8?B?bkNqWllJUmlZSGxBQWRzcVROdlFCWlZxNWRDSk1zOXRwQnJGVDlqdmlhZ3pk?= =?utf-8?B?K1A0aGNSMXp3cTF0Yk02b0h2eElGQm03eTM5T0FqU085ZFRmTDJsUVU5ZjZp?= =?utf-8?B?ekJQWVFMTWYxclh1RVJ4RjkxbHZpN0xHQlUvbnd1ZE93d1h2WlEzV001SVpB?= =?utf-8?B?SUNqNDBpZE1RSE1SM2FUN0JxOHR2UmFhWVkxaXhSVFV0VDMzRytDT1pFNG4y?= =?utf-8?B?SHQvblA5ZVFaQjk1cWhHN1JQUXArL0ZSMWVYbEhQSGxvY1ZTcFZxdzhGK05H?= =?utf-8?B?cDZUSEl5VmRhS29qTkpwOFZ3OXUvdkZMSGdLd1JncElxdTVKM1cwWTdOdG9D?= =?utf-8?B?VjZ6aW5iWnBHOGRlUmw4RGZMYXRIV3JLTDBBV3JUcXNwbHZka3pTWWJnKzZR?= =?utf-8?B?R0lESVBoVy90NTMrUHh4RmZ2MDA2UUxNZTRtdEJsMUI4RUNrMjlpTXNLK1Z2?= =?utf-8?B?ajNKejUwMHpuM1Z4Vm1uY1VYOWQ5YzF3bk9wQW9uMkhDeGs4eW9saDJibi92?= =?utf-8?B?eldLUForUFNMR3RFRDArczR3ZVhEdnZvbWFqYXRieWJQYUVjMWhBdHV4U0hL?= =?utf-8?B?bFREU0wzYUIrU0pkSEJBQlY3cFlFTlc3bWI1KzVLTnNxUGo3L1pzNXMrcU5Q?= =?utf-8?B?ckpVdFVWNTdxVlVnSHZIODNnZk9BZFlGMlFpVENyTWRCMWJHNFFIR21MalhX?= =?utf-8?B?SDJqZnh2ei9GdFdDU1dZOTlhUmZ3Nm5CNzJtQ0g5eHFQWmJrRmlYVjc4NDh1?= =?utf-8?B?elc3c3p2Z251RHBSL1MxTXBSN3d5ZXY0MzFVYTNGdWNJS3NhMzNUVXp5R3Vx?= =?utf-8?Q?1llCgFcf8LiIQrMdNO8YdN+DWQEmJ5UIHjIvmWFIbsLn?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4792fccb-f32a-49aa-b057-08db20b0ee49 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7506.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2023 15:14:09.0008 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KXy14whCHfVOUY0p3jGeA9ljfPKOkdAvCc+/Q4a1Gmjpi2FyWrthJhi0hb7GBTQwNJ3G/Kkn4WlIbg+R34vwFyFMzXXoTVk5AFptUZ7NR4p4LdOUlktGqHRgR6fFoX23 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR01MB3735 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Abner, I'm not sure if I understand this module completely. This module is another IPMI solution? we will utilize either ManageabilityPkg (using IPMI protocol specified in the EDK2 repo) or IpmiFeaturePkg (using IpmiTransportProtocol). How do I use IpmiCommandLib (IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLib.inf) in combined with ManageabilityPkg? Another question, you don't use "Transport Protocol" and "Protocol Driver" in the KCS ManageabilityTransportLib you implement for reference because edk2 does not define a protocol for KCS , right? However, if I want to support other interfaces, I should build "ManageabilityTransportLib" using the protocol provided by the PI or UEFI specifications. Thanks, - Tinh On 3/8/2023 9:16 PM, Chang, Abner via groups.io wrote: > From: Abner Chang > > edk2 ManageabilityPkg is introduced to provide edk2 drivers > and libraries for industry platform management standards, > such as PLDM (Platform Level Data Model), MCTP (Management > Component Transfer Protocol), > IPMI (Intelligent Platform Management Interface) and others. > The framework of ManageabilityPkg is designed to flexibly > support the transport interfaces for above industry > standards, the transport interfaces such as KCS or I2C for > IPMI, PCI VDM (Vendor Defined Message), > I2C or KCS for MCTP, or the OEM proprietary transports. > Please check the Readme file for the design guidance: > https://github.com/changab/edk2-platforms/blob/Manageability_IPMI_upstream/Features/ManageabilityPkg/Readme.md > > In V2: Fix some issues on below files, > 1. Features/ManageabilityPkg/Library/Common/KcsCommon.c > 2. Features/ManageabilityPkg/Library/Dxe/ManageabilityTransportKcs.c > 3. Features/ManageabilityPkg/Universal/IpmiProtocol/Common/IpmiprotocolCommon.c > > In V1, we had implemented, > - KCS manageability transport library > - Manageability library helper library > - IPMI PEI/DXE/SMM protocol implementations > > Next upstream would be edk2 MCTP_PROTOCOL > implementation that also consumes the manageability > transport libraries. > > Signed-off-by: Abner Chang > Cc: Abdul Lateef Attar > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Isaac Oram > Cc: Nickle Wang > > Abner Chang (8): > ManageabilityPkg: Add Readme file > ManageabilityPkg: Initial package > ManageabilityPkg: Add NULL ManageabilityTransportLib > ManageabilityPkg: Add ManageabilityTransportHelperLib > ManageabilityPkg/ManageabilityTransportKcsLib > ManageabilityPkg: Implement Ipmi Protocol/Ppi > ManageabilityPkg: Add IpmiProtocol to Manageability Package > edk2-platforms: Maintainers.txt > > .../ManageabilityPkg/ManageabilityPkg.dec | 48 ++ > .../Include/Dsc/Manageability.dsc | 25 + > .../ManageabilityPkg/ManageabilityPkg.dsc | 45 ++ > .../BaseManageabilityTransportHelper.inf | 40 + > .../BaseManageabilityTransportNull.inf | 28 + > .../Dxe/DxeManageabilityTransportKcs.inf | 44 + > .../IpmiProtocol/Dxe/IpmiProtocolDxe.inf | 50 ++ > .../Universal/IpmiProtocol/Pei/IpmiPpiPei.inf | 51 ++ > .../IpmiProtocol/Smm/IpmiProtocolSmm.inf | 52 ++ > .../Library/ManageabilityTransportHelperLib.h | 93 +++ > .../Library/ManageabilityTransportIpmiLib.h | 24 + > .../Library/ManageabilityTransportLib.h | 335 ++++++++ > .../Common/ManageabilityTransportKcs.h | 106 +++ > .../IpmiProtocol/Common/IpmiProtocolCommon.h | 108 +++ > .../BaseManageabilityTransportHelper.c | 242 ++++++ > .../BaseManageabilityTransportNull.c | 64 ++ > .../Common/KcsCommon.c | 480 +++++++++++ > .../Dxe/ManageabilityTransportKcs.c | 384 +++++++++ > .../IpmiProtocol/Common/IpmiProtocolCommon.c | 247 ++++++ > .../Universal/IpmiProtocol/Dxe/IpmiProtocol.c | 177 +++++ > .../Universal/IpmiProtocol/Pei/IpmiPpi.c | 151 ++++ > .../Universal/IpmiProtocol/Smm/IpmiProtocol.c | 147 ++++ > Features/ManageabilityPkg/Readme.md | 177 +++++ > .../Media/ManageabilityDriverStack.svg | 752 ++++++++++++++++++ > .../BaseManageabilityTransportHelper.uni | 13 + > .../BaseManageabilityTransportNull.uni | 13 + > .../Dxe/ManageabilityTransportKcs.uni | 13 + > Maintainers.txt | 11 +- > 28 files changed, 3918 insertions(+), 2 deletions(-) > create mode 100644 Features/ManageabilityPkg/ManageabilityPkg.dec > create mode 100644 Features/ManageabilityPkg/Include/Dsc/Manageability.dsc > create mode 100644 Features/ManageabilityPkg/ManageabilityPkg.dsc > create mode 100644 Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf > create mode 100644 Features/ManageabilityPkg/Library/BaseManageabilityTransportNullLib/BaseManageabilityTransportNull.inf > create mode 100644 Features/ManageabilityPkg/Library/ManageabilityTransportKcsLib/Dxe/DxeManageabilityTransportKcs.inf > create mode 100644 Features/ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocolDxe.inf > create mode 100644 Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiPei.inf > create mode 100644 Features/ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocolSmm.inf > create mode 100644 Features/ManageabilityPkg/Include/Library/ManageabilityTransportHelperLib.h > create mode 100644 Features/ManageabilityPkg/Include/Library/ManageabilityTransportIpmiLib.h > create mode 100644 Features/ManageabilityPkg/Include/Library/ManageabilityTransportLib.h > create mode 100644 Features/ManageabilityPkg/Library/ManageabilityTransportKcsLib/Common/ManageabilityTransportKcs.h > create mode 100644 Features/ManageabilityPkg/Universal/IpmiProtocol/Common/IpmiProtocolCommon.h > create mode 100644 Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c > create mode 100644 Features/ManageabilityPkg/Library/BaseManageabilityTransportNullLib/BaseManageabilityTransportNull.c > create mode 100644 Features/ManageabilityPkg/Library/ManageabilityTransportKcsLib/Common/KcsCommon.c > create mode 100644 Features/ManageabilityPkg/Library/ManageabilityTransportKcsLib/Dxe/ManageabilityTransportKcs.c > create mode 100644 Features/ManageabilityPkg/Universal/IpmiProtocol/Common/IpmiProtocolCommon.c > create mode 100644 Features/ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocol.c > create mode 100644 Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpi.c > create mode 100644 Features/ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocol.c > create mode 100644 Features/ManageabilityPkg/Readme.md > create mode 100644 Features/ManageabilityPkg/Documents/Media/ManageabilityDriverStack.svg > create mode 100644 Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.uni > create mode 100644 Features/ManageabilityPkg/Library/BaseManageabilityTransportNullLib/BaseManageabilityTransportNull.uni > create mode 100644 Features/ManageabilityPkg/Library/ManageabilityTransportKcsLib/Dxe/ManageabilityTransportKcs.uni >