From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web08.601.1613772778980187273 for ; Fri, 19 Feb 2021 14:12:59 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=TsFzoyrJ; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613772778; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tXKGUuhjdsNrY6JS0WInkKs91oFFAKSswRdPaXtQZtc=; b=TsFzoyrJbsQGG5ye4sY0eqhLlTiog9RiI7Kh5oiSWxEC7ww168vTim09FFfsFWtN6CKyZE OGmSjB69NZb9LIFvJyC6spf61OsmuEB2Bj3AOlocvhOCfZzYyk3YebymNfE4HEghrkCs02 7ebUlu+SPICU/ONlV3uSCzFSJdmGixI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-126-dXoE3TX-MuCg2A6gqK29BA-1; Fri, 19 Feb 2021 17:12:53 -0500 X-MC-Unique: dXoE3TX-MuCg2A6gqK29BA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2F0C718449E6; Fri, 19 Feb 2021 22:12:52 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-87.ams2.redhat.com [10.36.113.87]) by smtp.corp.redhat.com (Postfix) with ESMTP id 04B0410016F6; Fri, 19 Feb 2021 22:12:50 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v7 00/10] support CPU hot-unplug To: devel@edk2.groups.io, ankur.a.arora@oracle.com Cc: imammedo@redhat.com, boris.ostrovsky@oracle.com References: <20210219090444.1332380-1-ankur.a.arora@oracle.com> From: "Laszlo Ersek" Message-ID: Date: Fri, 19 Feb 2021 23:12:50 +0100 MIME-Version: 1.0 In-Reply-To: <20210219090444.1332380-1-ankur.a.arora@oracle.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Ankur, On 02/19/21 10:04, Ankur Arora wrote: > Hi, > > This series adds OVMF support for CPU hot-unplug. > > QEMU secureboot hot-unplug logic corresponding to this is in upstream. > Also posted here: > https://lore.kernel.org/qemu-devel/20201207140739.3829993-1-imammedo@redhat.com/ > > Testing (with QEMU 5.2.50): > - Stable with randomized CPU plug/unplug (guest maxcpus=33,128) > - Synthetic tests with simultaneous multi CPU hot-unplug > > Also at: > github.com/terminus/edk2/ hot-unplug-v7 > > Changelog: > > v7: > - Address review comments from v6. > - Fix ejection bug where we were using APIC ID to do the ejection > rather than the Qemu Selector. > - Describes safety properties and ordering needed for concurrent > accesses to CPU_HOT_EJECT_DATA->QemuSelectorMap, and > CPU_HOT_EJECT_DATA->Handler, I plan to review this series early next week. This work is now going to miss the upcoming stable tag (soft feature freeze is 2021-02-22 00:00:00 UTC-8), but we can hopefully merge it early in the next development cycle. Meanwhile, based on my github notifications folder, I believe you may not have put this version of the series through CI -- if that's correct, then please consider doing it. Thanks! Laszlo > > v6: > - addresses v5 review comments. > URL: https://patchew.org/EDK2/20210129005950.467638-1-ankur.a.arora@oracle.com/ > > v5: > - fixes ECC errors (all but one in "OvmfPkg/CpuHotplugSmm: add > add Qemu Cpu Status helper"). > URL: https://patchew.org/EDK2/20210126064440.299596-1-ankur.a.arora@oracle.com/ > > v4: > - Gets rid of unnecessary UefiCpuPkg changes > URL: https://patchew.org/EDK2/20210118063457.358581-1-ankur.a.arora@oracle.com/ > > v3: > - Use a saner PCD based interface to share state between PiSmmCpuDxeSmm > and OvmfPkg/CpuHotplugSmm > - Cleaner split of the hot-unplug code > URL: https://patchew.org/EDK2/20210115074533.277448-1-ankur.a.arora@oracle.com/ > > v2: > - Do the ejection via SmmCpuFeaturesRendezvousExit() > URL: https://patchew.org/EDK2/20210107195515.106158-1-ankur.a.arora@oracle.com/ > > RFC: > URL: https://patchew.org/EDK2/20201208053432.2690694-1-ankur.a.arora@oracle.com/ > > Please review. > > Thanks > Ankur > > Ankur Arora (10): > OvmfPkg/CpuHotplugSmm: refactor hotplug logic > OvmfPkg/CpuHotplugSmm: collect hot-unplug events > OvmfPkg/CpuHotplugSmm: add Qemu Cpu Status helper > OvmfPkg/CpuHotplugSmm: introduce UnplugCpus() > OvmfPkg/CpuHotplugSmm: define CPU_HOT_EJECT_DATA > OvmfPkg/SmmCpuFeaturesLib: init CPU ejection state > OvmfPkg/SmmCpuFeaturesLib: call CPU hot-eject handler > OvmfPkg/CpuHotplugSmm: add EjectCpu() > OvmfPkg/CpuHotplugSmm: do actual CPU hot-eject > OvmfPkg/SmmControl2Dxe: negotiate CPU hot-unplug > > OvmfPkg/OvmfPkg.dec | 4 + > OvmfPkg/CpuHotplugSmm/CpuHotplugSmm.inf | 2 + > .../SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf | 4 + > OvmfPkg/CpuHotplugSmm/QemuCpuhp.h | 7 + > OvmfPkg/Include/IndustryStandard/QemuCpuHotplug.h | 2 + > OvmfPkg/Include/Pcd/CpuHotEjectData.h | 52 ++ > OvmfPkg/CpuHotplugSmm/CpuHotplug.c | 578 +++++++++++++++++---- > OvmfPkg/CpuHotplugSmm/QemuCpuhp.c | 106 +++- > .../Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 136 +++++ > OvmfPkg/SmmControl2Dxe/SmiFeatures.c | 18 +- > 10 files changed, 789 insertions(+), 120 deletions(-) > create mode 100644 OvmfPkg/Include/Pcd/CpuHotEjectData.h >