From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E674D7803CD for ; Sat, 28 Oct 2023 11:54:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=+R//3NjCg4JDIvOV+zF0x5wQaP883UeH///6DGJAx4o=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698494057; v=1; b=CZXqAcHLM3eccSR5lTZ/0Ps0QrO70USILfyozW6w5HaAB3UrgGE7Yb7dkFI9ow3o9Ct33BHm 5BkQ8Qryzzd9kCpDgngAw6kQHCwqCkGpmYEkYiio/9np4INS7EXU5Va8no+dhQqiLUJMtXsB5iV PjG/l20xhxoXoyLB1SCKayp8= X-Received: by 127.0.0.2 with SMTP id oJaCYY7687511xZSgxkz3N2U; Sat, 28 Oct 2023 04:54:17 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.16486.1698494056924270348 for ; Sat, 28 Oct 2023 04:54:17 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-654-LrCcliATPTSo2Un_MZDrZg-1; Sat, 28 Oct 2023 07:54:09 -0400 X-MC-Unique: LrCcliATPTSo2Un_MZDrZg-1 X-Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8CA6E29AA2CB; Sat, 28 Oct 2023 11:54:09 +0000 (UTC) X-Received: from [10.39.192.70] (unknown [10.39.192.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 24CA82026D4C; Sat, 28 Oct 2023 11:54:09 +0000 (UTC) Message-ID: Date: Sat, 28 Oct 2023 13:54:07 +0200 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH] Remove checking Smm Rev ID in AMD Save State lib when Reading Save State Register EFI_MM_SAVE_STATE_REGISTER_IO To: devel@edk2.groups.io, hsienchieh.lin@amd.com References: <20231027053619.1609-1-hsienchieh.lin@amd.com> From: "Laszlo Ersek" In-Reply-To: <20231027053619.1609-1-hsienchieh.lin@amd.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 3eZ4SnpIpRXO8qUGm04A8Ae2x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=CZXqAcHL; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 10/27/23 07:36, Jacque Lin via groups.io wrote: > --- > UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c | 13 ------------- > 1 file changed, 13 deletions(-) Why? (The commit message is empty.) Laszlo >=20 > diff --git a/UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c b/UefiCpu= Pkg/Library/MmSaveStateLib/AmdMmSaveState.c > index 3315a6cc44..c4bf6ad4bb 100644 > --- a/UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c > +++ b/UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c > @@ -102,7 +102,6 @@ MmSaveStateReadRegister ( > OUT VOID *Buffer >=20 > ) >=20 > { >=20 > - UINT32 SmmRevId; >=20 > EFI_MM_SAVE_STATE_IO_INFO *IoInfo; >=20 > AMD_SMRAM_SAVE_STATE_MAP *CpuSaveState; >=20 > UINT8 DataWidth; >=20 > @@ -124,18 +123,6 @@ MmSaveStateReadRegister ( > =20 >=20 > // Check for special EFI_MM_SAVE_STATE_REGISTER_IO >=20 > if (Register =3D=3D EFI_MM_SAVE_STATE_REGISTER_IO) { >=20 > - // >=20 > - // Get SMM Revision ID >=20 > - // >=20 > - MmSaveStateReadRegisterByIndex (CpuIndex, AMD_MM_SAVE_STATE_REGISTER= _SMMREVID_INDEX, sizeof (SmmRevId), &SmmRevId); >=20 > - >=20 > - // >=20 > - // See if the CPU supports the IOMisc register in the save state >=20 > - // >=20 > - if (SmmRevId < AMD_SMM_MIN_REV_ID_X64) { >=20 > - return EFI_NOT_FOUND; >=20 > - } >=20 > - >=20 > // Check if IO Restart Dword [IO Trap] is valid or not using bit 1. >=20 > if (!(CpuSaveState->x64.IO_DWord & 0x02u)) { >=20 > return EFI_NOT_FOUND; >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110244): https://edk2.groups.io/g/devel/message/110244 Mute This Topic: https://groups.io/mt/102219140/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-