public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, ardb@kernel.org
Cc: quic_llindhol@quicinc.com, rebecca@quicinc.com
Subject: Re: [edk2-devel] [PATCH edk2-platforms] Platform/RPi4: Add EFI_MP_SERVICES_PROTOCOL support
Date: Fri, 6 Jan 2023 07:52:37 +0100	[thread overview]
Message-ID: <be243cad-dda3-8ca8-d403-13249aa13313@redhat.com> (raw)
In-Reply-To: <20230105170155.1444144-1-ardb@kernel.org>

On 1/5/23 18:01, Ard Biesheuvel wrote:
> Fix the ARM_MPCORE_INFO table and incorporate the DXE driver and test
> app to the build so that EFI_MP_SERVICES_PROTOCOL can be used and tested
> on Raspberry Pi 4. Note that the test app is not added to the image - it
> can be taken from the build directory and executed from the UEFI shell.
> 
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
>  Platform/RaspberryPi/RPi4/RPi4.dsc                     | 3 +++
>  Platform/RaspberryPi/RPi4/RPi4.fdf                     | 1 +
>  Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c | 8 ++++----
>  3 files changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
> index 8ba0ca61851e..4b2b6d1e4b97 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> @@ -795,3 +795,6 @@ [Components.common]
>        gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
>    }
>  !endif
> +
> +  ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.inf
> +  MdeModulePkg/Application/MpServicesTest/MpServicesTest.inf
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.fdf b/Platform/RaspberryPi/RPi4/RPi4.fdf
> index 0c782d2f3553..816927761513 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.fdf
> +++ b/Platform/RaspberryPi/RPi4/RPi4.fdf
> @@ -198,6 +198,7 @@ [FV.FvMain]
>    INF EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
>    INF EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf
>    INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
> +  INF ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.inf
>  
>    #
>    # Multiple Console IO support
> diff --git a/Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c b/Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c
> index f032f3c79238..0b0943431889 100644
> --- a/Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c
> +++ b/Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c
> @@ -51,10 +51,10 @@ ArmPlatformInitializeSystemMemory (
>  }
>  
>  STATIC ARM_CORE_INFO mRpi3InfoTable[] = {
> -  { 0x0, 0x0, },             // Cluster 0, Core 0
> -  { 0x0, 0x1, },             // Cluster 0, Core 1
> -  { 0x0, 0x2, },             // Cluster 0, Core 2
> -  { 0x0, 0x3, },             // Cluster 0, Core 3
> +  { 0x0, }, // Cluster 0, Core 0
> +  { 0x1, }, // Cluster 0, Core 1
> +  { 0x2, }, // Cluster 0, Core 2
> +  { 0x3, }, // Cluster 0, Core 3
>  };
>  
>  STATIC

Acked-by: Laszlo Ersek <lersek@redhat.com>


  reply	other threads:[~2023-01-06  6:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-05 17:01 [PATCH edk2-platforms] Platform/RPi4: Add EFI_MP_SERVICES_PROTOCOL support Ard Biesheuvel
2023-01-06  6:52 ` Laszlo Ersek [this message]
2023-01-06 17:39 ` quic_rcran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be243cad-dda3-8ca8-d403-13249aa13313@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox