From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.8462.1672987962006210530 for ; Thu, 05 Jan 2023 22:52:42 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=C6BpHLVP; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672987961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0A6F9V63zZ6H2KZk22ksLo89bmNTwpc8H2STQSZk1jk=; b=C6BpHLVPaBSI9nu5d0cV/UCDvHwInxhmK1kellHapL9Qp5o3RzHWCp0/1RTIRQ/qeHeIJN /Tst10UwgXxG+uUwXj72pkh76eI3t6q/X9dcBwaBFeRpeYwxHJWNbBwGVztBSAVp/+2vZ7 joNt/uuRXVbaDFUeId1Wd0WOw0z/omk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-654-ef4oRjh7P56dxqTDXEU4Yg-1; Fri, 06 Jan 2023 01:52:39 -0500 X-MC-Unique: ef4oRjh7P56dxqTDXEU4Yg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 417A4101A521; Fri, 6 Jan 2023 06:52:39 +0000 (UTC) Received: from [10.39.192.26] (unknown [10.39.192.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 73BD22166B30; Fri, 6 Jan 2023 06:52:38 +0000 (UTC) Message-ID: Date: Fri, 6 Jan 2023 07:52:37 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH edk2-platforms] Platform/RPi4: Add EFI_MP_SERVICES_PROTOCOL support To: devel@edk2.groups.io, ardb@kernel.org Cc: quic_llindhol@quicinc.com, rebecca@quicinc.com References: <20230105170155.1444144-1-ardb@kernel.org> From: "Laszlo Ersek" In-Reply-To: <20230105170155.1444144-1-ardb@kernel.org> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/5/23 18:01, Ard Biesheuvel wrote: > Fix the ARM_MPCORE_INFO table and incorporate the DXE driver and test > app to the build so that EFI_MP_SERVICES_PROTOCOL can be used and tested > on Raspberry Pi 4. Note that the test app is not added to the image - it > can be taken from the build directory and executed from the UEFI shell. > > Signed-off-by: Ard Biesheuvel > --- > Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +++ > Platform/RaspberryPi/RPi4/RPi4.fdf | 1 + > Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c | 8 ++++---- > 3 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc > index 8ba0ca61851e..4b2b6d1e4b97 100644 > --- a/Platform/RaspberryPi/RPi4/RPi4.dsc > +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc > @@ -795,3 +795,6 @@ [Components.common] > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > } > !endif > + > + ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.inf > + MdeModulePkg/Application/MpServicesTest/MpServicesTest.inf > diff --git a/Platform/RaspberryPi/RPi4/RPi4.fdf b/Platform/RaspberryPi/RPi4/RPi4.fdf > index 0c782d2f3553..816927761513 100644 > --- a/Platform/RaspberryPi/RPi4/RPi4.fdf > +++ b/Platform/RaspberryPi/RPi4/RPi4.fdf > @@ -198,6 +198,7 @@ [FV.FvMain] > INF EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf > INF EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf > INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf > + INF ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.inf > > # > # Multiple Console IO support > diff --git a/Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c b/Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c > index f032f3c79238..0b0943431889 100644 > --- a/Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c > +++ b/Platform/RaspberryPi/Library/PlatformLib/RaspberryPi.c > @@ -51,10 +51,10 @@ ArmPlatformInitializeSystemMemory ( > } > > STATIC ARM_CORE_INFO mRpi3InfoTable[] = { > - { 0x0, 0x0, }, // Cluster 0, Core 0 > - { 0x0, 0x1, }, // Cluster 0, Core 1 > - { 0x0, 0x2, }, // Cluster 0, Core 2 > - { 0x0, 0x3, }, // Cluster 0, Core 3 > + { 0x0, }, // Cluster 0, Core 0 > + { 0x1, }, // Cluster 0, Core 1 > + { 0x2, }, // Cluster 0, Core 2 > + { 0x3, }, // Cluster 0, Core 3 > }; > > STATIC Acked-by: Laszlo Ersek