From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6476D74004D for ; Tue, 30 Jan 2024 16:32:22 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=IJglPn3m57VGgz4ZzzTHhbxpQN9cAk2BJLFGWo96CuE=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1706632341; v=1; b=lt7t/NRv6tROT9MMSpT+9W3LVAej4Rs3579rSDR2antWG0hGNq5p7DuKcX9xEgRZrAun92vn 7iJ5VhXdm0URGVqbrICJYXzNRZtPDNpRmWneAiZ5xV26/58k4IaQjpgC48disESmMfTjrMFGAEp jcyAwxm12ZiuXR76nw1qnmjk= X-Received: by 127.0.0.2 with SMTP id UUQiYY7687511xA5jBplMN5s; Tue, 30 Jan 2024 08:32:21 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by mx.groups.io with SMTP id smtpd.web10.14236.1706604823877458901 for ; Tue, 30 Jan 2024 00:53:44 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10968"; a="10320887" X-IronPort-AV: E=Sophos;i="6.05,707,1701158400"; d="scan'208";a="10320887" X-Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2024 00:53:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,707,1701158400"; d="scan'208";a="3603631" X-Received: from qingyush-mobl.ccr.corp.intel.com ([10.238.9.167]) by fmviesa005.fm.intel.com with ESMTP; 30 Jan 2024 00:53:40 -0800 From: Qingyu To: michael.d.kinney@intel.com, devel@edk2.groups.io Cc: Qingyu Shang , Tan, Ming , Li, Yi1 , Liming Gao , Zhiguang Liu Subject: [edk2-devel] [PATCH v3 1/1] MdePkg: Update ReceiveData and SendData function description Date: Tue, 30 Jan 2024 16:53:13 +0800 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,qingyu.shang@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: VWGXwsCfKdLxUJ4C6CX0Pzurx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="lt7t/NRv"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io From: Qingyu Shang Refer to Uefi spec 2.10 section 13.14, update the parameter 'MediaId' description for EFI_STORAGE_SECURITY_COMMAND_PROTOCOL function ReceiveData and SendData. Cc: Tan, Ming Cc: Li, Yi1 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Qingyu Shang --- MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c | 8 ++++++-- MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h | 8 ++++++-- .../Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c | 8 ++++++-- .../Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h | 8 ++++++-- MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 8 ++++++-- MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h | 8 ++++++-- MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c | 12 +++++++++--- MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h | 12 +++++++++--- MdePkg/Include/Protocol/StorageSecurityCommand.h | 8 ++++++-- SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c | 8 ++++++-- 10 files changed, 66 insertions(+), 22 deletions(-) diff --git a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c index a729c087ff5a..67c6389bb8b3 100644 --- a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c +++ b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.c @@ -1483,7 +1483,9 @@ AtaDiskInfoWhichIde ( function shall return EFI_DEVICE_ERROR. @param This Indicates a pointer to the calling context. - @param MediaId ID of the medium to receive data from. + @param MediaId ID of the medium to receive data from. If there is no + block IO protocol supported by the physical device, the + value of MediaId is undefined. @param Timeout The timeout, in 100ns units, to use for the execution of the security protocol command. A Timeout value of 0 means that this function will wait indefinitely for the @@ -1600,7 +1602,9 @@ AtaStorageSecurityReceiveData ( shall return EFI_DEVICE_ERROR. @param This Indicates a pointer to the calling context. - @param MediaId ID of the medium to receive data from. + @param MediaId ID of the medium to receive data from. If there is no + block IO protocol supported by the physical device, the + value of MediaId is undefined. @param Timeout The timeout, in 100ns units, to use for the execution of the security protocol command. A Timeout value of 0 means that this function will wait indefinitely for the diff --git a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h index 6bc345f7e777..8906947e28b3 100644 --- a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h +++ b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBus.h @@ -927,7 +927,9 @@ AtaDiskInfoWhichIde ( function shall return EFI_DEVICE_ERROR. @param This Indicates a pointer to the calling context. - @param MediaId ID of the medium to receive data from. + @param MediaId ID of the medium to receive data from. If there is no + block IO protocol supported by the physical device, the + value of MediaId is undefined. @param Timeout The timeout, in 100ns units, to use for the execution of the security protocol command. A Timeout value of 0 means that this function will wait indefinitely for the @@ -1007,7 +1009,9 @@ AtaStorageSecurityReceiveData ( shall return EFI_DEVICE_ERROR. @param This Indicates a pointer to the calling context. - @param MediaId ID of the medium to receive data from. + @param MediaId ID of the medium to receive data from. If there is no + block IO protocol supported by the physical device, the + value of MediaId is undefined. @param Timeout The timeout, in 100ns units, to use for the execution of the security protocol command. A Timeout value of 0 means that this function will wait indefinitely for the diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c index b6ed7f7031b3..e0a85c1cb34e 100644 --- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c +++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.c @@ -1699,7 +1699,9 @@ TrustTransferNvmeDevice ( function shall return EFI_DEVICE_ERROR. @param This Indicates a pointer to the calling context. - @param MediaId ID of the medium to receive data from. + @param MediaId ID of the medium to receive data from. If there is no + block IO protocol supported by the physical device, the + value of MediaId is undefined. @param Timeout The timeout, in 100ns units, to use for the execution of the security protocol command. A Timeout value of 0 means that this function will wait indefinitely for the @@ -1812,7 +1814,9 @@ NvmeStorageSecurityReceiveData ( shall return EFI_DEVICE_ERROR. @param This Indicates a pointer to the calling context. - @param MediaId ID of the medium to receive data from. + @param MediaId ID of the medium to receive data from. If there is no + block IO protocol supported by the physical device, the + value of MediaId is undefined. @param Timeout The timeout, in 100ns units, to use for the execution of the security protocol command. A Timeout value of 0 means that this function will wait indefinitely for the diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h index 8cad15efd33a..5547e057e77a 100644 --- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h +++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressBlockIo.h @@ -289,7 +289,9 @@ NvmeBlockIoFlushBlocksEx ( function shall return EFI_DEVICE_ERROR. @param This Indicates a pointer to the calling context. - @param MediaId ID of the medium to receive data from. + @param MediaId ID of the medium to receive data from. If there is no + block IO protocol supported by the physical device, the + value of MediaId is undefined. @param Timeout The timeout, in 100ns units, to use for the execution of the security protocol command. A Timeout value of 0 means that this function will wait indefinitely for the @@ -369,7 +371,9 @@ NvmeStorageSecurityReceiveData ( shall return EFI_DEVICE_ERROR. @param This Indicates a pointer to the calling context. - @param MediaId ID of the medium to receive data from. + @param MediaId ID of the medium to receive data from. If there is no + block IO protocol supported by the physical device, the + value of MediaId is undefined. @param Timeout The timeout, in 100ns units, to use for the execution of the security protocol command. A Timeout value of 0 means that this function will wait indefinitely for the diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c index 670f70caf41f..e79110c14e11 100644 --- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c +++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c @@ -1897,7 +1897,9 @@ Done: function shall return EFI_DEVICE_ERROR. @param This Indicates a pointer to the calling context. - @param MediaId ID of the medium to receive data from. + @param MediaId ID of the medium to receive data from. If there is no + block IO protocol supported by the physical device, the + value of MediaId is undefined. @param Timeout The timeout, in 100ns units, to use for the execution of the security protocol command. A Timeout value of 0 means that this function will wait indefinitely for the @@ -2119,7 +2121,9 @@ Done: shall return EFI_DEVICE_ERROR. @param This Indicates a pointer to the calling context. - @param MediaId ID of the medium to receive data from. + @param MediaId ID of the medium to receive data from. If there is no + block IO protocol supported by the physical device, the + value of MediaId is undefined. @param Timeout The timeout, in 100ns units, to use for the execution of the security protocol command. A Timeout value of 0 means that this function will wait indefinitely for the diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h index 5a25b55c4952..49a00403695f 100644 --- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h +++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h @@ -677,7 +677,9 @@ ScsiDiskEraseBlocks ( function shall return EFI_DEVICE_ERROR. @param This Indicates a pointer to the calling context. - @param MediaId ID of the medium to receive data from. + @param MediaId ID of the medium to receive data from. If there is no + block IO protocol supported by the physical device, the + value of MediaId is undefined. @param Timeout The timeout, in 100ns units, to use for the execution of the security protocol command. A Timeout value of 0 means that this function will wait indefinitely for the @@ -751,7 +753,9 @@ ScsiDiskReceiveData ( shall return EFI_DEVICE_ERROR. @param This Indicates a pointer to the calling context. - @param MediaId ID of the medium to receive data from. + @param MediaId ID of the medium to receive data from. If there is no + block IO protocol supported by the physical device, the + value of MediaId is undefined. @param Timeout The timeout, in 100ns units, to use for the execution of the security protocol command. A Timeout value of 0 means that this function will wait indefinitely for the diff --git a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c index 39b7c7ce6ef1..61fa740be505 100644 --- a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c +++ b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c @@ -1267,7 +1267,9 @@ EmmcFlushBlocksEx ( function shall return EFI_DEVICE_ERROR. @param[in] This Indicates a pointer to the calling context. - @param[in] MediaId ID of the medium to receive data from. + @param[in] MediaId ID of the medium to receive data from. If there is no + block IO protocol supported by the physical device, the + value of MediaId is undefined. @param[in] Timeout The timeout, in 100ns units, to use for the execution of the security protocol command. A Timeout value of 0 means that this function will wait indefinitely for the @@ -1454,7 +1456,9 @@ EmmcSecurityProtocolInOut ( function shall return EFI_DEVICE_ERROR. @param This Indicates a pointer to the calling context. - @param MediaId ID of the medium to receive data from. + @param MediaId ID of the medium to receive data from. If there is no + block IO protocol supported by the physical device, the + value of MediaId is undefined. @param Timeout The timeout, in 100ns units, to use for the execution of the security protocol command. A Timeout value of 0 means that this function will wait indefinitely for the @@ -1555,7 +1559,9 @@ EmmcSecurityProtocolIn ( shall return EFI_DEVICE_ERROR. @param This Indicates a pointer to the calling context. - @param MediaId ID of the medium to receive data from. + @param MediaId ID of the medium to receive data from. If there is no + block IO protocol supported by the physical device, the + value of MediaId is undefined. @param Timeout The timeout, in 100ns units, to use for the execution of the security protocol command. A Timeout value of 0 means that this function will wait indefinitely for the diff --git a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h index 2568f0359df3..8c7e5d2675ff 100644 --- a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h +++ b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h @@ -250,7 +250,9 @@ EmmcFlushBlocksEx ( function shall return EFI_DEVICE_ERROR. @param[in] This Indicates a pointer to the calling context. - @param[in] MediaId ID of the medium to receive data from. + @param[in] MediaId ID of the medium to receive data from. If there is no + block IO protocol supported by the physical device, the + value of MediaId is undefined. @param[in] Timeout The timeout, in 100ns units, to use for the execution of the security protocol command. A Timeout value of 0 means that this function will wait indefinitely for the @@ -337,7 +339,9 @@ EmmcSecurityProtocolInOut ( function shall return EFI_DEVICE_ERROR. @param This Indicates a pointer to the calling context. - @param MediaId ID of the medium to receive data from. + @param MediaId ID of the medium to receive data from. If there is no + block IO protocol supported by the physical device, the + value of MediaId is undefined. @param Timeout The timeout, in 100ns units, to use for the execution of the security protocol command. A Timeout value of 0 means that this function will wait indefinitely for the @@ -417,7 +421,9 @@ EmmcSecurityProtocolIn ( shall return EFI_DEVICE_ERROR. @param This Indicates a pointer to the calling context. - @param MediaId ID of the medium to receive data from. + @param MediaId ID of the medium to receive data from. If there is no + block IO protocol supported by the physical device, the + value of MediaId is undefined. @param Timeout The timeout, in 100ns units, to use for the execution of the security protocol command. A Timeout value of 0 means that this function will wait indefinitely for the diff --git a/MdePkg/Include/Protocol/StorageSecurityCommand.h b/MdePkg/Include/Protocol/StorageSecurityCommand.h index 810af59b85c3..206ae79aff8d 100644 --- a/MdePkg/Include/Protocol/StorageSecurityCommand.h +++ b/MdePkg/Include/Protocol/StorageSecurityCommand.h @@ -59,7 +59,9 @@ typedef struct _EFI_STORAGE_SECURITY_COMMAND_PROTOCOL EFI_STORAGE_SECURITY_COMMA function shall return EFI_DEVICE_ERROR. @param This Indicates a pointer to the calling context. - @param MediaId ID of the medium to receive data from. + @param MediaId ID of the medium to receive data from. If there is no + block IO protocol supported by the physical device, the + value of MediaId is undefined. @param Timeout The timeout, in 100ns units, to use for the execution of the security protocol command. A Timeout value of 0 means that this function will wait indefinitely for the @@ -138,7 +140,9 @@ EFI_STATUS shall return EFI_DEVICE_ERROR. @param This Indicates a pointer to the calling context. - @param MediaId ID of the medium to receive data from. + @param MediaId ID of the medium to receive data from. If there is no + block IO protocol supported by the physical device, the + value of MediaId is undefined. @param Timeout The timeout, in 100ns units, to use for the execution of the security protocol command. A Timeout value of 0 means that this function will wait indefinitely for the diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c b/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c index 0fb6b1bf41d5..1ee55105e435 100644 --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c @@ -49,7 +49,9 @@ EFI_GUID mOpalDeviceLockBoxGuid = OPAL_DEVICE_LOCKBOX_GUID; function shall return EFI_DEVICE_ERROR. @param This Indicates a pointer to the calling context. - @param MediaId ID of the medium to receive data from. + @param MediaId ID of the medium to receive data from. If there is no + block IO protocol supported by the physical device, the + value of MediaId is undefined. @param Timeout The timeout, in 100ns units, to use for the execution of the security protocol command. A Timeout value of 0 means that this function will wait indefinitely for the @@ -148,7 +150,9 @@ SecurityReceiveData ( shall return EFI_DEVICE_ERROR. @param This Indicates a pointer to the calling context. - @param MediaId ID of the medium to receive data from. + @param MediaId ID of the medium to receive data from. If there is no + block IO protocol supported by the physical device, the + value of MediaId is undefined. @param Timeout The timeout, in 100ns units, to use for the execution of the security protocol command. A Timeout value of 0 means that this function will wait indefinitely for the -- 2.39.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114800): https://edk2.groups.io/g/devel/message/114800 Mute This Topic: https://groups.io/mt/104056979/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-