public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Kun Qin" <kuqin12@gmail.com>
To: devel@edk2.groups.io, zhiguang.liu@intel.com
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>,
	Chasel Chiu <chasel.chiu@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Eric Dong <eric.dong@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms] Intel/MinPlatformPkg: resolve MmUnblockMemoryLib
Date: Tue, 16 Mar 2021 02:18:06 -0700	[thread overview]
Message-ID: <be401976-a6bb-005a-b3cc-3760acfebac1@gmail.com> (raw)
In-Reply-To: <20210316090607.858-1-zhiguang.liu@intel.com>

Hi Zhiguang,

I have already sent this patch series to resolve dependencies in 
edk2-platform (although the change is slightly different):
https://edk2.groups.io/g/devel/message/72645

Specifically:
https://edk2.groups.io/g/devel/message/72646

Could you please let me know if the change above resolves the dependency 
issue for you?

The patch series have 2 other patches not being reviewed yet. I plan to 
send out another round tomorrow to include reviewed-by tags. But please 
let me know if you prefer your change below to check in first, I will 
just drop my patch #1 when sending v2.

Thanks,
Kun

On 03/16/2021 02:06, Zhiguang Liu wrote:
> The below Edk2 patch makes VariableSmmRuntimeDxe begin to consume MmUnblockMemoryLib.
> It cause multiple platforms build failure.
>      f463dbadede138dc96a66dae6f361c54f0b3093c
>      MdeModulePkg: VariableSmmRuntimeDxe: Added request unblock memory interface
> 
> This change added NULL MmUnblockMemoryLib instance in MinPlatformPkg dsc include files
> 
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> 
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> ---
>   Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc
> index fa9098d525..ee91dd8bd6 100644
> --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc
> +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc
> @@ -116,6 +116,7 @@
>   !endif
> 
>     BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
> 
>     VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf
> 
> +  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
> 
>   
> 
>   [LibraryClasses.common.UEFI_DRIVER]
> 
>     Tpm2DeviceLib|SecurityPkg/Library/Tpm2DeviceLibTcg2/Tpm2DeviceLibTcg2.inf
> 

  reply	other threads:[~2021-03-16  9:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-16  9:06 [edk2-platforms] Intel/MinPlatformPkg: resolve MmUnblockMemoryLib Zhiguang Liu
2021-03-16  9:18 ` Kun Qin [this message]
2021-03-16 13:29   ` [edk2-devel] " Zhiguang Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be401976-a6bb-005a-b3cc-3760acfebac1@gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox