From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mx.groups.io with SMTP id smtpd.web08.5912.1615886287079574844 for ; Tue, 16 Mar 2021 02:18:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Nb7Vihwy; spf=pass (domain: gmail.com, ip: 209.85.216.43, mailfrom: kuqin12@gmail.com) Received: by mail-pj1-f43.google.com with SMTP id nh23-20020a17090b3657b02900c0d5e235a8so1115678pjb.0 for ; Tue, 16 Mar 2021 02:18:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OtRYCrkf6KsCpyUz4xRMnpQDXu9NG+9qOOh1WIdMgUw=; b=Nb7VihwyLRvs0Se2beifAtyzSTu0Z6prOLW2aW+hhqIQvGwRLD2e+Fd8l/lry6Y7dW 05cITD6yNjP7DGBrIqylOtIGH4hWZps1ETVc5WP20OCyNabKKomDUrnhI3YhFGoUKbe0 LBbX9w7HAi6rhZ1vqJFYb4gGtcyYNgGCp5zFoFx0Bj1c68TYkasnfY0eUgtnikLmTA6c XT3LzfDF9sGv/hMeLUbGwUhn/XO1A32M0knqgri5vjF8DwPPySTgTsHAt8GWmrJLRqpy 5+8dJjaLv1rh5ikaciPSpnm/BmCJsZILZsCaXKKG07M2ynTomRrvsBqTc9SCtoeWSVww ojwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OtRYCrkf6KsCpyUz4xRMnpQDXu9NG+9qOOh1WIdMgUw=; b=PcU0VP+R63mCJKFpF+GAuKEOvYUQZ02FDzyn/UZ2Se+6Hvwr8FkF110DfGrC5/u5+Y WvgQqxJYLEDqb2Z35A/8/6RgqsS11IYI42KBTkOLEm8P16EwmPAw/3cRofWE4ix+m91y eH49T8kcWBTItLC87izkZseQKXx1id2aKHq7KOQsuQL8XZqvsrGfCENDXzw5qOdzUA6l WuN3IfQ8YKfLz950/Ahj/6UnHPtU4/YPgh9mqIR1Q/zRT64qNP4DOu5boFjVdyrQtb4W 0b0NklFZyU9jh88RmySsSucKxbyULphGlpzNmPKOoPZyBSbPA90/C2mXtXjRRzhW0/v0 ZVLQ== X-Gm-Message-State: AOAM5312175nV5tXKqW5TvyzKzhhGqKvWRl9HK+I2faZE8UmnCLcWZgV xj2prypmvahZNyQkBs8nuoY= X-Google-Smtp-Source: ABdhPJzhYo1pl/wBwr/rt1KrmL0CXjZBkkSX0hlwjrjNlXEI2kTEb7IjM3LfTsQbJO1Wpzda1JVo8A== X-Received: by 2002:a17:90a:bf84:: with SMTP id d4mr3777552pjs.118.1615886286512; Tue, 16 Mar 2021 02:18:06 -0700 (PDT) Return-Path: Received: from [192.168.50.18] ([50.35.88.161]) by smtp.gmail.com with ESMTPSA id k3sm15103078pgq.21.2021.03.16.02.18.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Mar 2021 02:18:06 -0700 (PDT) Subject: Re: [edk2-devel] [edk2-platforms] Intel/MinPlatformPkg: resolve MmUnblockMemoryLib To: devel@edk2.groups.io, zhiguang.liu@intel.com Cc: Nate DeSimone , Chasel Chiu , Liming Gao , Eric Dong References: <20210316090607.858-1-zhiguang.liu@intel.com> From: "Kun Qin" Message-ID: Date: Tue, 16 Mar 2021 02:18:06 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210316090607.858-1-zhiguang.liu@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Zhiguang, I have already sent this patch series to resolve dependencies in edk2-platform (although the change is slightly different): https://edk2.groups.io/g/devel/message/72645 Specifically: https://edk2.groups.io/g/devel/message/72646 Could you please let me know if the change above resolves the dependency issue for you? The patch series have 2 other patches not being reviewed yet. I plan to send out another round tomorrow to include reviewed-by tags. But please let me know if you prefer your change below to check in first, I will just drop my patch #1 when sending v2. Thanks, Kun On 03/16/2021 02:06, Zhiguang Liu wrote: > The below Edk2 patch makes VariableSmmRuntimeDxe begin to consume MmUnblockMemoryLib. > It cause multiple platforms build failure. > f463dbadede138dc96a66dae6f361c54f0b3093c > MdeModulePkg: VariableSmmRuntimeDxe: Added request unblock memory interface > > This change added NULL MmUnblockMemoryLib instance in MinPlatformPkg dsc include files > > Cc: Nate DeSimone > Cc: Chasel Chiu > Cc: Liming Gao > Cc: Eric Dong > > Signed-off-by: Zhiguang Liu > --- > Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc > index fa9098d525..ee91dd8bd6 100644 > --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc > +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc > @@ -116,6 +116,7 @@ > !endif > > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf > > + MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf > > > > [LibraryClasses.common.UEFI_DRIVER] > > Tpm2DeviceLib|SecurityPkg/Library/Tpm2DeviceLibTcg2/Tpm2DeviceLibTcg2.inf >