Re: [Patch 5/5] UefiCpuPkg: Remove X86 ASM and S files

[Laszlo Ersek <lersek@redhat.com>]

On 05/13/18 16:31, Liming Gao wrote:
> NASM has replaced ASM and S files.
> Rmove ASM from all modules.
> Remove S files from the drivers only.
> After NASM is updated, S files can be removed from Library.

The patch looks good to me. I suggest a few commit message updates:

(1) If I remember correctly, we have a TianoCore BZ for this (also for
the NASM update). Can you please reference those here?

(2) There's a typo in "Rmove".

(3) Technically, a number of *.asm files remain under UefiCpuPkg, namely
under "ResetVector/Vtf0". None of those are built stand-alone -- they
are all included by "Vtf0.nasmb", and "Vtf0.inf" only references
"Vtf0.nasmb". So technically speaking these *.asm files are *.nasm[b]
files. I suggest we add a note about this fact, or else file a TianoCore
BZ about renaming the Vtf0 ASM files.

With the commit message updates:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Laszlo