From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 684412112A2AE for ; Sun, 13 May 2018 11:40:05 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CFAAC4075757; Sun, 13 May 2018 18:40:04 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-87.rdu2.redhat.com [10.10.120.87]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4481411166FE; Sun, 13 May 2018 18:40:04 +0000 (UTC) To: Liming Gao References: <1526221902-9060-1-git-send-email-liming.gao@intel.com> <1526221902-9060-7-git-send-email-liming.gao@intel.com> Cc: edk2-devel@lists.01.org From: Laszlo Ersek Message-ID: Date: Sun, 13 May 2018 20:40:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1526221902-9060-7-git-send-email-liming.gao@intel.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Sun, 13 May 2018 18:40:04 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Sun, 13 May 2018 18:40:04 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [Patch 5/5] UefiCpuPkg: Remove X86 ASM and S files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 May 2018 18:40:06 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05/13/18 16:31, Liming Gao wrote: > NASM has replaced ASM and S files. > Rmove ASM from all modules. > Remove S files from the drivers only. > After NASM is updated, S files can be removed from Library. The patch looks good to me. I suggest a few commit message updates: (1) If I remember correctly, we have a TianoCore BZ for this (also for the NASM update). Can you please reference those here? (2) There's a typo in "Rmove". (3) Technically, a number of *.asm files remain under UefiCpuPkg, namely under "ResetVector/Vtf0". None of those are built stand-alone -- they are all included by "Vtf0.nasmb", and "Vtf0.inf" only references "Vtf0.nasmb". So technically speaking these *.asm files are *.nasm[b] files. I suggest we add a note about this fact, or else file a TianoCore BZ about renaming the Vtf0 ASM files. With the commit message updates: Reviewed-by: Laszlo Ersek Thanks! Laszlo