From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: devel@edk2.groups.io, shenglei.zhang@intel.com
Cc: Jian J Wang <jian.j.wang@intel.com>, Hao A Wu <hao.a.wu@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/3] MdeModulePkg: Fix typos and add periods
Date: Tue, 30 Jul 2019 12:25:44 +0200 [thread overview]
Message-ID: <be563be6-b344-7c2b-b135-efb350d138b5@redhat.com> (raw)
In-Reply-To: <20190730083732.1564-2-shenglei.zhang@intel.com>
On 7/30/19 10:37 AM, Zhang, Shenglei wrote:
> para in Presentation.c is spelled incorrectly.
'param'
> Add periods in CapsuleLib.h and Presentation.c.
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c | 4 ++--
> MdeModulePkg/Include/Library/CapsuleLib.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c
> index 7c36a6f2b7fa..bafee4c61292 100644
> --- a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c
> +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c
> @@ -21,9 +21,9 @@ FORM_DISPLAY_ENGINE_FORM gDisplayFormData;
> BOOLEAN mFinishRetrieveCall = FALSE;
>
> /**
> - Check whether the ConfigAccess protocol is available
> + Check whether the ConfigAccess protocol is available.
>
> - @parm FormSet FormSet of which the ConfigAcces protocol need to be checked.
> + @param FormSet FormSet of which the ConfigAcces protocol need to be checked.
>
> @retval EFI_SUCCESS The function executed successfully.
>
> diff --git a/MdeModulePkg/Include/Library/CapsuleLib.h b/MdeModulePkg/Include/Library/CapsuleLib.h
> index 7a5414c80f19..0f4164257619 100644
> --- a/MdeModulePkg/Include/Library/CapsuleLib.h
> +++ b/MdeModulePkg/Include/Library/CapsuleLib.h
> @@ -101,7 +101,7 @@ CoDCheckCapsuleOnDiskFlag(
> );
>
> /**
> - This routine is called to clear CapsuleOnDisk flags including OsIndications and BootNext variable
> + This routine is called to clear CapsuleOnDisk flags including OsIndications and BootNext variable.
>
> @retval EFI_SUCCESS All Capsule On Disk flags are cleared
>
>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
next prev parent reply other threads:[~2019-07-30 10:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 8:37 [PATCH 0/3] Fix coding style issues Zhang, Shenglei
2019-07-30 8:37 ` [PATCH 1/3] MdeModulePkg: Fix typos and add periods Zhang, Shenglei
2019-07-30 9:15 ` [edk2-devel] " Wang, Jian J
2019-07-30 10:25 ` Philippe Mathieu-Daudé [this message]
2019-07-31 1:01 ` Dandan Bi
2019-07-30 8:37 ` [PATCH 2/3] SecurityPkg/FvReportPei: Change HashAlgoId to HashAlgId Zhang, Shenglei
2019-07-30 9:12 ` Wang, Jian J
2019-07-30 8:37 ` [PATCH 3/3] UefiCpuPkg/PiSmmCpuDxeSmm: Remove trailing white space in SmmMp.h Zhang, Shenglei
2019-07-30 14:11 ` [edk2-devel] " Laszlo Ersek
2019-07-31 0:16 ` Dong, Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be563be6-b344-7c2b-b135-efb350d138b5@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox