From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.85.128.65, mailfrom: philmd@redhat.com) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by groups.io with SMTP; Tue, 30 Jul 2019 03:25:47 -0700 Received: by mail-wm1-f65.google.com with SMTP id v15so56635164wml.0 for ; Tue, 30 Jul 2019 03:25:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=M7NFMhXDYLNpeQVf6fYMaWRjwqGccoXLNPQ9Bh9/wiM=; b=YXMrdKXGOcWEmtOVApOFL3VzNRZrKOIfA3JNiQSXjAtIDjBu2GkKFKPYKsUEgxzJRQ TXOjAmGQrqQQwiZWXhp1C8Aki60VcMn35XHp28DxNaHwmIDpFK2iub4upubmat2oZk/O ulAEFR2IbcM2RhcB37nPlT+rbF4RCcEqJbBKH325DGCLB1DKFJmiKsNpiDA3E0cIxNIr eTbcaExb5qnW0gP3cVG6z5BXTC8P393FVAGw9evxVfHpk8rDOeo7XHXUnFymoHjKw2S0 ZXqECAh7QjBcxZymxar7K4Zluwg5573UYTZLDmSYquSTI2ylX6k6qTXrME0LyV0GSsvY ZQlg== X-Gm-Message-State: APjAAAUtbtS2AY9n5vJt9wb0Dl2qj4AsQ0/tWa2i3i0uXgRXKbmnG30u YDdbuyy9Rr+yeObudoAQfRLTDg== X-Google-Smtp-Source: APXvYqy6wLZe0I7fJJvCPufDSqZ5arUtjhWVmC3NaY+p2H0yuuZZd4YLgLfP2lQuslfW5FiC4yV28A== X-Received: by 2002:a1c:a481:: with SMTP id n123mr97861691wme.123.1564482345989; Tue, 30 Jul 2019 03:25:45 -0700 (PDT) Return-Path: Received: from [192.168.1.38] (190.red-81-40-121.staticip.rima-tde.net. [81.40.121.190]) by smtp.gmail.com with ESMTPSA id r12sm77400155wrt.95.2019.07.30.03.25.45 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jul 2019 03:25:45 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 1/3] MdeModulePkg: Fix typos and add periods To: devel@edk2.groups.io, shenglei.zhang@intel.com Cc: Jian J Wang , Hao A Wu References: <20190730083732.1564-1-shenglei.zhang@intel.com> <20190730083732.1564-2-shenglei.zhang@intel.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Tue, 30 Jul 2019 12:25:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190730083732.1564-2-shenglei.zhang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 7/30/19 10:37 AM, Zhang, Shenglei wrote: > para in Presentation.c is spelled incorrectly. 'param' > Add periods in CapsuleLib.h and Presentation.c. > > Cc: Jian J Wang > Cc: Hao A Wu > Signed-off-by: Shenglei Zhang > --- > MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c | 4 ++-- > MdeModulePkg/Include/Library/CapsuleLib.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c > index 7c36a6f2b7fa..bafee4c61292 100644 > --- a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c > +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c > @@ -21,9 +21,9 @@ FORM_DISPLAY_ENGINE_FORM gDisplayFormData; > BOOLEAN mFinishRetrieveCall = FALSE; > > /** > - Check whether the ConfigAccess protocol is available > + Check whether the ConfigAccess protocol is available. > > - @parm FormSet FormSet of which the ConfigAcces protocol need to be checked. > + @param FormSet FormSet of which the ConfigAcces protocol need to be checked. > > @retval EFI_SUCCESS The function executed successfully. > > diff --git a/MdeModulePkg/Include/Library/CapsuleLib.h b/MdeModulePkg/Include/Library/CapsuleLib.h > index 7a5414c80f19..0f4164257619 100644 > --- a/MdeModulePkg/Include/Library/CapsuleLib.h > +++ b/MdeModulePkg/Include/Library/CapsuleLib.h > @@ -101,7 +101,7 @@ CoDCheckCapsuleOnDiskFlag( > ); > > /** > - This routine is called to clear CapsuleOnDisk flags including OsIndications and BootNext variable > + This routine is called to clear CapsuleOnDisk flags including OsIndications and BootNext variable. > > @retval EFI_SUCCESS All Capsule On Disk flags are cleared > > Reviewed-by: Philippe Mathieu-Daude