From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 16 Jul 2019 03:34:54 -0700 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A2CD3308FC20; Tue, 16 Jul 2019 10:34:53 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-224.ams2.redhat.com [10.36.116.224]) by smtp.corp.redhat.com (Postfix) with ESMTP id 255A05D784; Tue, 16 Jul 2019 10:34:51 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 6/6] edksetup.sh: Add quotes and explicit checks in test statements To: Rebecca Cran , devel@edk2.groups.io, bob.c.feng@intel.com, liming.gao@intel.com, leif.lindholm@linaro.org, michael.d.kinney@intel.com, afish@apple.com References: <20190715222516.53254-1-rebecca@bsdio.com> <20190715222516.53254-6-rebecca@bsdio.com> <3ec20c99-ea95-a009-99ce-ba5ed484000d@bsdio.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 16 Jul 2019 12:34:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <3ec20c99-ea95-a009-99ce-ba5ed484000d@bsdio.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Tue, 16 Jul 2019 10:34:53 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/16/19 04:20, Rebecca Cran wrote: > On 2019-07-15 19:53, Laszlo Ersek wrote: >> >> But, I think the question stands; there's more that could be quoted. >> What is the reason for quoting just these? > > > Mainly because I thought those were the ones that were most important to > add quotes around. I'll probably submit a follow-up patch to fix the > others and further reduce the number of shellcheck warnings. > > Sounds good. This would be very good to capture in the commit message. Can you please submit a new full version of the set, with the commit messages updated? For this patch, with the additional reasoning included: Reviewed-by: Laszlo Ersek Thanks! Laszlo