From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.42]) by mx.groups.io with SMTP id smtpd.web09.9899.1633701979659358937 for ; Fri, 08 Oct 2021 07:06:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=PjUKdtNt; spf=pass (domain: arm.com, ip: 40.107.7.42, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/s/nWZjrH5Mi5r63AOxRQRCJ27GNoDSHP9fQmBumtDA=; b=PjUKdtNtqz+iFOb4TpRWdZ9vaCHYLjTAW37a4BRV9U6zWsZsUgjVqL7TL+hrU7vAA6psd5kQkBKzIOpCrCiv70bsmwxFHrHxGaSkYMzrpccI4VH5AJZA9aBskBkk694djcoIb/kuum52ETD9R922RoZVsHpQiK9XGFNVzFJNsyY= Received: from AM6P191CA0054.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::31) by AM5PR0802MB2387.eurprd08.prod.outlook.com (2603:10a6:203:9d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Fri, 8 Oct 2021 14:06:16 +0000 Received: from VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:7f:cafe::ab) by AM6P191CA0054.outlook.office365.com (2603:10a6:209:7f::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend Transport; Fri, 8 Oct 2021 14:06:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT052.mail.protection.outlook.com (10.152.19.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend Transport; Fri, 8 Oct 2021 14:06:16 +0000 Received: ("Tessian outbound 16951d3c485e:v103"); Fri, 08 Oct 2021 14:06:15 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 5442edf548718e55 X-CR-MTA-TID: 64aa7808 Received: from fc896f68880b.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3448523F-D6FA-462A-8203-450C6CF41D8A.1; Fri, 08 Oct 2021 14:06:08 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fc896f68880b.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 Oct 2021 14:06:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m/ZLFU5yEqWfHf9OSSLTUewgknrevZUp7zYGrL1NLSN92OBxjcBU5f/UWIlPvhEefNA+4U4OV6KYO5N/LPbpRSw9oR0S8jNuGNiF3lUhNa2SkV52JLHsJl2jS+j7dzWG0A/VpcpGYW+D74qhPVbKfV2v2btYhzzjmCydfuKrvXxYeHXd1lhec7y1s605PnlNm7QFR3FYyBXxTPn8zz3JvNLmE/b0E8hieWuxoPky/I299u7Gbu3r070Qr1BCB9n7yFekkO+FXil/yq4qouxANz+RggzZVXj4OlwH0WF1UXA+XZ4nzaIpVLcdNwEjvMwWGPyMxHRDivO3zDZMMtKfNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/s/nWZjrH5Mi5r63AOxRQRCJ27GNoDSHP9fQmBumtDA=; b=DPmJjYdQ5b65mpZ+9zBMlSUVYkjwZw94+4WIDvWhqd1Pj4bjZIWjtjzjS5BJfMLZy9pAH/CPCSbywf3RZSYH+jl2VbunQT4vd4E7c1fVVXdW93qajQ+p6VqPZcAi1TsSDJNHSQ7jbjdL5ji8BJ1mviIjc9/5Mn9ntPEIF58Psb/14RV169CyKQSIOHyS5zlysUtoEl50qUaecGtkh5J+72jaxYYxev/Km+HnQtaz/X0xzHzBF4E/H4lZ/tGrSDmaW0Legw9nVN11lwJwNi/1vWu2XGQyMB5YYj6kG5hbxujEYkovicTXsm66QYXfJZPVIuO800iSum6Z1WHkRtQ3/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/s/nWZjrH5Mi5r63AOxRQRCJ27GNoDSHP9fQmBumtDA=; b=PjUKdtNtqz+iFOb4TpRWdZ9vaCHYLjTAW37a4BRV9U6zWsZsUgjVqL7TL+hrU7vAA6psd5kQkBKzIOpCrCiv70bsmwxFHrHxGaSkYMzrpccI4VH5AJZA9aBskBkk694djcoIb/kuum52ETD9R922RoZVsHpQiK9XGFNVzFJNsyY= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM6PR08MB4535.eurprd08.prod.outlook.com (2603:10a6:20b:74::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Fri, 8 Oct 2021 14:06:07 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65%4]) with mapi id 15.20.4587.022; Fri, 8 Oct 2021 14:06:07 +0000 Subject: Re: [PATCH v2 01/21] DynamicTablesPkg: Remove unnecessary includes To: Pierre.Gondois@arm.com, devel@edk2.groups.io, Alexei.Fedorov@arm.com, nd References: <20211007153210.26608-1-Pierre.Gondois@arm.com> <20211007153210.26608-2-Pierre.Gondois@arm.com> From: "Sami Mujawar" Message-ID: Date: Fri, 8 Oct 2021 15:06:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20211007153210.26608-2-Pierre.Gondois@arm.com> X-ClientProxiedBy: LO4P265CA0042.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ac::7) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.52) by LO4P265CA0042.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ac::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend Transport; Fri, 8 Oct 2021 14:06:06 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 107f2f2e-77c0-4e10-1569-08d98a64cb46 X-MS-TrafficTypeDiagnostic: AM6PR08MB4535:|AM5PR0802MB2387: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:3826;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ArV/c2qwJx+cBicZuls0QxXCUT1s/eXBxGD1xQPqsmdPEyyOZckhWJentgSzRkc3XRc0ADEJCmtOuge66SXyiTOSeOcTQpsv1W6nWtR0JOUpJp+iifiuNCAvfBo7I36rnSbWikTSD+P+tv2XetNTRCCPz1HK6FfH278kdc9rSl/rF5TuBe6nlsj7rWQj0QkYoTHNexaADW/bA5k965dxjmAp9Q4lztxPfQ4ySPED7afREKFcylwKMV4YEz+dBrq3G1Bq06xuyQcrPM4AytsaVWihA/M89/jantKRW4/HcEQZLURcY6Hfb7s8Db18WSjkxpmGoR/dhrQfShOmD7dX7T7rph5KhrBjyu1cX4wO+blXusE1f0PendpF0n185BgcMl4j69TFr8sK2ixpTmSMeKPv7/Ggr3bxszIByA79RSYK8ArblPitmXGd6NSfk6us9jV4qKb8YjvpfPpSOSVVvdWBFVXrzPTZ27+R0G5rFlgFP1kOujsuwHWFjVXKXxNMvRRSF2pvgDbsxhH99u53+BLCiQUcTDpvBg61f7mbVF2go674g3L+zYP1F7jVHo2+SHJFK04Zl/oVwcLWAG6puIoEPIPQ+YUY0dhfqyoeSANa72hSQbOJtHxEirRClnziJrFxB/qAJdjbGigoEqpeCFYVIRGWaHLsgpa0Uxxz2PYZ7JD/bDLA/7QdE5c/2/+0eTzPKbVWqxCa8S4/q64GcqRCmNCQkHvDYdXt/nsKVdwZLbteMU88vK7nj1tSr1wsjVM6ErNhexMpn4E4wypLOw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(2616005)(36756003)(31686004)(31696002)(66476007)(86362001)(37006003)(83380400001)(16576012)(8676002)(8936002)(2906002)(6862004)(66556008)(66946007)(956004)(6636002)(186003)(508600001)(38350700002)(38100700002)(44832011)(316002)(53546011)(5660300002)(6666004)(26005)(52116002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4535 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 35f780cc-7796-4b34-9a43-08d98a64c5da X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CAV1shzLQ/0zC4MvM4fW7lwTxwgiTB0edlvjkA0BNVszOoZf6p2YHUUhYGayxvMcyQh17z5TV80zee8Doeo59RLI+d613ZPluoe1CWaQV3LlSQpv0BjbPxGhaRfUXalfvTdd8rM+uw8ZF+EGfoTlIM3yBcKNnGkK7fxxtOyur3NeAKYhNcEzUei8qcrZ0azdANLss8wfp3CFl1itD5EEVlcygV0cfnFaDsR5qRe52+hR4oAX8jHEz3IIvu6hpB0yXC7gezo8nqKnbdZu2ON58LDfGiZIPkizXQUxjLMoJkvAUuJulFBVzvhlHnY2qkw4HqazZ1elhJcwcITn6a9vMippIr3+Oc+mWcJTgiOB9O356J9NXmixNWax8qLVmyomJX3fEB3CKKaVODtCrAML9W0Mu+juEwk5v9W5g48Osb4LFsmGepYIYICcLyPd4wG+QKqTUADNhcNS2PG80qTav09F4F4dLSSMdxmc7q2m4hhYMXtPQWA+yLp+UTORv2+suDmeokyUWerUyaa63U6suJX/GofFsEHfJyAKVhhPskQkystGRWZhZgVFBoKJtBn9JMewUl70IvHSz/iwL1JkqUgezJRVd4SCC+aKIpn/qmv1U21DtO4/aqqf984o4Y+OxnvORehLoopQ1pV09z2TSEXLmiWiKFsv1zV1YgIzfBrVylBuzMWtIme2IoiurkVbhKKl7c8ittdr0rqzbid+U2Y6dm91mMyEsHM7zzIUkqk= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(26005)(70206006)(31696002)(36860700001)(2616005)(83380400001)(508600001)(47076005)(37006003)(6636002)(6862004)(70586007)(8936002)(82310400003)(316002)(16576012)(8676002)(6486002)(956004)(186003)(86362001)(36756003)(53546011)(336012)(6666004)(2906002)(356005)(5660300002)(81166007)(44832011)(31686004)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 14:06:16.0358 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 107f2f2e-77c0-4e10-1569-08d98a64cb46 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2387 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-GB Hi Pierre, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 07/10/2021 04:31 PM, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > Some includes are not necessary. Remove then. > > Signed-off-by: Pierre Gondois > --- > > Notes: > v2: > - New patch. [Pierre] > > .../Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c | 2 -- > .../Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c | 3 --- > .../Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c | 1 - > 3 files changed, 6 deletions(-) > > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtC= mn600Generator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCmn600LibArm/S= sdtCmn600Generator.c > index 19b7b128a08d..b46ad25cdd26 100644 > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Ge= nerator.c > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Ge= nerator.c > @@ -10,13 +10,11 @@ > - Generic ACPI for Arm Components 1.0 Platform Design Document > **/ > > -#include > #include > #include > #include > #include > #include > -#include > #include > > // Module specific include files. > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/S= sdtSerialPortGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerial= PortLibArm/SsdtSerialPortGenerator.c > index 1b70fe1db1d7..d62aee1056ad 100644 > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSeri= alPortGenerator.c > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSeri= alPortGenerator.c > @@ -6,13 +6,11 @@ > SPDX-License-Identifier: BSD-2-Clause-Patent > **/ > > -#include > #include > #include > #include > #include > #include > -#include > #include > > // Module specific include files. > @@ -20,7 +18,6 @@ > #include > #include > #include > -#include > #include > #include > > diff --git a/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtS= erialPortFixupLib.c b/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLi= b/SsdtSerialPortFixupLib.c > index 6966410b2c34..79e1fabc9223 100644 > --- a/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPo= rtFixupLib.c > +++ b/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPo= rtFixupLib.c > @@ -16,7 +16,6 @@ > #include > #include > #include > -#include > #include > > // Module specific include files. IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.