From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2BA7E802B9 for ; Tue, 14 Mar 2017 13:56:33 -0700 (PDT) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B13E280F6D; Tue, 14 Mar 2017 20:56:33 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-194.phx2.redhat.com [10.3.116.194]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v2EKuWNf011270; Tue, 14 Mar 2017 16:56:32 -0400 To: Jordan Justen , edk2-devel-01 References: <20170311062651.28351-1-lersek@redhat.com> <148951525611.24552.5051870457659495766@jljusten-skl> Cc: Ard Biesheuvel From: Laszlo Ersek Message-ID: Date: Tue, 14 Mar 2017 21:56:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <148951525611.24552.5051870457659495766@jljusten-skl> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 14 Mar 2017 20:56:33 +0000 (UTC) Subject: Re: [PATCH v2 00/12] ArmVirtPkg, OvmfPkg: factor out QemuFwCfgS3Lib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Mar 2017 20:56:33 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 03/14/17 19:14, Jordan Justen wrote: > Series Reviewed-by: Jordan Justen Thank you, pushed as 6ac97ad31edb..805762252733. The next series that I'll post will comply with the updated multi-line function call syntax, codified in . Thanks Laszlo > On 2017-03-10 22:26:39, Laszlo Ersek wrote: >> This is version 2 of the series posted at >> . >> >> Changes in this version: >> - pick up v1 R-b's from Jordan and Ard (patches 1-6) >> - rename QemuFwCfgS3TransferOwnership to >> QemuFwCfgS3CallWhenBootScriptReady [Jordan] >> - rename FW_CFG_BOOT_SCRIPT_APPEND_FUNCTION to >> FW_CFG_BOOT_SCRIPT_CALLBACK_FUNCTION [Jordan] >> - rename "Append" to "Callback" and "mAppend" to "mCallback" [Laszlo] >> - rename QemuFwCfgS3WriteBytes, QemuFwCfgS3ReadBytes, >> QemuFwCfgS3SkipBytes, and QemuFwCfgS3CheckValue to >> QemuFwCfgS3ScriptWriteBytes, QemuFwCfgS3ScriptReadBytes, >> QemuFwCfgS3ScriptSkipBytes, and QemuFwCfgS3ScriptCheckValue, >> respectively [Jordan] >> >> Changes are noted per patch too. >> >> Rebuilt at every stage and retested (like in v1). >> >> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=394 >> Repo: https://github.com/lersek/edk2.git >> Branch: fw_cfg_s3_v2 >> >> Cc: Ard Biesheuvel >> Cc: Jordan Justen >> >> Thanks >> Laszlo >> >> Laszlo Ersek (12): >> OvmfPkg: introduce QemuFwCfgS3Lib class >> OvmfPkg/QemuFwCfgS3Lib: add initial Base Null library instance >> OvmfPkg/QemuFwCfgS3Lib: add initial PEI and DXE fw_cfg library >> instances >> ArmVirtPkg: resolve QemuFwCfgS3Lib >> OvmfPkg: resolve QemuFwCfgS3Lib >> ArmVirtPkg, OvmfPkg: retire QemuFwCfgS3Enabled() from QemuFwCfgLib >> OvmfPkg/QemuFwCfgS3Lib: add boot script opcode generation APIs to >> libclass >> OvmfPkg/QemuFwCfgS3Lib: implement opcode APIs for Base Null instance >> OvmfPkg/QemuFwCfgS3Lib: implement opcode APIs for PEI fw_cfg instance >> OvmfPkg/QemuFwCfgS3Lib: implement opcode APIs for DXE fw_cfg instance >> OvmfPkg/SmmControl2Dxe: save fw_cfg boot script with QemuFwCfgS3Lib >> OvmfPkg/AcpiPlatformDxe: save fw_cfg boot script with QemuFwCfgS3Lib >> >> ArmVirtPkg/ArmVirtQemu.dsc | 1 + >> ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 + >> ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 17 - >> OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h | 2 +- >> OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 2 +- >> OvmfPkg/AcpiPlatformDxe/BootScript.c | 262 ++----- >> OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 8 + >> OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf | 2 +- >> OvmfPkg/Include/Library/QemuFwCfgLib.h | 14 - >> OvmfPkg/Include/Library/QemuFwCfgS3Lib.h | 361 +++++++++ >> OvmfPkg/Library/LockBoxLib/LockBoxDxe.c | 1 + >> OvmfPkg/Library/LockBoxLib/LockBoxDxeLib.inf | 1 + >> OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h | 1 + >> OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 + >> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 28 - >> OvmfPkg/Library/QemuFwCfgS3Lib/BaseQemuFwCfgS3LibNull.inf | 43 ++ >> OvmfPkg/Library/QemuFwCfgS3Lib/DxeQemuFwCfgS3LibFwCfg.inf | 46 ++ >> OvmfPkg/Library/QemuFwCfgS3Lib/PeiQemuFwCfgS3LibFwCfg.inf | 44 ++ >> OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3Base.c | 110 +++ >> OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3BasePei.c | 227 ++++++ >> OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3Dxe.c | 792 ++++++++++++++++++++ >> OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3Pei.c | 86 +++ >> OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3PeiDxe.c | 48 ++ >> OvmfPkg/OvmfPkg.dec | 4 + >> OvmfPkg/OvmfPkgIa32.dsc | 3 + >> OvmfPkg/OvmfPkgIa32X64.dsc | 3 + >> OvmfPkg/OvmfPkgX64.dsc | 3 + >> OvmfPkg/PlatformPei/Platform.c | 1 + >> OvmfPkg/PlatformPei/PlatformPei.inf | 1 + >> OvmfPkg/SmmControl2Dxe/SmiFeatures.c | 224 ++---- >> OvmfPkg/SmmControl2Dxe/SmiFeatures.h | 5 +- >> OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c | 6 +- >> OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.inf | 1 + >> 33 files changed, 1924 insertions(+), 425 deletions(-) >> create mode 100644 OvmfPkg/Include/Library/QemuFwCfgS3Lib.h >> create mode 100644 OvmfPkg/Library/QemuFwCfgS3Lib/BaseQemuFwCfgS3LibNull.inf >> create mode 100644 OvmfPkg/Library/QemuFwCfgS3Lib/DxeQemuFwCfgS3LibFwCfg.inf >> create mode 100644 OvmfPkg/Library/QemuFwCfgS3Lib/PeiQemuFwCfgS3LibFwCfg.inf >> create mode 100644 OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3Base.c >> create mode 100644 OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3BasePei.c >> create mode 100644 OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3Dxe.c >> create mode 100644 OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3Pei.c >> create mode 100644 OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3PeiDxe.c >> >> -- >> 2.9.3 >> > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >