[Patch] MdeModulePkg RegularExpressionDxe: Remove unknown build option for XCODE

[Patch] MdeModulePkg RegularExpressionDxe: Remove unknown build option for XCODE

[Liming Gao]

This patch makes RegularExpressionDxe pass XCODE5 build.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
---
 MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
index df54716..7ccab57 100644
--- a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
+++ b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
@@ -112,3 +112,7 @@
 
   # Oniguruma: tag_end in parse_callout_of_name
   GCC:*_*_*_CC_FLAGS = -Wno-error=maybe-uninitialized
+  
+  # Not add -Wno-error=maybe-uninitialized option for XCODE
+  # XCODE doesn't know this option
+  XCODE:*_*_*_CC_FLAGS =
-- 
2.10.0.windows.1

Re: [Patch] MdeModulePkg RegularExpressionDxe: Remove unknown build option for XCODE

[Zeng, Star]

On 2018/10/26 10:33, Liming Gao wrote:
> This patch makes RegularExpressionDxe pass XCODE5 build.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> ---
>   MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
> index df54716..7ccab57 100644
> --- a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
> +++ b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
> @@ -112,3 +112,7 @@
>   
>     # Oniguruma: tag_end in parse_callout_of_name
>     GCC:*_*_*_CC_FLAGS = -Wno-error=maybe-uninitialized
> +
> +  # Not add -Wno-error=maybe-uninitialized option for XCODE

Use "Eliminate" instead of "Not add" here? :)

Anyway, Reviewed-by: Star Zeng <star.zeng@intel.com>.

Thanks,
Star

> +  # XCODE doesn't know this option
> +  XCODE:*_*_*_CC_FLAGS =
> 

Re: [Patch] MdeModulePkg RegularExpressionDxe: Remove unknown build option for XCODE

[Gao, Liming]

Star:
  This option is not the default option. To pass GCC build, GCC tool chain adds it. XCODE tool chain doesn't require it, it is not listed for XCODE. 

Thanks
Liming
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Zeng, Star
> Sent: Friday, October 26, 2018 11:27 AM
> To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>
> Subject: Re: [edk2] [Patch] MdeModulePkg RegularExpressionDxe: Remove unknown build option for XCODE
> 
> On 2018/10/26 10:33, Liming Gao wrote:
> > This patch makes RegularExpressionDxe pass XCODE5 build.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Liming Gao <liming.gao@intel.com>
> > Cc: Star Zeng <star.zeng@intel.com>
> > ---
> >   MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
> b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
> > index df54716..7ccab57 100644
> > --- a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
> > +++ b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
> > @@ -112,3 +112,7 @@
> >
> >     # Oniguruma: tag_end in parse_callout_of_name
> >     GCC:*_*_*_CC_FLAGS = -Wno-error=maybe-uninitialized
> > +
> > +  # Not add -Wno-error=maybe-uninitialized option for XCODE
> 
> Use "Eliminate" instead of "Not add" here? :)
> 
> Anyway, Reviewed-by: Star Zeng <star.zeng@intel.com>.
> 
> Thanks,
> Star
> 
> > +  # XCODE doesn't know this option
> > +  XCODE:*_*_*_CC_FLAGS =
> >
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel