From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2D6532117CE82 for ; Thu, 25 Oct 2018 20:27:10 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2018 20:27:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,426,1534834800"; d="scan'208";a="85698282" Received: from shzintpr02.sh.intel.com (HELO [10.7.209.51]) ([10.239.4.160]) by orsmga006.jf.intel.com with ESMTP; 25 Oct 2018 20:27:09 -0700 To: Liming Gao , edk2-devel@lists.01.org References: <20181026023324.23192-1-liming.gao@intel.com> Cc: star.zeng@intel.com From: "Zeng, Star" Message-ID: Date: Fri, 26 Oct 2018 11:26:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181026023324.23192-1-liming.gao@intel.com> Subject: Re: [Patch] MdeModulePkg RegularExpressionDxe: Remove unknown build option for XCODE X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Oct 2018 03:27:11 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 2018/10/26 10:33, Liming Gao wrote: > This patch makes RegularExpressionDxe pass XCODE5 build. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao > Cc: Star Zeng > --- > MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf > index df54716..7ccab57 100644 > --- a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf > +++ b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf > @@ -112,3 +112,7 @@ > > # Oniguruma: tag_end in parse_callout_of_name > GCC:*_*_*_CC_FLAGS = -Wno-error=maybe-uninitialized > + > + # Not add -Wno-error=maybe-uninitialized option for XCODE Use "Eliminate" instead of "Not add" here? :) Anyway, Reviewed-by: Star Zeng . Thanks, Star > + # XCODE doesn't know this option > + XCODE:*_*_*_CC_FLAGS = >