From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, cepingx.sun@intel.com
Cc: Erdem Aktas <erdemaktas@google.com>,
James Bottomley <jejb@linux.ibm.com>,
Jiewen Yao <jiewen.yao@intel.com>, Min Xu <min.m.xu@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Michael Roth <michael.roth@amd.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [edk2-devel] [PATCH V2 1/1] OvmfPkg/AcpiPlatformDxe: Fix Coverity report issues
Date: Wed, 25 Oct 2023 12:11:31 +0200 [thread overview]
Message-ID: <beea1789-ccf5-e536-553a-94ba414c86f5@redhat.com> (raw)
In-Reply-To: <20231023090539.1003-1-cepingx.sun@intel.com>
On 10/23/23 11:05, sunceping wrote:
> From: Ceping Sun <cepingx.sun@intel.com>
>
> v1 -> v2 Changed list:
> 1:Since both commits are intended to fix coverity issues, they are merged into one
> 2: Changed the debug info level to debug error when "DsdtTable == NULL"
> 3:Add the Cc member as below
> Erdem Aktas erdemaktas@google.com
> James Bottomley jejb@linux.ibm.com
> Tom Lendacky thomas.lendacky@amd.com
> Michael Roth michael.roth@amd.com
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4568
>
> The function InstallCloudHvTablesTdx had an Assert when "DsdtTable == NULL",
> but this comes into play only in DEBUG mode. In Release mode , there is
> no handling if the pointer is NULL. To avoid the possible null pointer
> dereference, it is better to handle it when the pointer is null.
>
> In addition, the status of "AcpiProtocol->InstallAcpiTable" is overwritten before
> it can be used in the function, it is better to check it before overwriting.
>
> code: https://github.com/sunceping/edk2/tree/fixcoverityerrors.v2
>
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Min Xu <min.m.xu@intel.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Michael Roth <michael.roth@amd.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Ceping Sun <cepingx.sun@intel.com>
> ---
> OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c b/OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c
> index d3e73c155e8f..4629fa260366 100644
> --- a/OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c
> +++ b/OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c
> @@ -53,6 +53,11 @@ InstallCloudHvTablesTdx (
> CurrentTable->Length,
> &TableHandle
> );
> + if (EFI_ERROR (Status)) {
> + ASSERT_EFI_ERROR (Status);
> + return Status;
> + }
> +
> for (UINTN i = 0; i < CurrentTable->Length; i++) {
> DEBUG ((DEBUG_INFO, " %x", *((UINT8 *)CurrentTable + i)));
> }
> @@ -69,8 +74,9 @@ InstallCloudHvTablesTdx (
> // then we're out of sync with the hypervisor, and cannot continue.
> //
> if (DsdtTable == NULL) {
> - DEBUG ((DEBUG_INFO, "%a: no DSDT found\n", __func__));
> + DEBUG ((DEBUG_ERROR, "%a: no DSDT found\n", __func__));
> ASSERT (FALSE);
> + CpuDeadLoop ();
> }
>
> Status = AcpiProtocol->InstallAcpiTable (
merged via <https://github.com/tianocore/edk2/pull/4954> as commit
cf87fd95c1f5be4880a015c82a18e8ae12ff5e94
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110030): https://edk2.groups.io/g/devel/message/110030
Mute This Topic: https://groups.io/mt/102131520/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2023-10-25 10:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 9:05 [edk2-devel] [PATCH V2 1/1] OvmfPkg/AcpiPlatformDxe: Fix Coverity report issues sunceping
2023-10-25 1:30 ` Min Xu
2023-10-25 10:11 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=beea1789-ccf5-e536-553a-94ba414c86f5@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox