Re: [PATCH 1/1][edk2-stable202211] ArmPkg/ArmTrngLib: Remove ASSERT in GetArmTrngVersion()

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Pierre,

Thank you for this fix.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 14/11/2022 02:43 pm, Pierre.Gondois@arm.com wrote:
> From: Pierre Gondois <pierre.gondois@arm.com>
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4150
>
> GetArmTrngVersion() is used to check the presence of an Arm
> Trng. If not found, an ASSERT prevents from booting in DEBUG
> builds.
> Remove this ASSERT.
>
> Reported-by: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> ---
>   ArmPkg/Library/ArmTrngLib/ArmTrngLib.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> index fdabc02cd39c..3278722320c8 100644
> --- a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> +++ b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
> @@ -344,7 +344,6 @@ ArmTrngLibConstructor (
>   
>     Status = GetArmTrngVersion (&MajorRev, &MinorRev);
>     if (RETURN_ERROR (Status)) {
> -    ASSERT_RETURN_ERROR (Status);
>       goto ErrorHandler;
>     }
>