From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.43]) by mx.groups.io with SMTP id smtpd.web10.7302.1668441659953421350 for ; Mon, 14 Nov 2022 08:01:00 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=2unxYOdV; spf=pass (domain: arm.com, ip: 40.107.8.43, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6Uu1/5v8RfOhFc+1OD0nIaitwmml7ii8ZvQvHilNcTY=; b=2unxYOdVkWnVBdhv5H0SE5BevmF3NOIbKmHCXfXVyF3wZmZf1Ur3Emf1ZCgQDO12bLg0vl3H6k/gC1rXQGuzEEd9ABBD/7MSHNfVngl2RFSNRG+9dg7c5CK2Kk9W95qi02NdgkIn5wKK1l2Bw7eo28IiuuARcA6//7ZCrtYzVoA= Received: from DB6PR07CA0007.eurprd07.prod.outlook.com (2603:10a6:6:2d::17) by PAXPR08MB6432.eurprd08.prod.outlook.com (2603:10a6:102:154::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Mon, 14 Nov 2022 16:00:53 +0000 Received: from DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2d:cafe::62) by DB6PR07CA0007.outlook.office365.com (2603:10a6:6:2d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Mon, 14 Nov 2022 16:00:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT061.mail.protection.outlook.com (100.127.143.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Mon, 14 Nov 2022 16:00:52 +0000 Received: ("Tessian outbound 73ab5f36653e:v130"); Mon, 14 Nov 2022 16:00:52 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 2e3c878c9dadc84d X-CR-MTA-TID: 64aa7808 Received: from 620e21e38769.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B1112DFD-DAEC-457E-A2B5-D525FA37056F.1; Mon, 14 Nov 2022 16:00:42 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 620e21e38769.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 14 Nov 2022 16:00:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LnYqYwMrO7KBNsKA9BWS93MpfthyMP29zhW0ZPWledfwtiMOwMpbtByFa/eYtZA0meVafKOcHJVPwk2VAXBjClRBOQea7VURwlXNTjZxTVHzbUDFx51hqlglgS44aMaU7nsK1Ygn+XqplLCxhR3QTqguCbj5rM+yYsJMGwqWWwNALrjVx37GLwh+LT2+NW6loyuS9vzi/uwlZ2cuPAP1EH6seVunj4RANuRmqPVCH56YTd5JQFMddVBgIfhP0/cfJhPCKBlDWabYo0iNPsLeFSTJ8tk8Xr/hoa+9FWV1MB+vvW56efOmIuk14bEPRk60X7xnPHriccLwwqo5J+ci7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6Uu1/5v8RfOhFc+1OD0nIaitwmml7ii8ZvQvHilNcTY=; b=let0EkzFqSvPqMvTXDgtULQJ0NhbJxz5efBphzHTk5XNSshWVcEqii58y8vjZMG2UmQGcyRx06mF9l6nPBzRqmYeAVNCmPW5MbLGu7G5nmlW8KPWBHtWFncUR4Qhg56BoRqOJ9sXI4Zm58nX69Zx1Xd3KGk3H8F6+IoGARH2z8eNQrDf05Oeg4W0EjaHZHhvih8I4Obe2ja+XHodSMQaUkwNFM4HCOHXgvuczVwqacBGM/CZsMml9HhkLKslEG8tLwoUGOAjqDO+uwqxog2nKuB4lnNt/lFa9kzYCz8E1enD70ThQme8VdceYT5gsGX/0xxtqOTZh3c4WFKfbCc2ZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6Uu1/5v8RfOhFc+1OD0nIaitwmml7ii8ZvQvHilNcTY=; b=2unxYOdVkWnVBdhv5H0SE5BevmF3NOIbKmHCXfXVyF3wZmZf1Ur3Emf1ZCgQDO12bLg0vl3H6k/gC1rXQGuzEEd9ABBD/7MSHNfVngl2RFSNRG+9dg7c5CK2Kk9W95qi02NdgkIn5wKK1l2Bw7eo28IiuuARcA6//7ZCrtYzVoA= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AS2PR08MB8646.eurprd08.prod.outlook.com (2603:10a6:20b:55d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Mon, 14 Nov 2022 16:00:38 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::eca2:349c:4dbf:7f10]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::eca2:349c:4dbf:7f10%7]) with mapi id 15.20.5834.006; Mon, 14 Nov 2022 16:00:38 +0000 Message-ID: Date: Mon, 14 Nov 2022 16:00:37 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 1/1][edk2-stable202211] ArmPkg/ArmTrngLib: Remove ASSERT in GetArmTrngVersion() To: Pierre.Gondois@arm.com, devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Liming Gao , "nd@arm.com" References: <20221114144347.1664317-1-Pierre.Gondois@arm.com> From: "Sami Mujawar" In-Reply-To: <20221114144347.1664317-1-Pierre.Gondois@arm.com> X-ClientProxiedBy: LO4P123CA0191.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a4::16) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|AS2PR08MB8646:EE_|DBAEUR03FT061:EE_|PAXPR08MB6432:EE_ X-MS-Office365-Filtering-Correlation-Id: 4fc5a28b-a801-401e-5541-08dac65967f8 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 2F4xcWU8L4xcDPikPdmqTEudscon7hp+2xL+d0vCgAGu5+jd4zLtw/1yfi+cO4uGV3xFdvB2MOOt3n0GBay9YUg1remeDje9b47GOlxDiV24ighhC6jCc2DQTdY4wHcVgb4c6fy17ZmBDjnm0pLZsNuOZo0O5g9T08IgF/y0ktbYtXAEPDj+wwhQXKHWOCaC0DJrbEyxgGUgdyws7M5h7DKZXk0y0+ZHnq9IlU2Df3GwkJcXMNKSz43exS3EoAVXVm5R6XBDvT+Q0D6Axdc6a9ALzrRV0oNdwzqfPdwC5dnmW+Me88r9ZIV10bbSM7gLoP62VNDB13YtT4Ys2gM15CsWe3orCmwDTh/zSNuFNx9I5JDA0aLABBBFdn3ZBkqC1IEO6P2Wf4fB7IOUk6DWs5SJX1Wnb0dxu4PZ/Ol/lB8GkAGwn+OVPTPQUjj0+H/Y/Wo39+TwL4dvLV5hl/qFj+LvBKhCQLwfDTHR3khmHheuwYLoy3VvuumU6udKZh264vF8V6+XKSN3vqCFpjRlbWSQkTpymWflwjuxbubAUKt19uEONd3Kti2QAWWoe0I6trMjvQ+SYOs+EGkJ1dqH7jt4ObAxg+O4SU8KZiLqprOkWfsZsC5L6xmUbRlB1HpX+pe1pH+CrqXHjhlS7EhsjCdxRsY1OudvosYnPZsI7Y85pGOhaxKqqDWCIk2rlTOitNnRePQUm7v6zp7KEq9e2ieJJ0T7Sn2gNxIeQQ6ig7gqa31Dbosr45egGhY35v8SiDwUKz97irbJih4fxr738EikzojEt26Gmv6gxqnDsz893enlO3H1HLEpaeU8T8t2 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(39860400002)(366004)(346002)(136003)(451199015)(83380400001)(38100700002)(31696002)(478600001)(966005)(8936002)(6486002)(5660300002)(66476007)(66556008)(41300700001)(8676002)(4326008)(66946007)(186003)(54906003)(316002)(2616005)(2906002)(53546011)(86362001)(26005)(6512007)(44832011)(6506007)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8646 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1c07bc4e-1795-4701-922a-08dac6595f8f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6+BvsusKPnMbNnL3k+qb5fMwmYkG0fjtSJPm8e40B0Mmf3jqvjs8qlKzfabFqjWbb4vHQFxvPSA1BNBWiXMUY8zIqOFTgfYYEN6wsNHaFSNlxD/nFDPNfI9UAp26zj3KOehbpRrJpHJEZZRf+egiwGqQu3U/L8i/LFRLCU041z4lc/cEg2h5RlOcReiKdjGF5ntoRBJbs8XTdml680h582BwysE6iIlN7klOs0P6XYwWjwJpxFHfTneCsEWTK6THlYBcp3aHHWpdTTlZzTrF8ktnnhNEJgPAphsOR964l226ZdtxK6ZuSi23lTuVFL3K7vgY2B+kQaQe/NDjrtfFCL6lCDJ1S+VfsozEfWnvU4hSu3Olo2atC4ib+ijpQe9SZFi4Yo2LrHo4m3h096E7dPH3GGJl+owzgrn7s5HISkByreThK3z1hH+gLryMOg+LtgCjtoTJBXYuXMM24MGmJnh5E5FrBh4cQ8bb53hZSdGASWXqCQUoRKi6sf4Q9GzaC23Mm3llUl4n+zmLHtY6pl95lYTSG9DcoAABp94NW/BruXquRY6dIMmTyYxXL0xBTtHV/+4m8lXScU+rQ7i9dBnU2L6T2+LCJR+Cp1cl3MXnnBtmGyIoGkIz0DtjDCiAV9Az1bKfXJBsYrtNorBbkPEXnAegjl543b0WVS5fqdBA1vsNNXFBh/aLPtNc63ECp5wTY+eVEqyPVmUyR3qE2Sq0hDAqhRNFKVLU+cav9kKtY3nOgZ4BQdIMgkSyHWY/OpFl1VgT8rY3TxYdeP/6UiM3bGJeL+z72I7sN9LFeI7SVRHoTrV7cy2GDqSQTES8yx4m2nUvcxq6q9FOuCXe60vfsBEyZfRIW4E+rS3DRzFvF3Ra8OjciTXKcnk7ag8H X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(346002)(39860400002)(136003)(396003)(451199015)(46966006)(40470700004)(36840700001)(31686004)(2906002)(83380400001)(8936002)(44832011)(70206006)(41300700001)(40460700003)(36756003)(5660300002)(81166007)(966005)(70586007)(356005)(4326008)(54906003)(82310400005)(186003)(31696002)(82740400003)(36860700001)(86362001)(47076005)(316002)(6486002)(26005)(53546011)(6512007)(6506007)(40480700001)(478600001)(8676002)(336012)(2616005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 16:00:52.4907 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4fc5a28b-a801-401e-5541-08dac65967f8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6432 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Pierre, Thank you for this fix. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 14/11/2022 02:43 pm, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4150 > > GetArmTrngVersion() is used to check the presence of an Arm > Trng. If not found, an ASSERT prevents from booting in DEBUG > builds. > Remove this ASSERT. > > Reported-by: Sami Mujawar > Signed-off-by: Pierre Gondois > --- > ArmPkg/Library/ArmTrngLib/ArmTrngLib.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c > index fdabc02cd39c..3278722320c8 100644 > --- a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c > +++ b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c > @@ -344,7 +344,6 @@ ArmTrngLibConstructor ( > > Status = GetArmTrngVersion (&MajorRev, &MinorRev); > if (RETURN_ERROR (Status)) { > - ASSERT_RETURN_ERROR (Status); > goto ErrorHandler; > } >