From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: devel@edk2.groups.io, lersek@redhat.com
Cc: Hao A Wu <hao.a.wu@intel.com>,
Jian J Wang <jian.j.wang@intel.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
Liming Gao <liming.gao@intel.com>,
Michael Kubacki <michael.a.kubacki@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/VariableSmmRuntimeDxe.inf: list local header "Variable.h"
Date: Thu, 21 Nov 2019 16:53:18 +0100 [thread overview]
Message-ID: <bf771202-877b-3607-08c1-2339191b64cb@redhat.com> (raw)
In-Reply-To: <20191121093833.13840-2-lersek@redhat.com>
On 11/21/19 10:38 AM, Laszlo Ersek via Groups.Io wrote:
> Commit aab3b9b9a1e5 ("MdeModulePkg/Variable: Add RT GetVariable() cache
> support", 2019-11-05) added "VariableParsing.h" to
> "VariableSmmRuntimeDxe.inf".
>
> "VariableParsing.h" includes "Variable.h", so the "build" utility is right
> to warn us that "Variable.h" should be listed in [Sources] too.
>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Fixes: aab3b9b9a1e5e1f3fa966fb1667fc3e6c47e7706
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>
> Notes:
> Targeting edk2-stable201911.
>
> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf
> index a250533a534f..592862773390 100644
> --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf
> +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf
> @@ -41,6 +41,7 @@ [Sources]
> Measurement.c
> VariableParsing.c
> VariableParsing.h
> + Variable.h
>
> [Packages]
> MdePkg/MdePkg.dec
>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
next prev parent reply other threads:[~2019-11-21 15:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 9:38 [PATCH 0/3] local header listing fixes for INF files, for edk2-stable201911 Laszlo Ersek
2019-11-21 9:38 ` [PATCH 1/3] MdeModulePkg/VariableSmmRuntimeDxe.inf: list local header "Variable.h" Laszlo Ersek
2019-11-21 15:53 ` Philippe Mathieu-Daudé [this message]
2019-11-21 15:55 ` Wang, Jian J
2019-11-21 9:38 ` [PATCH 2/3] CryptoPkg/OpensslLib: improve INF file consistency Laszlo Ersek
2019-11-21 14:44 ` Wang, Jian J
2019-11-21 15:48 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-11-21 9:38 ` [PATCH 3/3] CryptoPkg/OpensslLib.inf: list OpenSSL local header "ms/uplink.h" Laszlo Ersek
2019-11-21 14:43 ` [edk2-devel] " Wang, Jian J
2019-11-21 15:51 ` Philippe Mathieu-Daudé
2019-11-21 10:00 ` [PATCH 0/3] local header listing fixes for INF files, for edk2-stable201911 Leif Lindholm
2019-11-21 16:07 ` Laszlo Ersek
2019-12-02 20:23 ` [edk2-devel] " Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf771202-877b-3607-08c1-2339191b64cb@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox