From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web11.25668.1574351606793018505 for ; Thu, 21 Nov 2019 07:53:27 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Q9dsq9N/; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574351605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VxbDu6rtU6oHEyFU7bYwyR9lD4Ya151TiHMH94DHwtU=; b=Q9dsq9N/dEKDjp8zU+Rj81CktsLc2nOQJfur+41+vGlgN4hUM6HILIAgOGIi19Hkk3xMs6 cUd46iqUKWOT4Thzv3Si5sx2ktCSMbcXUGRxbbv82nBpGmeiwnIHeofh09zsitsUR4bDS0 StAgCEXMMVTH3j0TOlYPD71CRq0YXJ8= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-197-CydtIr78N5SZaPQ0-3H71Q-1; Thu, 21 Nov 2019 10:53:22 -0500 Received: by mail-wr1-f72.google.com with SMTP id m17so2241225wrn.23 for ; Thu, 21 Nov 2019 07:53:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BUuMye1VWfdpQfFnouD8s7slferA7/XUjWkr0J1Q6MU=; b=qAdEo9VeYHLBdniJu0L/ezqSrze/motrNzipxxhsiGOWmIbPfxSE0DAYQlY7U14Ksh ZPuCaGPPCYYPunQniGOw6fY2bZcGFRaCzCIImHsMav1KmXrH1srtRxd3vEXlwzdR8Q9Z OE8yM1jgbQi8gljFKJBov0iKVhEEecQlHYiNUcr3kyLW86fDE9JAhqYQokjEGcl3s7GT SiHWn2GhH0Ctqn9uDCwTEEFbiVcfuCijJDaYAMFiwKTtpAzO2qanzqcYU9H9yWJtj6K3 U7j1wzwrypqDGd3oCVNt3V88XLA0SrwYc3Hk3M1QMNRiksSNacRNaEP1DHwdvDGWx7s9 5J9w== X-Gm-Message-State: APjAAAVMM4LBX57qhA8sB2CBmlTXPiL+IwkNXp8GZBMcaPlZtN+ik5Wi 4Xyg3iH6CPM4u3UVBJGsWClSUrTmnin0p2KDKN6GqixSNkUnd92iHTR0VZGpfTUKC9LgxyjK/AE C+GT4tg9luisJVw== X-Received: by 2002:a1c:9986:: with SMTP id b128mr3762639wme.154.1574351601046; Thu, 21 Nov 2019 07:53:21 -0800 (PST) X-Google-Smtp-Source: APXvYqzleem8jflabfmPdA5zxBPwW/4S5oUJ2J1pqW+FXNT7Og95K+cVXkN7bwuasq53K4dqgpF6+Q== X-Received: by 2002:a1c:9986:: with SMTP id b128mr3762623wme.154.1574351600871; Thu, 21 Nov 2019 07:53:20 -0800 (PST) Return-Path: Received: from [192.168.1.35] (131.red-88-21-102.staticip.rima-tde.net. [88.21.102.131]) by smtp.gmail.com with ESMTPSA id y78sm42422wmd.32.2019.11.21.07.53.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Nov 2019 07:53:20 -0800 (PST) Subject: Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/VariableSmmRuntimeDxe.inf: list local header "Variable.h" To: devel@edk2.groups.io, lersek@redhat.com Cc: Hao A Wu , Jian J Wang , Leif Lindholm , Liming Gao , Michael Kubacki References: <20191121093833.13840-1-lersek@redhat.com> <20191121093833.13840-2-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Thu, 21 Nov 2019 16:53:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191121093833.13840-2-lersek@redhat.com> X-MC-Unique: CydtIr78N5SZaPQ0-3H71Q-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable On 11/21/19 10:38 AM, Laszlo Ersek via Groups.Io wrote: > Commit aab3b9b9a1e5 ("MdeModulePkg/Variable: Add RT GetVariable() cache > support", 2019-11-05) added "VariableParsing.h" to > "VariableSmmRuntimeDxe.inf". >=20 > "VariableParsing.h" includes "Variable.h", so the "build" utility is righ= t > to warn us that "Variable.h" should be listed in [Sources] too. >=20 > Cc: Hao A Wu > Cc: Jian J Wang > Cc: Leif Lindholm > Cc: Liming Gao > Cc: Michael Kubacki > Fixes: aab3b9b9a1e5e1f3fa966fb1667fc3e6c47e7706 > Signed-off-by: Laszlo Ersek > --- >=20 > Notes: > Targeting edk2-stable201911. >=20 > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf | = 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntim= eDxe.inf b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe= .inf > index a250533a534f..592862773390 100644 > --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.in= f > +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.in= f > @@ -41,6 +41,7 @@ [Sources] > Measurement.c > VariableParsing.c > VariableParsing.h > + Variable.h > =20 > [Packages] > MdePkg/MdePkg.dec >=20 Reviewed-by: Philippe Mathieu-Daude