On Sat, 2023-11-11 at 00:57 +0100, Laszlo Ersek wrote: > NullMemoryTestDxe was included in the OVMF platforms in historical > commit > 999a815e9ff3 ("OvmfPkg: Add NullMemoryTestDxe driver", 2011-01-21). > It > produces gEfiGenericMemTestProtocolGuid. With LegacyBiosDxe gone, the > only > consumer of this protocol in all of edk2 is > "EmulatorPkg/Library/PlatformBmLib/PlatformBmMemoryTest.c". Thus, > exclude > NullMemoryTestDxe from all OVMF platforms. > > (Notably, ArmVirtPkg platforms don't include NullMemoryTestDxe > either.) > > Cc: Anatol Belski > Cc: Andrei Warkentin > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Corvin Köhne > Cc: Erdem Aktas > Cc: Gerd Hoffmann > Cc: Jianyong Wu > Cc: Jiewen Yao > Cc: Michael Roth > Cc: Min Xu > Cc: Rebecca Cran > Cc: Sunil V L > Cc: Tom Lendacky > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588 > Signed-off-by: Laszlo Ersek > --- >  OvmfPkg/AmdSev/AmdSevX64.dsc        | 1 - >  OvmfPkg/Bhyve/BhyveX64.dsc          | 1 - >  OvmfPkg/CloudHv/CloudHvX64.dsc      | 1 - >  OvmfPkg/IntelTdx/IntelTdxX64.dsc    | 1 - >  OvmfPkg/Microvm/MicrovmX64.dsc      | 1 - >  OvmfPkg/OvmfPkgIa32.dsc             | 1 - >  OvmfPkg/OvmfPkgIa32X64.dsc          | 1 - >  OvmfPkg/OvmfPkgX64.dsc              | 1 - >  OvmfPkg/OvmfXen.dsc                 | 1 - >  OvmfPkg/AmdSev/AmdSevX64.fdf        | 1 - >  OvmfPkg/Bhyve/BhyveX64.fdf          | 1 - >  OvmfPkg/CloudHv/CloudHvX64.fdf      | 1 - >  OvmfPkg/IntelTdx/IntelTdxX64.fdf    | 1 - >  OvmfPkg/Microvm/MicrovmX64.fdf      | 1 - >  OvmfPkg/OvmfPkgIa32.fdf             | 1 - >  OvmfPkg/OvmfPkgIa32X64.fdf          | 1 - >  OvmfPkg/OvmfPkgX64.fdf              | 1 - >  OvmfPkg/OvmfXen.fdf                 | 1 - >  OvmfPkg/RiscVVirt/RiscVVirtQemu.fdf | 2 -- >  19 files changed, 20 deletions(-) > > diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc > b/OvmfPkg/AmdSev/AmdSevX64.dsc > index 302c90e7c2b4..a00f4c12904c 100644 > --- a/OvmfPkg/AmdSev/AmdSevX64.dsc > +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc > @@ -691,7 +691,6 @@ [Components] >    MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf >    MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf >    MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > -  > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe > .inf >   >    OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf >    OvmfPkg/QemuRamfbDxe/QemuRamfbDxe.inf > diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc > index c938ed76ee92..a3452efc5a84 100644 > --- a/OvmfPkg/Bhyve/BhyveX64.dsc > +++ b/OvmfPkg/Bhyve/BhyveX64.dsc > @@ -711,7 +711,6 @@ [Components] >    MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf >    MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf >    MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > -  > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe > .inf >   >    OvmfPkg/Bhyve/BhyveRfbDxe/BhyveRfbDxe.inf { >      > diff --git a/OvmfPkg/CloudHv/CloudHvX64.dsc > b/OvmfPkg/CloudHv/CloudHvX64.dsc > index c23c7eaf6cc2..f6e4b2c628a3 100644 > --- a/OvmfPkg/CloudHv/CloudHvX64.dsc > +++ b/OvmfPkg/CloudHv/CloudHvX64.dsc > @@ -795,7 +795,6 @@ [Components] >    MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf >    MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf >    MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > -  > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe > .inf >   >    # >    # Serial Support > diff --git a/OvmfPkg/IntelTdx/IntelTdxX64.dsc > b/OvmfPkg/IntelTdx/IntelTdxX64.dsc > index 0177c174c2ab..af0ecb0453ea 100644 > --- a/OvmfPkg/IntelTdx/IntelTdxX64.dsc > +++ b/OvmfPkg/IntelTdx/IntelTdxX64.dsc > @@ -682,7 +682,6 @@ [Components] >    MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf >    MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf >    MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > -  > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe > .inf >   >    OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf >    OvmfPkg/QemuRamfbDxe/QemuRamfbDxe.inf > diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc > b/OvmfPkg/Microvm/MicrovmX64.dsc > index ea1fa3e2963f..75c53c0bb287 100644 > --- a/OvmfPkg/Microvm/MicrovmX64.dsc > +++ b/OvmfPkg/Microvm/MicrovmX64.dsc > @@ -787,7 +787,6 @@ [Components] >    MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf >    MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf >    MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > -  > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe > .inf >   >    OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf >    OvmfPkg/QemuRamfbDxe/QemuRamfbDxe.inf > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index 3005ef771bea..eb6022bafed3 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -841,7 +841,6 @@ [Components] >    MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf >    MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf >    MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > -  > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe > .inf >   >    OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf >    OvmfPkg/QemuRamfbDxe/QemuRamfbDxe.inf > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index 1f144b07a650..5f63596eeb2c 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -855,7 +855,6 @@ [Components.X64] >    MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf >    MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf >    MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > -  > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe > .inf >   >    OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf >    OvmfPkg/QemuRamfbDxe/QemuRamfbDxe.inf > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index ce932301aff1..4dcda2ab17c2 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -923,7 +923,6 @@ [Components] >    MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf >    MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf >    MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > -  > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe > .inf >   >    OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf >    OvmfPkg/QemuRamfbDxe/QemuRamfbDxe.inf > diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc > index 0e2548d964bc..ddcc1d7ad48c 100644 > --- a/OvmfPkg/OvmfXen.dsc > +++ b/OvmfPkg/OvmfXen.dsc > @@ -647,7 +647,6 @@ [Components] >    MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf >    MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf >    MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > -  > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe > .inf >   >    OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf >    OvmfPkg/QemuRamfbDxe/QemuRamfbDxe.inf > diff --git a/OvmfPkg/AmdSev/AmdSevX64.fdf > b/OvmfPkg/AmdSev/AmdSevX64.fdf > index b2ab0c777320..93657bfd6547 100644 > --- a/OvmfPkg/AmdSev/AmdSevX64.fdf > +++ b/OvmfPkg/AmdSev/AmdSevX64.fdf > @@ -257,7 +257,6 @@ [FV.DXEFV] >  INF  MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf >  INF  MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf >  INF  MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > -INF  > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe > .inf >   >  INF  OvmfPkg/SioBusDxe/SioBusDxe.inf >  !if $(SOURCE_DEBUG_ENABLE) == FALSE > diff --git a/OvmfPkg/Bhyve/BhyveX64.fdf b/OvmfPkg/Bhyve/BhyveX64.fdf > index b465fea7c72d..8b5aa46a1e33 100644 > --- a/OvmfPkg/Bhyve/BhyveX64.fdf > +++ b/OvmfPkg/Bhyve/BhyveX64.fdf > @@ -249,7 +249,6 @@ [FV.DXEFV] >  INF  MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf >  INF  MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf >  INF  MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > -INF  > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe > .inf >   >   >  INF  OvmfPkg/SioBusDxe/SioBusDxe.inf > diff --git a/OvmfPkg/CloudHv/CloudHvX64.fdf > b/OvmfPkg/CloudHv/CloudHvX64.fdf > index 387f305ed8cf..eac6557e6b74 100644 > --- a/OvmfPkg/CloudHv/CloudHvX64.fdf > +++ b/OvmfPkg/CloudHv/CloudHvX64.fdf > @@ -269,7 +269,6 @@ [FV.DXEFV] >  INF  MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf >  INF  MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf >  INF  MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > -INF  > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe > .inf >   >  INF  MdeModulePkg/Universal/SerialDxe/SerialDxe.inf >   > diff --git a/OvmfPkg/IntelTdx/IntelTdxX64.fdf > b/OvmfPkg/IntelTdx/IntelTdxX64.fdf > index 69ed7a9bc6f4..69074cfb1e73 100644 > --- a/OvmfPkg/IntelTdx/IntelTdxX64.fdf > +++ b/OvmfPkg/IntelTdx/IntelTdxX64.fdf > @@ -300,7 +300,6 @@ [FV.NCCFV] >  INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >  INF  MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf >  INF  MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf > -INF  > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe > .inf >  INF  MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf >  INF  MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf >  INF  > MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/BootScriptExecutorD > xe.inf > diff --git a/OvmfPkg/Microvm/MicrovmX64.fdf > b/OvmfPkg/Microvm/MicrovmX64.fdf > index eda24a3ec9bc..a9b6618ca811 100644 > --- a/OvmfPkg/Microvm/MicrovmX64.fdf > +++ b/OvmfPkg/Microvm/MicrovmX64.fdf > @@ -236,7 +236,6 @@ [FV.DXEFV] >  INF  MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf >  INF  MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf >  INF  MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > -INF  > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe > .inf >   >  !if $(SOURCE_DEBUG_ENABLE) == FALSE >  INF  MdeModulePkg/Universal/SerialDxe/SerialDxe.inf > diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf > index 996c116e418a..d55a6e1590d0 100644 > --- a/OvmfPkg/OvmfPkgIa32.fdf > +++ b/OvmfPkg/OvmfPkgIa32.fdf > @@ -278,7 +278,6 @@ [FV.DXEFV] >  INF  MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf >  INF  MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf >  INF  MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > -INF  > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe > .inf >   >  INF  OvmfPkg/SioBusDxe/SioBusDxe.inf >  !if $(SOURCE_DEBUG_ENABLE) == FALSE > diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf > index 36727965798e..d9ae001a669d 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.fdf > +++ b/OvmfPkg/OvmfPkgIa32X64.fdf > @@ -279,7 +279,6 @@ [FV.DXEFV] >  INF  MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf >  INF  MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf >  INF  MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > -INF  > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe > .inf >   >  INF  OvmfPkg/SioBusDxe/SioBusDxe.inf >  !if $(SOURCE_DEBUG_ENABLE) == FALSE > diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf > index 1000707d8c9a..2eeef4b5a4df 100644 > --- a/OvmfPkg/OvmfPkgX64.fdf > +++ b/OvmfPkg/OvmfPkgX64.fdf > @@ -304,7 +304,6 @@ [FV.DXEFV] >  INF  MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf >  INF  MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf >  INF  MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > -INF  > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe > .inf >   >  INF  OvmfPkg/SioBusDxe/SioBusDxe.inf >  !if $(SOURCE_DEBUG_ENABLE) == FALSE > diff --git a/OvmfPkg/OvmfXen.fdf b/OvmfPkg/OvmfXen.fdf > index ce825b01b48b..46b688d1d05b 100644 > --- a/OvmfPkg/OvmfXen.fdf > +++ b/OvmfPkg/OvmfXen.fdf > @@ -286,7 +286,6 @@ [FV.DXEFV] >  INF  MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf >  INF  MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf >  INF  MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > -INF  > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe > .inf >   >  INF  OvmfPkg/SioBusDxe/SioBusDxe.inf >  !if $(SOURCE_DEBUG_ENABLE) == FALSE > diff --git a/OvmfPkg/RiscVVirt/RiscVVirtQemu.fdf > b/OvmfPkg/RiscVVirt/RiscVVirtQemu.fdf > index 40d12e0f4c46..8121b9e57967 100644 > --- a/OvmfPkg/RiscVVirt/RiscVVirtQemu.fdf > +++ b/OvmfPkg/RiscVVirt/RiscVVirtQemu.fdf > @@ -218,8 +218,6 @@ [FV.DXEFV] >  # >  INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >   > -#INF  > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe > .inf > - >  #################################################################### > ############ >   >  [FV.FVMAIN_COMPACT] > Hi, for some reasons, this patch causes issues on bhyve when booting a Windows VM. The Windows bootloader seems to crash on boot. I do see the UEFI logo, then the load circle of the Windows bootloader appears and then the screen goes black. Reverting this patch solves the issue and Windows boots fine. The issue only occurs when using PCI passthrough devices, namely GPU, USB and NIC. We see this issue in our CI and I haven't reproduced it locally yet. Will do so to be able to investigate it more easily. Any ideas why this patch affects Windows guests? -- Kind regards, Corvin -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118198): https://edk2.groups.io/g/devel/message/118198 Mute This Topic: https://groups.io/mt/102518658/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-