From: "Laszlo Ersek" <lersek@redhat.com>
To: Zhichao Gao <zhichao.gao@intel.com>, devel@edk2.groups.io
Cc: Jordan Justen <jordan.l.justen@intel.com>,
Ard Biesheuvel <ard.biesheuvel@arm.com>,
Sami Mujawar <sami.mujawar@arm.com>,
Leif Lindholm <leif@nuviainc.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Jian J Wang <jian.j.wang@intel.com>,
Xiaoyu Lu <xiaoyux.lu@intel.com>,
Guomin Jiang <guomin.jiang@intel.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Kelly Steele <kelly.steele@intel.com>,
Zailiang Sun <zailiang.sun@intel.com>,
Yi Qian <yi.qian@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Maciej Rabeda <maciej.rabeda@linux.intel.com>,
Jiaxin Wu <jiaxin.wu@intel.com>, Siyuan Fu <siyuan.fu@intel.com>
Subject: Re: [PATCH V3 11/12] NetworkPkg/Defines: Make iSCSI disable as default
Date: Wed, 11 Nov 2020 23:11:02 +0100 [thread overview]
Message-ID: <bf8efc9f-7da6-9e13-ebc6-c1fece8fd233@redhat.com> (raw)
In-Reply-To: <20201110173651.54036-12-zhichao.gao@intel.com>
On 11/10/20 18:36, Zhichao Gao wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3003
>
> iSCSI is using the undeprecated function MD5. It is
(1) I think you meant "deprecated"
> better to make the default setting secure. If the platforms
> want to use the iSCSI, they should enable it in the platforms'
> dsc file and be aware they are using an unsafe function.
(2) I suggest replacing "unsafe function" with "function with weak
cryptography".
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Kelly Steele <kelly.steele@intel.com>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
> NetworkPkg/NetworkDefines.dsc.inc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/NetworkPkg/NetworkDefines.dsc.inc b/NetworkPkg/NetworkDefines.dsc.inc
> index a442d1b157..18921d81f6 100644
> --- a/NetworkPkg/NetworkDefines.dsc.inc
> +++ b/NetworkPkg/NetworkDefines.dsc.inc
> @@ -17,7 +17,7 @@
> # DEFINE NETWORK_TLS_ENABLE = TRUE
> # DEFINE NETWORK_HTTP_BOOT_ENABLE = TRUE
> # DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = FALSE
> -# DEFINE NETWORK_ISCSI_ENABLE = TRUE
> +# DEFINE NETWORK_ISCSI_ENABLE = FALSE
> # DEFINE NETWORK_VLAN_ENABLE = TRUE
> #
> # Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> @@ -101,7 +101,7 @@
> # Both OpensslLib.inf and OpensslLibCrypto.inf library instance can be used
> # since libssl is not required for iSCSI.
> #
> - DEFINE NETWORK_ISCSI_ENABLE = TRUE
> + DEFINE NETWORK_ISCSI_ENABLE = FALSE
> !endif
>
> !if $(NETWORK_ENABLE) == TRUE
>
With the above commit message updates:
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks
Laszlo
next prev parent reply other threads:[~2020-11-11 22:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 17:36 [PATCH V3 00/12] Disable the deprecated MD5 and SHA1 support Gao, Zhichao
2020-11-10 17:36 ` [PATCH V3 01/12] SecurityPkg/Hash2DxeCrypto: Remove MD5 support Gao, Zhichao
2020-11-10 17:36 ` [PATCH V3 02/12] SecurityPkg/Hash2DxeCrypto: Remove SHA1 support Gao, Zhichao
2020-11-10 17:36 ` [PATCH V3 03/12] CryptoPkg/dsc: Enable MD5 when CRYPTO_SERVICES enable MD5 Gao, Zhichao
2020-11-11 22:21 ` [edk2-devel] " Laszlo Ersek
2020-11-10 17:36 ` [PATCH V3 04/12] NetworkPkg: Enable MD5 while enable iSCSI Gao, Zhichao
2020-11-11 22:18 ` [edk2-devel] " Laszlo Ersek
2020-11-10 17:36 ` [PATCH V3 05/12] ArmVirtPkg/ArmVirtQemu.dsc: " Gao, Zhichao
2020-11-11 21:53 ` Laszlo Ersek
2020-11-10 17:36 ` [PATCH V3 06/12] ArmVirtPkg/ArmVirtQemuKernel.dsc: " Gao, Zhichao
2020-11-11 21:58 ` Laszlo Ersek
2020-11-10 17:36 ` [PATCH V3 07/12] OvmfPkg/OvmfPkgIa32.dsc: " Gao, Zhichao
2020-11-11 22:05 ` Laszlo Ersek
2020-11-10 17:36 ` [PATCH V3 08/12] OvmfPkg/OvmfPkgIa32X64.dsc: " Gao, Zhichao
2020-11-10 17:36 ` [PATCH V3 09/12] OvmfPkg/OvmfPkgX64.dsc: " Gao, Zhichao
2020-11-10 17:36 ` [PATCH V3 10/12] OvmfPkg/BhyveX64.dsc: " Gao, Zhichao
2020-11-10 17:36 ` [PATCH V3 11/12] NetworkPkg/Defines: Make iSCSI disable as default Gao, Zhichao
2020-11-11 22:11 ` Laszlo Ersek [this message]
2020-11-10 17:36 ` [PATCH V3 12/12] CryptoPkg: Make the MD5 disable as default for security Gao, Zhichao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf8efc9f-7da6-9e13-ebc6-c1fece8fd233@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox