From: "Sunil V L" <sunilvl@ventanamicro.com>
To: devel@edk2.groups.io
Cc: Abner Chang <abner.chang@amd.com>,
Zhihao Li <zhihao.li@intel.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Zhiguang Liu <zhiguang.liu@intel.com>,
Daniel Schaefer <git@danielschaefer.me>
Subject: [PATCH 1/1] BaseSynchronizationLib: Fix RISC-V helper name
Date: Fri, 11 Nov 2022 16:51:06 +0530 [thread overview]
Message-ID: <bfac207da93ebd259e3ba71c2683a773242df7e2.1668165453.git.sunilvl@ventanamicro.com> (raw)
In-Reply-To: <cover.1668165453.git.sunilvl@ventanamicro.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4143
Fix the name of InternalSyncCompareExchange64() function.
Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
Reported-by: Zhihao Li <zhihao.li@intel.com>
Tested-by: Zhihao Li <zhihao.li@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Daniel Schaefer <git@danielschaefer.me>
---
.../Library/BaseSynchronizationLib/BaseSynchronizationLib.inf | 2 +-
.../Library/BaseSynchronizationLib/RiscV64/Synchronization.S | 4 +---
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf b/MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
index dd66ec1d0370..88dfb880fea9 100755
--- a/MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
+++ b/MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
@@ -81,7 +81,7 @@ [Sources.AARCH64]
[Sources.RISCV64]
Synchronization.c
- RiscV64/Synchronization.S
+ RiscV64/Synchronization.S | GCC
[Sources.LOONGARCH64]
Synchronization.c
diff --git a/MdePkg/Library/BaseSynchronizationLib/RiscV64/Synchronization.S b/MdePkg/Library/BaseSynchronizationLib/RiscV64/Synchronization.S
index bac80d687168..f287ef38f651 100644
--- a/MdePkg/Library/BaseSynchronizationLib/RiscV64/Synchronization.S
+++ b/MdePkg/Library/BaseSynchronizationLib/RiscV64/Synchronization.S
@@ -36,8 +36,6 @@ exit:
mv a0, a3
ret
-.global ASM_PFX(InternalSyncCompareExchange64)
-
//
// Compare and xchange a 64-bit value.
//
@@ -45,7 +43,7 @@ exit:
// @param a1 : Compare value.
// @param a2 : Exchange value.
//
-ASM_PFX (SyncCompareExchange64):
+ASM_PFX (InternalSyncCompareExchange64):
lr.d a3, (a0) // Load the value from a0 and make
// the reservation of address.
bne a3, a1, exit
--
2.38.0
next parent reply other threads:[~2022-11-11 11:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1668165453.git.sunilvl@ventanamicro.com>
2022-11-11 11:21 ` Sunil V L [this message]
2022-11-29 5:45 ` 回复: [edk2-devel] [PATCH 1/1] BaseSynchronizationLib: Fix RISC-V helper name gaoliming
[not found] ` <172BF7F72236D76C.11309@groups.io>
2022-11-29 9:30 ` gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfac207da93ebd259e3ba71c2683a773242df7e2.1668165453.git.sunilvl@ventanamicro.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox