* [PATCH 1/1] BaseSynchronizationLib: Fix RISC-V helper name [not found] <cover.1668165453.git.sunilvl@ventanamicro.com> @ 2022-11-11 11:21 ` Sunil V L 2022-11-29 5:45 ` 回复: [edk2-devel] " gaoliming [not found] ` <172BF7F72236D76C.11309@groups.io> 0 siblings, 2 replies; 3+ messages in thread From: Sunil V L @ 2022-11-11 11:21 UTC (permalink / raw) To: devel Cc: Abner Chang, Zhihao Li, Michael D Kinney, Liming Gao, Zhiguang Liu, Daniel Schaefer REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4143 Fix the name of InternalSyncCompareExchange64() function. Signed-off-by: Sunil V L <sunilvl@ventanamicro.com> Reported-by: Zhihao Li <zhihao.li@intel.com> Tested-by: Zhihao Li <zhihao.li@intel.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Zhiguang Liu <zhiguang.liu@intel.com> Cc: Daniel Schaefer <git@danielschaefer.me> --- .../Library/BaseSynchronizationLib/BaseSynchronizationLib.inf | 2 +- .../Library/BaseSynchronizationLib/RiscV64/Synchronization.S | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf b/MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf index dd66ec1d0370..88dfb880fea9 100755 --- a/MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf +++ b/MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf @@ -81,7 +81,7 @@ [Sources.AARCH64] [Sources.RISCV64] Synchronization.c - RiscV64/Synchronization.S + RiscV64/Synchronization.S | GCC [Sources.LOONGARCH64] Synchronization.c diff --git a/MdePkg/Library/BaseSynchronizationLib/RiscV64/Synchronization.S b/MdePkg/Library/BaseSynchronizationLib/RiscV64/Synchronization.S index bac80d687168..f287ef38f651 100644 --- a/MdePkg/Library/BaseSynchronizationLib/RiscV64/Synchronization.S +++ b/MdePkg/Library/BaseSynchronizationLib/RiscV64/Synchronization.S @@ -36,8 +36,6 @@ exit: mv a0, a3 ret -.global ASM_PFX(InternalSyncCompareExchange64) - // // Compare and xchange a 64-bit value. // @@ -45,7 +43,7 @@ exit: // @param a1 : Compare value. // @param a2 : Exchange value. // -ASM_PFX (SyncCompareExchange64): +ASM_PFX (InternalSyncCompareExchange64): lr.d a3, (a0) // Load the value from a0 and make // the reservation of address. bne a3, a1, exit -- 2.38.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* 回复: [edk2-devel] [PATCH 1/1] BaseSynchronizationLib: Fix RISC-V helper name 2022-11-11 11:21 ` [PATCH 1/1] BaseSynchronizationLib: Fix RISC-V helper name Sunil V L @ 2022-11-29 5:45 ` gaoliming [not found] ` <172BF7F72236D76C.11309@groups.io> 1 sibling, 0 replies; 3+ messages in thread From: gaoliming @ 2022-11-29 5:45 UTC (permalink / raw) To: devel, sunilvl Cc: 'Abner Chang', 'Zhihao Li', 'Michael D Kinney', 'Zhiguang Liu', 'Daniel Schaefer' Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Sunil V L > 发送时间: 2022年11月11日 19:21 > 收件人: devel@edk2.groups.io > 抄送: Abner Chang <abner.chang@amd.com>; Zhihao Li > <zhihao.li@intel.com>; Michael D Kinney <michael.d.kinney@intel.com>; > Liming Gao <gaoliming@byosoft.com.cn>; Zhiguang Liu > <zhiguang.liu@intel.com>; Daniel Schaefer <git@danielschaefer.me> > 主题: [edk2-devel] [PATCH 1/1] BaseSynchronizationLib: Fix RISC-V helper > name > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4143 > > Fix the name of InternalSyncCompareExchange64() function. > > Signed-off-by: Sunil V L <sunilvl@ventanamicro.com> > Reported-by: Zhihao Li <zhihao.li@intel.com> > Tested-by: Zhihao Li <zhihao.li@intel.com> > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Zhiguang Liu <zhiguang.liu@intel.com> > Cc: Daniel Schaefer <git@danielschaefer.me> > --- > .../Library/BaseSynchronizationLib/BaseSynchronizationLib.inf | 2 +- > .../Library/BaseSynchronizationLib/RiscV64/Synchronization.S | 4 +--- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git > a/MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf > b/MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf > index dd66ec1d0370..88dfb880fea9 100755 > --- a/MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf > +++ b/MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf > @@ -81,7 +81,7 @@ [Sources.AARCH64] > > [Sources.RISCV64] > Synchronization.c > - RiscV64/Synchronization.S > + RiscV64/Synchronization.S | GCC > > [Sources.LOONGARCH64] > Synchronization.c > diff --git > a/MdePkg/Library/BaseSynchronizationLib/RiscV64/Synchronization.S > b/MdePkg/Library/BaseSynchronizationLib/RiscV64/Synchronization.S > index bac80d687168..f287ef38f651 100644 > --- a/MdePkg/Library/BaseSynchronizationLib/RiscV64/Synchronization.S > +++ b/MdePkg/Library/BaseSynchronizationLib/RiscV64/Synchronization.S > @@ -36,8 +36,6 @@ exit: > mv a0, a3 > ret > > -.global ASM_PFX(InternalSyncCompareExchange64) > - > // > // Compare and xchange a 64-bit value. > // > @@ -45,7 +43,7 @@ exit: > // @param a1 : Compare value. > // @param a2 : Exchange value. > // > -ASM_PFX (SyncCompareExchange64): > +ASM_PFX (InternalSyncCompareExchange64): > lr.d a3, (a0) // Load the value from a0 and make > // the reservation of address. > bne a3, a1, exit > -- > 2.38.0 > > > > > ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <172BF7F72236D76C.11309@groups.io>]
* 回复: [edk2-devel] [PATCH 1/1] BaseSynchronizationLib: Fix RISC-V helper name [not found] ` <172BF7F72236D76C.11309@groups.io> @ 2022-11-29 9:30 ` gaoliming 0 siblings, 0 replies; 3+ messages in thread From: gaoliming @ 2022-11-29 9:30 UTC (permalink / raw) To: devel, gaoliming, sunilvl Cc: 'Abner Chang', 'Zhihao Li', 'Michael D Kinney', 'Zhiguang Liu', 'Daniel Schaefer' Create PR https://github.com/tianocore/edk2/pull/3676 for this patch. > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 gaoliming via > groups.io > 发送时间: 2022年11月29日 13:45 > 收件人: devel@edk2.groups.io; sunilvl@ventanamicro.com > 抄送: 'Abner Chang' <abner.chang@amd.com>; 'Zhihao Li' > <zhihao.li@intel.com>; 'Michael D Kinney' <michael.d.kinney@intel.com>; > 'Zhiguang Liu' <zhiguang.liu@intel.com>; 'Daniel Schaefer' > <git@danielschaefer.me> > 主题: 回复: [edk2-devel] [PATCH 1/1] BaseSynchronizationLib: Fix RISC-V > helper name > > Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> > > > -----邮件原件----- > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Sunil V L > > 发送时间: 2022年11月11日 19:21 > > 收件人: devel@edk2.groups.io > > 抄送: Abner Chang <abner.chang@amd.com>; Zhihao Li > > <zhihao.li@intel.com>; Michael D Kinney <michael.d.kinney@intel.com>; > > Liming Gao <gaoliming@byosoft.com.cn>; Zhiguang Liu > > <zhiguang.liu@intel.com>; Daniel Schaefer <git@danielschaefer.me> > > 主题: [edk2-devel] [PATCH 1/1] BaseSynchronizationLib: Fix RISC-V helper > > name > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4143 > > > > Fix the name of InternalSyncCompareExchange64() function. > > > > Signed-off-by: Sunil V L <sunilvl@ventanamicro.com> > > Reported-by: Zhihao Li <zhihao.li@intel.com> > > Tested-by: Zhihao Li <zhihao.li@intel.com> > > > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > > Cc: Liming Gao <gaoliming@byosoft.com.cn> > > Cc: Zhiguang Liu <zhiguang.liu@intel.com> > > Cc: Daniel Schaefer <git@danielschaefer.me> > > --- > > .../Library/BaseSynchronizationLib/BaseSynchronizationLib.inf | 2 +- > > .../Library/BaseSynchronizationLib/RiscV64/Synchronization.S | 4 +--- > > 2 files changed, 2 insertions(+), 4 deletions(-) > > > > diff --git > > a/MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf > > b/MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf > > index dd66ec1d0370..88dfb880fea9 100755 > > --- a/MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf > > +++ b/MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf > > @@ -81,7 +81,7 @@ [Sources.AARCH64] > > > > [Sources.RISCV64] > > Synchronization.c > > - RiscV64/Synchronization.S > > + RiscV64/Synchronization.S | GCC > > > > [Sources.LOONGARCH64] > > Synchronization.c > > diff --git > > a/MdePkg/Library/BaseSynchronizationLib/RiscV64/Synchronization.S > > b/MdePkg/Library/BaseSynchronizationLib/RiscV64/Synchronization.S > > index bac80d687168..f287ef38f651 100644 > > --- a/MdePkg/Library/BaseSynchronizationLib/RiscV64/Synchronization.S > > +++ b/MdePkg/Library/BaseSynchronizationLib/RiscV64/Synchronization.S > > @@ -36,8 +36,6 @@ exit: > > mv a0, a3 > > ret > > > > -.global ASM_PFX(InternalSyncCompareExchange64) > > - > > // > > // Compare and xchange a 64-bit value. > > // > > @@ -45,7 +43,7 @@ exit: > > // @param a1 : Compare value. > > // @param a2 : Exchange value. > > // > > -ASM_PFX (SyncCompareExchange64): > > +ASM_PFX (InternalSyncCompareExchange64): > > lr.d a3, (a0) // Load the value from a0 and make > > // the reservation of address. > > bne a3, a1, exit > > -- > > 2.38.0 > > > > > > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-29 9:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1668165453.git.sunilvl@ventanamicro.com>
2022-11-11 11:21 ` [PATCH 1/1] BaseSynchronizationLib: Fix RISC-V helper name Sunil V L
2022-11-29 5:45 ` 回复: [edk2-devel] " gaoliming
[not found] ` <172BF7F72236D76C.11309@groups.io>
2022-11-29 9:30 ` gaoliming
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox