From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smarthost01b.ixn.mail.zen.net.uk (smarthost01b.ixn.mail.zen.net.uk [212.23.1.21]) by mx.groups.io with SMTP id smtpd.web08.5297.1647006084561062087 for ; Fri, 11 Mar 2022 05:41:24 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=permerror, err=parse error for token &{10 18 sdn.klaviyomail.com}: permanent DNS error (domain: starlabs.systems, ip: 212.23.1.21, mailfrom: sean@starlabs.systems) Received: from [51.148.147.4] (helo=sean-StarBook.lan) by smarthost01b.ixn.mail.zen.net.uk with esmtp (Exim 4.90_1) (envelope-from ) id 1nSfWB-0003Ek-NA; Fri, 11 Mar 2022 13:41:19 +0000 From: "Sean Rhodes" To: devel@edk2.groups.io Cc: Guo Dong , Ray Ni , Maurice Ma , Benjamin You Subject: [PATCH] UefiPayloadPkg: Fix build error Date: Fri, 11 Mar 2022 13:41:17 +0000 Message-Id: X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Originating-smarthost01b-IP: [51.148.147.4] Feedback-ID: 51.148.147.4 Content-Transfer-Encoding: quoted-printable From: Guo Dong On windows build, need add -DPLATFORMX64_ENABLE=3DTRUE in the build command line beside -DNETWORK_DRIVER_ENABLE=3DTRUE in order build network features. So set PLATFORMX64_ENABLE to TRUE when need build network feature. On Linux build, DSC file should not have PcdAllowHttpConnections when network feature is not built, else would cause build error. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: Guo Dong --- UefiPayloadPkg/UefiPayloadPkg.dsc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayload= Pkg.dsc index 558513baf1..f3806a8ebc 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dsc +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc @@ -407,7 +407,9 @@ [PcdsPatchableInModule.X64]=0D gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|$(RTC_INDEX_REGISTER)= =0D gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|$(RTC_TARGET_REGISTER= )=0D +!if $(NETWORK_DRIVER_ENABLE) =3D=3D TRUE=0D gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE=0D +!endif=0D =0D [PcdsPatchableInModule.common]=0D gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c= , 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0= x31 }=0D @@ -530,6 +532,8 @@ # UEFI network modules=0D #=0D !if $(NETWORK_DRIVER_ENABLE) =3D=3D TRUE=0D +[Defines]=0D + DEFINE PLATFORMX64_ENABLE =3D TRUE=0D !include NetworkPkg/Network.dsc.inc=0D !endif=0D =0D --=20 2.32.0