public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Mohammad Younas Khan Pathan <pmdyounaskhan786@gmail.com>,
	edk2-devel@lists.01.org
Subject: Re: Bug 843 - Need to remove unnecessary return statements in void functions of EDKII.
Date: Wed, 6 Jun 2018 22:12:00 +0200	[thread overview]
Message-ID: <bfb3e278-8504-18ea-8d49-bef9217b2816@redhat.com> (raw)
In-Reply-To: <CAN9uzBn73V6DZ49Ha+r0KwK+1U6MtZaQrN+ccBAa_RHrh0fsHw@mail.gmail.com>

Hello Younas,

On 06/06/18 10:28, Mohammad Younas Khan Pathan wrote:
> Hi all,
> 
> I have updated the changes after removing all the unecessary return
> statements in EDKII packages.
> 
> I have created EDKIIBug843 branch under master.
> Also attached the changes here.
> 
> Please help to review and share your comments.

please post your patches in-line for review -- please don't try to
attach them (to Bugzilla items or to emails); also don't paste them into
the email body. The edk2 development workflow uses the git toolset; that
set includes tools for formatting patches as emails, and for posting
those patch files as emails.

This is the official Wiki article:

https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

And this is my personal take on the matter:

https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers

Thanks,
Laszlo


  reply	other threads:[~2018-06-06 20:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-06  8:28 Bug 843 - Need to remove unnecessary return statements in void functions of EDKII Mohammad Younas Khan Pathan
2018-06-06 20:12 ` Laszlo Ersek [this message]
     [not found]   ` <CAN9uzB=UhGhveKK4=F=jiwUmc_5QO+pmROvqcjiuBQtbHjyjRg@mail.gmail.com>
2018-06-11  9:47     ` Laszlo Ersek
2018-06-11  9:56       ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bfb3e278-8504-18ea-8d49-bef9217b2816@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox