From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 11A54210F16BF
 for <edk2-devel@lists.01.org>; Wed,  6 Jun 2018 13:12:02 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com
 [10.11.54.6])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 7A353BB42F;
 Wed,  6 Jun 2018 20:12:01 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-124.rdu2.redhat.com
 [10.10.120.124])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 0AE06205D521;
 Wed,  6 Jun 2018 20:12:00 +0000 (UTC)
To: Mohammad Younas Khan Pathan <pmdyounaskhan786@gmail.com>,
 edk2-devel@lists.01.org
References: <CAN9uzBn73V6DZ49Ha+r0KwK+1U6MtZaQrN+ccBAa_RHrh0fsHw@mail.gmail.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <bfb3e278-8504-18ea-8d49-bef9217b2816@redhat.com>
Date: Wed, 6 Jun 2018 22:12:00 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <CAN9uzBn73V6DZ49Ha+r0KwK+1U6MtZaQrN+ccBAa_RHrh0fsHw@mail.gmail.com>
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.11.55.1]); Wed, 06 Jun 2018 20:12:01 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]);
 Wed, 06 Jun 2018 20:12:01 +0000 (UTC) for IP:'10.11.54.6'
 DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com'
 HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:''
Subject: Re: Bug 843 - Need to remove unnecessary return statements in void functions of EDKII.
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Jun 2018 20:12:03 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hello Younas,

On 06/06/18 10:28, Mohammad Younas Khan Pathan wrote:
> Hi all,
> 
> I have updated the changes after removing all the unecessary return
> statements in EDKII packages.
> 
> I have created EDKIIBug843 branch under master.
> Also attached the changes here.
> 
> Please help to review and share your comments.

please post your patches in-line for review -- please don't try to
attach them (to Bugzilla items or to emails); also don't paste them into
the email body. The edk2 development workflow uses the git toolset; that
set includes tools for formatting patches as emails, and for posting
those patch files as emails.

This is the official Wiki article:

https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

And this is my personal take on the matter:

https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers

Thanks,
Laszlo