From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web12.4376.1622105751710360160 for ; Thu, 27 May 2021 01:55:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BSGu7FOE; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622105750; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ycIa2x2Nd/v+Npb7rEuE1MKKCdty/Gobsixh/jrxnE8=; b=BSGu7FOEkXAq+8WqGYtVFOn+ZIhy1D7/7wIwFKwfGAc5hzsZdY+5QOIRBQYAeXP28zgkcK r14Rl+JHL5XVaCVmzRXsc4zRXea80BsIuyFy8XAHrBrHBUgEsmrkqV/TTR4in9dLwLAtLS kWVwHaTZN7PFd97BjNyWIVqe4a5ypKQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-25-DEUJtgzfPiK-3jUA9z2gkA-1; Thu, 27 May 2021 04:55:46 -0400 X-MC-Unique: DEUJtgzfPiK-3jUA9z2gkA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 89101501E6; Thu, 27 May 2021 08:55:43 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-44.ams2.redhat.com [10.36.115.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC58E5D9E2; Thu, 27 May 2021 08:55:39 +0000 (UTC) Subject: Re: [PATCH 00/43] OvmfPkg: remove Xen support from OvmfPkg*.dsc, in favor of OvmfXen.dsc To: Ard Biesheuvel Cc: devel@edk2.groups.io, Andrew Fish , Anthony Perard , Ard Biesheuvel , Brijesh Singh , Erdem Aktas , James Bottomley , Jiewen Yao , Jordan Justen , Julien Grall , Leif Lindholm , Michael D Kinney , Min Xu , Peter Grehan , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Rebecca Cran , Tom Lendacky References: <20210526201446.12554-1-lersek@redhat.com> From: "Laszlo Ersek" Message-ID: Date: Thu, 27 May 2021 10:55:38 +0200 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05/27/21 09:34, Ard Biesheuvel wrote: > On Wed, 26 May 2021 at 22:15, Laszlo Ersek wrote: >> >> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 >> Repo: https://pagure.io/lersek/edk2.git >> Branch: xen_split_bz_2122 >> >> This patch set removes dynamic Xen enlightenment from the following >> platforms: >> >> OvmfPkg/OvmfPkgIa32.dsc >> OvmfPkg/OvmfPkgIa32X64.dsc >> OvmfPkg/OvmfPkgX64.dsc >> >> In Xen guests, the following platform should be used: >> >> OvmfPkg/OvmfXen.dsc >> >> Please see more details / references in the bugzilla ticket. >> >> NOOPT build savings: >> >> - Ia32: PEIFV 1536 bytes, DXEFV 130288 bytes >> - Ia32X64: PEIFV 1536 bytes, DXEFV 140912 bytes >> - X64: PEIFV 1664 bytes, DXEFV 140912 bytes >> - Xen: PEIFV 256 bytes, DXEFV 69504 bytes >> >> Functional testing: >> >> - Booted a Fedora guest on OvmfPkgIa32X64 on QEMU/KVM, compared verbose >> logs before-after. Memory allocations were satisfied at different >> addresses, as expected, plus the Xen drivers were absent. No >> differences otherwise. >> >> - Booted a RHEL guest on ArmVirtQemu on AARCH64. Memory allocations were >> satisfied at different addresses, as expected. >> >> - Xen regression-testing was not done; I'm requesting feedback. >> >> Build testing / bisectability: at every stage, the series builds with >> the following script: >> >>> #!/bin/bash >>> set -e -u -C >>> >>> build -b DEBUG -t GCC5 -p ArmVirtPkg/ArmVirtKvmTool.dsc -a AARCH64 >>> build -b DEBUG -t GCC5 -p ArmVirtPkg/ArmVirtKvmTool.dsc -a ARM >>> build -b NOOPT -t GCC5 -p ArmVirtPkg/ArmVirtQemu.dsc -a AARCH64 >>> build -b NOOPT -t GCC5 -p ArmVirtPkg/ArmVirtQemu.dsc -a ARM >>> build -b NOOPT -t GCC5 -p ArmVirtPkg/ArmVirtQemuKernel.dsc -a AARCH64 >>> build -b NOOPT -t GCC5 -p ArmVirtPkg/ArmVirtQemuKernel.dsc -a ARM >>> build -b NOOPT -t GCC5 -p ArmVirtPkg/ArmVirtXen.dsc -a AARCH64 >>> build -b NOOPT -t GCC5 -p ArmVirtPkg/ArmVirtXen.dsc -a ARM >>> build -b NOOPT -t GCC5 -p OvmfPkg/AmdSev/AmdSevX64.dsc -a X64 >>> build -b NOOPT -t GCC5 -p OvmfPkg/Bhyve/BhyveX64.dsc -a X64 >>> build -b NOOPT -t GCC5 -p OvmfPkg/OvmfPkgIa32.dsc -a IA32 >>> build -b NOOPT -t GCC5 -p OvmfPkg/OvmfPkgIa32X64.dsc -a IA32 -a X64 >>> build -b NOOPT -t GCC5 -p OvmfPkg/OvmfPkgX64.dsc -a X64 >>> build -b NOOPT -t GCC5 -p OvmfPkg/OvmfXen.dsc -a X64 >> >> The patches in the series were formatted with the following options, for >> posting: >> >> --stat=1000 --stat-graph-width=20 --find-copies-harder -U6 >> >> (The option "--find-copies-harder" is not the best for presenting every >> single patch in the series, in isolation, but taken globally for the >> entire series, it is the most helpful option.) >> >> Some patches advance with really small steps, in order to cut down on a >> subsequent "meaty" patch. Personally I don't like reviewing code >> movement patches, so I did my best to (a) keep that to a minimum, and >> (b) present it as unintrusively as possible. >> >> The CC list is a bit long; the reason is that I kept touching up >> "Maintainers.txt", and the "OvmfPkg/Bhyve" and "OvmfPkg/AmdSev" >> platforms as well (whenever it made sense). > Thanks for taking this on. > > For the series, > > Reviewed-by: Ard Biesheuvel Thank you, Ard! I hope the large patch count (with the small patch bodies and the not-so-short commit messages) didn't get on your nerves! I really did make an effort to find a good balance. E.g. in the "clean up and sort #includes & INF files" patches. Thank you again! Laszlo