From: Laszlo Ersek <lersek@redhat.com>
To: shenglei <shenglei.zhang@intel.com>, edk2-devel@lists.01.org
Cc: Ruiyu Ni <ruiyu.ni@intel.com>, Andrew Fish <afish@apple.com>,
"Leif Lindholm (Linaro address)" <leif.lindholm@linaro.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH] FatBinPkg: Remove FatBinPkg and modify document
Date: Wed, 17 Oct 2018 13:18:09 +0200 [thread overview]
Message-ID: <bff36ed9-a19d-a3a7-255a-5e766b8807f8@redhat.com> (raw)
In-Reply-To: <20181016071151.33440-1-shenglei.zhang@intel.com>
On 10/16/18 09:11, shenglei wrote:
> Remove FatBinPkg and modify Maintainers.txt.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1105
>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> FatBinPkg/EnhancedFatDxe/AArch64/Fat.efi | Bin 26752 -> 0 bytes
> FatBinPkg/EnhancedFatDxe/Arm/Fat.efi | Bin 17152 -> 0 bytes
> FatBinPkg/EnhancedFatDxe/Ebc/Fat.efi | Bin 79136 -> 0 bytes
> FatBinPkg/EnhancedFatDxe/Fat.inf | 48 -----------------------
> FatBinPkg/EnhancedFatDxe/Ia32/Fat.efi | Bin 21088 -> 0 bytes
> FatBinPkg/EnhancedFatDxe/Ipf/Fat.efi | Bin 154400 -> 0 bytes
> FatBinPkg/EnhancedFatDxe/X64/Fat.efi | Bin 28576 -> 0 bytes
> FatBinPkg/FatBinPkg.dec | 20 ----------
> FatBinPkg/ReadMe.txt | 9 -----
> Maintainers.txt | 2 +-
> 10 files changed, 1 insertion(+), 78 deletions(-)
> delete mode 100644 FatBinPkg/EnhancedFatDxe/AArch64/Fat.efi
> delete mode 100755 FatBinPkg/EnhancedFatDxe/Arm/Fat.efi
> delete mode 100644 FatBinPkg/EnhancedFatDxe/Ebc/Fat.efi
> delete mode 100644 FatBinPkg/EnhancedFatDxe/Fat.inf
> delete mode 100644 FatBinPkg/EnhancedFatDxe/Ia32/Fat.efi
> delete mode 100644 FatBinPkg/EnhancedFatDxe/Ipf/Fat.efi
> delete mode 100644 FatBinPkg/EnhancedFatDxe/X64/Fat.efi
> delete mode 100644 FatBinPkg/FatBinPkg.dec
> delete mode 100644 FatBinPkg/ReadMe.txt
I'm happy about this patch.
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
I've got two requests, before you push:
- please wait for some more reviews,
- please update the subject, replacing "modify document" with "refresh
Maintainers.txt".
Thanks!
Laszlo
next prev parent reply other threads:[~2018-10-17 11:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 7:11 [PATCH] FatBinPkg: Remove FatBinPkg and modify document shenglei
2018-10-16 7:51 ` Ni, Ruiyu
2018-10-17 11:18 ` Laszlo Ersek [this message]
2018-10-17 13:29 ` Gao, Liming
2018-10-18 1:08 ` Ard Biesheuvel
2018-10-18 1:09 ` Andrew Fish
2018-10-18 2:14 ` Leif Lindholm
2018-10-24 5:26 ` Gao, Liming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bff36ed9-a19d-a3a7-255a-5e766b8807f8@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox